Bug 1306807 - use mutex on single core machines
Summary: use mutex on single core machines
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Prasanna Kumar Kalever
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-02-11 18:22 UTC by Prasanna Kumar Kalever
Modified: 2016-06-16 13:57 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.8rc2
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-06-16 13:57:29 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Prasanna Kumar Kalever 2016-02-11 18:22:52 UTC
Description of problem:
Avoid using spinlocks on single core machines

Version-Release number of selected component (if applicable):
mainline

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Vijay Bellur 2016-02-11 18:39:03 UTC
REVIEW: http://review.gluster.org/13432 (lock: use spinlock only on multicore systems) posted (#1) for review on master by Prasanna Kumar Kalever (pkalever)

Comment 2 Vijay Bellur 2016-02-26 08:07:44 UTC
REVIEW: http://review.gluster.org/13432 (lock: use spinlock only on multicore systems) posted (#2) for review on master by Jeff Darcy (jdarcy)

Comment 3 Vijay Bellur 2016-02-26 11:57:52 UTC
REVIEW: http://review.gluster.org/13432 (lock: use spinlock only on multicore systems) posted (#3) for review on master by Jeff Darcy (jdarcy)

Comment 4 Vijay Bellur 2016-02-27 13:55:43 UTC
REVIEW: http://review.gluster.org/13432 (lock: use spinlock only on multicore systems) posted (#4) for review on master by Jeff Darcy (jdarcy)

Comment 5 Vijay Bellur 2016-02-27 18:14:39 UTC
REVIEW: http://review.gluster.org/13432 (lock: use spinlock only on multicore systems) posted (#5) for review on master by Prasanna Kumar Kalever (pkalever)

Comment 6 Vijay Bellur 2016-02-29 05:56:48 UTC
REVIEW: http://review.gluster.org/13432 (lock: use spinlock only on multicore systems) posted (#6) for review on master by Prasanna Kumar Kalever (pkalever)

Comment 7 Vijay Bellur 2016-03-17 06:30:40 UTC
REVIEW: http://review.gluster.org/13432 (lock: use spinlock only on multicore systems) posted (#7) for review on master by Prasanna Kumar Kalever (pkalever)

Comment 8 Vijay Bellur 2016-03-17 13:55:54 UTC
COMMIT: http://review.gluster.org/13432 committed in master by Jeff Darcy (jdarcy) 
------
commit 7e44c783ad731856956929f6614bbe045c26ea3a
Author: Prasanna Kumar Kalever <prasanna.kalever>
Date:   Thu Feb 11 23:45:37 2016 +0530

    lock: use spinlock only on multicore systems
    
    Using spinlocks on a single-core system makes usually no meaning,
    since as long as the spinlock polling is blocking the only available
    CPU core, no other thread can run and since no other thread can run,
    the lock won't be unlocked until its time quantum expires and it gets
    de-scheduled. In other words, a spinlock wastes CPU time on those
    systems for no real benefit. If the thread was put to sleep instead,
    another thread could have ran at once, possibly unlocking the lock and
    then allowing the first thread to continue processing, once it woke up
    again.
    
    Change-Id: I0ffc14e26c2e150b564bcb682a576859ab1d1872
    BUG: 1306807
    Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever>
    Reviewed-on: http://review.gluster.org/13432
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 9 Mike McCune 2016-03-28 23:22:56 UTC
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

Comment 10 Niels de Vos 2016-06-16 13:57:29 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.