Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/mkdocs-bootswatch.spec SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/mkdocs-bootswatch-0.2.0-1.fc24.src.rpm Description: Bootswatch themes for MkDocs Fedora Account System Username: williamjmorenor
I can review this
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=13566688 naming: ok sources: ok, mostly 49915cecc84ac6ec5846103d503d1163 0.2.0.tar.gz 1. SHOULD follow https://fedoraproject.org/wiki/Packaging:SourceURL#Git_Tags so tarball name could be more legible (ie, be of the form: %{name}-%{version}.tar.gz) licensing: ok $ rpmlint *.src.rpm mkdocs-bootswatch.src: W: no-version-in-last-changelog 2. SHOULD follow changelog guidelines: https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#Changelogs all of which explicitly include the version-release of the package macros: ok scriplets: ok, n/a Fairly simple and clean noarch pkg, only a couple of cosmetic SHOULD items you can consider fixing, but not worth blocking the review. APPROVED
Thanks for the review, I have updated the spec to the lastes upstream release and fixfed the changelog.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/mkdocs-bootswatch
mkdocs-bootswatch-0.4.0-1.fc24 mkdocs-bootstrap-0.1.1-2.fc24 mkdocs-0.15.3-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-f63ba33ad9
mkdocs-bootswatch-0.4.0-1.fc23 mkdocs-bootstrap-0.1.1-2.fc23 mkdocs-0.15.3-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-148631cb5e
mkdocs-0.15.3-2.fc24, mkdocs-bootstrap-0.1.1-2.fc24, mkdocs-bootswatch-0.4.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-f63ba33ad9
mkdocs-0.15.3-2.fc23, mkdocs-bootstrap-0.1.1-2.fc23, mkdocs-bootswatch-0.4.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-148631cb5e
mkdocs-0.15.3-2.fc23, mkdocs-bootstrap-0.1.1-2.fc23, mkdocs-bootswatch-0.4.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
mkdocs-0.15.3-2.fc24, mkdocs-bootstrap-0.1.1-2.fc24, mkdocs-bootswatch-0.4.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.