Hide Forgot
In OSE 3.2, the system will run a fsck (file system consistency check) before a mount operation on a new volume is run. This might just be a note in the guide, but make sure to explain the rationale for this feature. Dev for this feature is: Sami Wagiaalla QA for this feature is: Jianwei Hou Trello card is: https://trello.com/c/XU3VznyD/45-3-fsck-before-mount-just-to-make-sure-it-s-clean-each-time-openshift-online-ops-rfe-origin Likely Guide is: https://docs.openshift.com/enterprise/3.1/dev_guide/volumes.html
Hi Sami, IIUC fsck(8) is done prior to mount(8), and mount is done for both "oc volume --add" and "oc volume --add --overwrite" (documented in sections "Adding Volumes" and "Updating Volumes", respectively -- see link in BZ Description). Here are some questions, the set in a small decision-tree format, and the latter regarding the reason for calling fsck: - Is this correct? - If yes: - Are the fsck calls identical in these two scenarios? - If yes: I plan to add a blurb in the Overview. WDYT? - If no: What are the differences in fsck calls in these two scenarios? - If no: - Could you please explain in which scenarios fsck is called? Regarding the blurb, i will add something along the lines of: "Prior to the actual mount(8) call, OpenShift calls fsck(8) to <REASON>." My question here is: What to put for <REASON>?
> IIUC fsck(8) is done prior to mount(8), and mount is done for both "oc > volume --add" and "oc volume --add --overwrite" (documented in sections > "Adding Volumes" and "Updating Volumes", respectively -- see link in BZ > Description). > > Here are some questions, the set in a small decision-tree format, and the > latter regarding the reason for calling fsck: > > - Is this correct? Yes that is correct. > - If yes: > - Are the fsck calls identical in these two scenarios? They are yes. > - If yes: I plan to add a blurb in the Overview. WDYT? The blurb sounds good to me! > Regarding the blurb, i will add something along the lines of: > "Prior to the actual mount(8) call, OpenShift calls fsck(8) to <REASON>." > > My question here is: What to put for <REASON>? You can add something like: to ensure that the file system on the volume contains no errors and, if errors are present, to repair them when possible.
PR: https://github.com/openshift/openshift-docs/pull/1733 Moving status to MODIFIED.
Thanks Sami and Alex for the technical and peer reviews, respectively. JianWei, WDYT?
Commit pushed to master at https://github.com/openshift/openshift-docs https://github.com/openshift/openshift-docs/commit/995379bad019a9bbcd71a0874964f0555c9c0620 Merge pull request #1733 from tnguyen-rh/bz1307211 Bug 1307211 - Mention fsck(8) prior to mount(8) in "Volumes" Overview.
This documentation looks good to me! Mark this bug as verified, thanks!
Verified live: https://docs.openshift.com/enterprise/3.2/dev_guide/volumes.html#overview https://access.redhat.com/documentation/en/openshift-enterprise/3.2/developer-guide/chapter-18-managing-volumes (section 18.1) Closing.