Bug 1307280 - LibRaw: FTBFS in rawhide
Summary: LibRaw: FTBFS in rawhide
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: LibRaw
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Gwyn Ciesla
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F24FTBFS
TreeView+ depends on / blocked
 
Reported: 2016-02-13 20:56 UTC by Fedora Release Engineering
Modified: 2016-02-24 14:50 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-02-24 14:50:45 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
build.log (97.06 KB, text/plain)
2016-02-13 20:56 UTC, Fedora Release Engineering
no flags Details
root.log (81.53 KB, text/plain)
2016-02-13 20:56 UTC, Fedora Release Engineering
no flags Details
state.log (621 bytes, text/plain)
2016-02-13 20:56 UTC, Fedora Release Engineering
no flags Details
Build log, post patch (39.83 KB, text/plain)
2016-02-22 16:15 UTC, Gwyn Ciesla
no flags Details

Description Fedora Release Engineering 2016-02-13 20:56:23 UTC
Your package LibRaw failed to build from source in current rawhide.

http://koji.fedoraproject.org/koji/taskinfo?taskID=12804333

For details on mass rebuild see https://fedoraproject.org/wiki/Fedora_24_Mass_Rebuild

Comment 1 Fedora Release Engineering 2016-02-13 20:56:26 UTC
Created attachment 1123911 [details]
build.log

Comment 2 Fedora Release Engineering 2016-02-13 20:56:27 UTC
Created attachment 1123912 [details]
root.log

Comment 3 Fedora Release Engineering 2016-02-13 20:56:28 UTC
Created attachment 1123913 [details]
state.log

Comment 4 Yaakov Selkowitz 2016-02-19 20:34:51 UTC
Proposed fix: https://github.com/LibRaw/LibRaw/issues/56

Comment 5 Gwyn Ciesla 2016-02-22 16:15:03 UTC
Created attachment 1129400 [details]
Build log, post patch

This fails:

Comment 6 Yaakov Selkowitz 2016-02-23 22:29:28 UTC
dcraw/dcraw.c isn't actually built in LibRaw; instead, it is merged into internal/dcraw_common.cpp.  The first two hunks of that patch apply cleanly to the latter, and the third shouldn't be required.

Comment 7 Gwyn Ciesla 2016-02-24 14:07:16 UTC
That helped, and it now builds on i386 and x86_64, but dies on ARM.

internal/dcraw_common.cpp: In member function 'void LibRaw::kodak_radc_load_raw()':
internal/dcraw_common.cpp:2491:3: error: narrowing conversion of '-2' from 'int' to 'char' inside { } [-Wnarrowing]
   };
   ^
internal/dcraw_common.cpp:2491:3: error: narrowing conversion of '-3' from 'int' to 'char' inside { } [-Wnarrowing]
internal/dcraw_common.cpp:2491:3: error: narrowing conversion of '-17' from 'int' to 'char' inside { } [-Wnarrowing]
internal/dcraw_common.cpp:2491:3: error: narrowing conversion of '-5' from 'int' to 'char' inside { } [-Wnarrowing]
internal/dcraw_common.cpp:2491:3: error: narrowing conversion of '-7' from 'int' to 'char' inside { } [-Wnarrowing]
internal/dcraw_common.cpp:2491:3: error: narrowing conversion of '-18' from 'int' to 'char' inside { } [-Wnarrowing]
internal/dcraw_common.cpp:2491:3: error: narrowing conversion of '-9' from 'int' to 'char' inside { } [-Wnarrowing]
internal/dcraw_common.cpp:2491:3: error: narrowing conversion of '-2' from 'int' to 'char' inside { } [-Wnarrowing]
internal/dcraw_common.cpp:2491:3: error: narrowing conversion of '-28' from 'int' to 'char' inside { } [-Wnarrowing]
internal/dcraw_common.cpp:2491:3: error: narrowing conversion of '-49' from 'int' to 'char' inside { } [-Wnarrowing]
internal/dcraw_common.cpp:2491:3: error: narrowing conversion of '-9' from 'int' to 'char' inside { } [-Wnarrowing]
internal/dcraw_common.cpp:2491:3: error: narrowing conversion of '-79' from 'int' to 'char' inside { } [-Wnarrowing]
internal/dcraw_common.cpp:2491:3: error: narrowing conversion of '-1' from 'int' to 'char' inside { } [-Wnarrowing]
internal/dcraw_common.cpp:2491:3: error: narrowing conversion of '-16' from 'int' to 'char' inside { } [-Wnarrowing]
internal/dcraw_common.cpp:2491:3: error: narrowing conversion of '-37' from 'int' to 'char' inside { } [-Wnarrowing]
internal/dcraw_common.cpp:2491:3: error: narrowing conversion of '-26' from 'int' to 'char' inside { } [-Wnarrowing]
internal/dcraw_common.cpp:2491:3: error: narrowing conversion of '-13' from 'int' to 'char' inside { } [-Wnarrowing]
internal/dcraw_common.cpp:2491:3: error: narrowing conversion of '-39' from 'int' to 'char' inside { } [-Wnarrowing]
internal/dcraw_common.cpp:2491:3: error: narrowing conversion of '-55' from 'int' to 'char' inside { } [-Wnarrowing]
internal/dcraw_common.cpp:2491:3: error: narrowing conversion of '-76' from 'int' to 'char' inside { } [-Wnarrowing]

Comment 8 Yaakov Selkowitz 2016-02-24 14:23:43 UTC
(In reply to Jon Ciesla from comment #7)
> That helped, and it now builds on i386 and x86_64, but dies on ARM.
> 
> internal/dcraw_common.cpp: In member function 'void
> LibRaw::kodak_radc_load_raw()':
> internal/dcraw_common.cpp:2491:3: error: narrowing conversion of '-2' from
> 'int' to 'char' inside { } [-Wnarrowing]

'char' is unsigned on ARM; change that to use an explicit signed char[].

Comment 9 Jan Kurik 2016-02-24 14:31:42 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle.
Changing version to '24'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase

Comment 10 Gwyn Ciesla 2016-02-24 14:50:45 UTC
That works, thanks!


Note You need to log in before you can comment on or make changes to this bug.