Spec URL: https://raw.githubusercontent.com/RussianFedora/mediaconch/master/mediaconch.spec SRPM URL: http://koji.russianfedora.pro/kojifiles/work/tasks/5063/65063/mediaconch-16.01-1.fc24.R.src.rpm Description: MediaConch is an implementation checker, policy checker, reporter, and fixer that targets preservation-level audiovisual files (specifically Matroska, Linear Pulse Code Modulation (LPCM) and FF Video Codec 1 (FFV1)). This project is maintained by MediaArea and funded by PREFORMA. This project from developers of mediainfo software. I think it will be suitable for Fedora repository.
Spec URL: http://raw.githubusercontent.com/RussianFedora/mediaconch/master/mediaconch.spec SRPM URL: http://koji.russianfedora.pro/kojifiles/packages/mediaconch/16.02/1.fc25.R/src/mediaconch-16.02-1.fc25.R.src.rpm Updated to 16.02. Corrected lecenses.
Spec URL: http://raw.githubusercontent.com/RussianFedora/mediaconch/master/mediaconch.spec SRPM URL: http://koji.russianfedora.pro/kojifiles/packages/mediaconch/16.03/1.fc25.R/src/mediaconch-16.03-1.fc25.R.src.rpm Updated to 16.03. Corrected build for EPEL 7.
Spec URL: http://raw.githubusercontent.com/RussianFedora/mediaconch/master/mediaconch.spec SRPM URL: http://koji.russianfedora.pro/kojifiles/packages/mediaconch/16.03/3.fc25.R/src/mediaconch-16.03-3.fc25.R.src.rpm Added appdata XML and its validate. Added systemd module for run mediaconchd server. Use pkgconfig in BR.
Spec URL: http://raw.githubusercontent.com/RussianFedora/mediaconch/master/mediaconch.spec SRPM URL: http://koji.russianfedora.pro/kojifiles/packages/mediaconch/16.04/1.fc25.R/src/mediaconch-16.04-1.fc25.R.src.rpm Updated to 16.04.
Spec URL: http://raw.githubusercontent.com/RussianFedora/mediaconch/master/mediaconch.spec SRPM URL: http://koji.russianfedora.pro/kojifiles/packages/mediaconch/16.05/1.fc25.R/src/mediaconch-16.05-1.fc25.R.src.rpm Updated to 16.05.
Spec URL: http://raw.githubusercontent.com/RussianFedora/mediaconch/master/mediaconch.spec SRPM URL: http://koji.russianfedora.pro/kojifiles/packages/mediaconch/16.10/1.fc26/src/mediaconch-16.10-1.fc26.src.rpm Updated to 16.11.
Spec URL: http://raw.githubusercontent.com/RussianFedora/mediaconch/master/mediaconch.spec SRPM URL: http://koji.russianfedora.pro/kojifiles/packages/mediaconch/16.11/1.fc26/src/mediaconch-16.11-1.fc26.src.rpm Real pdated to 16.11.
Spec URL: http://raw.githubusercontent.com/RussianFedora/mediaconch/master/mediaconch.spec SRPM URL: http://koji.russianfedora.pro/kojifiles/work/tasks/3661/53661/mediaconch-17.06-1.fc27.src.rpm Updated to 17.06.
I will review this package.
> %if 0%{?fedora} || 0%{?rhel} > 7 Can be replaced to: %if 0%{?rhel} < 7 BuildRequires: pkgconfig(Qt5WebKit) %else BuildRequires: pkgconfig(Qt5WebEngine) %endif Group should be removed from main package and all it's subpackages. > Requires: libzen%{?_isa} >= %{libzen_version} > Requires: libmediainfo%{?_isa} >= %{libmediainfo_version} Rpmlint will throw an error on this rows. Library dependencies should be resolved automatically via rpmbuild. > make install-strip DESTDIR=%{buildroot} You don't need to strip binaries manually. Rpmbuild will do it for you and generate -debuginfo subpackage. > install -dm 755 %{buildroot}%{_datadir}/kde4/services/ServiceMenus/ > install -m 644 -p Project/GNU/GUI/mediaconch-gui.kde4.desktop %{buildroot}%{_datadir}/kde4/services/ServiceMenus/mediaconch-gui.desktop This should be moved into -kde subpackage with dependency on KDE. > install -dm 755 %{buildroot}%{_datadir}/apps/konqueror/servicemenus > install -m 644 -p Project/GNU/GUI/mediaconch-gui.kde3.desktop %{buildroot}%{_datadir}/apps/konqueror/servicemenus/mediaconch-gui.desktop This should be removed as KDE3 already reached it's EOL and dropped from Fedora repositories.
Vitaly, thank you for your review, appreciated. > This should be moved into -kde subpackage with dependency on KDE. I see that other Fedora .rpms have the .desktop file included in their main .rpm (no -kde subpackage), just with a different path. Is it OK if we move (after checking all is up to date) the .desktop file to /usr/share/applications instead of having just this .desktop file in a -kde subpackage?
Spec URL: http://raw.githubusercontent.com/RussianFedora/mediaconch/master/mediaconch.spec SRPM URL: http://koji.russianfedora.pro/kojifiles/work/tasks/3953/53953/mediaconch-17.06-2.fc27.src.rpm 1. Removed all %if 2. Removed Requires libzen and libmediainfo 3. make install-strip DESTDIR=%{buildroot} changed to %make_install 4. Removed all KDE specific desktop files.
Automatic check results: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. Note: These BR are not needed: gcc-c++ See: http://fedoraproject.org/wiki/Packaging/Guidelines#Exceptions_2 - update-desktop-database is invoked in %post and %postun if package contains desktop file(s) with a MimeType: entry. Note: desktop file(s) with MimeType entry in mediaconch-gui See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop- database ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MPL (v2.0)", "*No copyright* CC by-sa (v4.0)", "GPL (v3 or later)", "Unknown or generated", "*No copyright* MPL (v2.0)". 446 files have unknown license. Detailed output of licensecheck in /home/vitaly/1308488-mediaconch/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [ ]: Package requires other packages for directories it uses. Note: No known owner of /etc/mediaconch [ ]: Package must own all directories that it creates. Note: Directories without known owners: /etc/mediaconch [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [ ]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [ ]: Package consistently uses macros (instead of hard-coded directory names). [ ]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [ ]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [ ]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [ ]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in mediaconch-gui [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 6 files. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: %config files are marked noreplace or the reason is justified. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: No %config files under /usr. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ ]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in mediaconch-gui , mediaconch-server , mediaconch-debuginfo [ ]: Package functions as described. [ ]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [ ]: Scriptlets must be sane, if used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Package should not use obsolete m4 macros Note: Some obsoleted macros found, see the attachment. See: https://fedorahosted.org/FedoraReview/wiki/AutoTools [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mediaconch-17.06-2.fc27.x86_64.rpm mediaconch-gui-17.06-2.fc27.x86_64.rpm mediaconch-server-17.06-2.fc27.x86_64.rpm mediaconch-debuginfo-17.06-2.fc27.x86_64.rpm mediaconch-17.06-2.fc27.src.rpm mediaconch.x86_64: W: only-non-binary-in-usr-lib mediaconch.x86_64: W: hidden-file-or-dir /usr/lib/.build-id mediaconch.x86_64: W: hidden-file-or-dir /usr/lib/.build-id mediaconch.x86_64: W: no-manual-page-for-binary mediaconch mediaconch-gui.x86_64: W: only-non-binary-in-usr-lib mediaconch-gui.x86_64: W: hidden-file-or-dir /usr/lib/.build-id mediaconch-gui.x86_64: W: hidden-file-or-dir /usr/lib/.build-id mediaconch-gui.x86_64: W: no-manual-page-for-binary mediaconch-gui mediaconch-server.x86_64: W: hidden-file-or-dir /usr/lib/.build-id mediaconch-server.x86_64: W: hidden-file-or-dir /usr/lib/.build-id mediaconch-server.x86_64: W: no-manual-page-for-binary mediaconchd mediaconch-debuginfo.x86_64: E: useless-provides debuginfo(build-id) 5 packages and 0 specfiles checked; 1 errors, 11 warnings. Rpmlint (debuginfo) ------------------- Checking: mediaconch-debuginfo-17.06-2.fc27.x86_64.rpm mediaconch-debuginfo.x86_64: E: useless-provides debuginfo(build-id) 1 packages and 0 specfiles checked; 1 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory mediaconch-gui.x86_64: W: only-non-binary-in-usr-lib mediaconch-gui.x86_64: W: no-manual-page-for-binary mediaconch-gui mediaconch-debuginfo.x86_64: E: useless-provides debuginfo(build-id) mediaconch.x86_64: W: only-non-binary-in-usr-lib mediaconch.x86_64: W: no-manual-page-for-binary mediaconch mediaconch-server.x86_64: W: no-manual-page-for-binary mediaconchd 4 packages and 0 specfiles checked; 1 errors, 5 warnings. Requires -------- mediaconch-gui (rpmlib, GLIBC filtered): /bin/sh hicolor-icon-theme libGL.so.1()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.9)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Positioning.so.5()(64bit) libQt5PrintSupport.so.5()(64bit) libQt5Qml.so.5()(64bit) libQt5Quick.so.5()(64bit) libQt5WebChannel.so.5()(64bit) libQt5WebChannel.so.5(Qt_5)(64bit) libQt5WebEngineCore.so.5()(64bit) libQt5WebEngineWidgets.so.5()(64bit) libQt5WebEngineWidgets.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libevent-2.0.so.5()(64bit) libexslt.so.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libgcrypt.so.20()(64bit) libgpg-error.so.0()(64bit) libjansson.so.4()(64bit) liblzma.so.5()(64bit) libm.so.6()(64bit) libmediainfo.so.0()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libsqlite3.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.5.2)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libxslt.so.1()(64bit) libxslt.so.1(LIBXML2_1.0.11)(64bit) libxslt.so.1(LIBXML2_1.0.18)(64bit) libz.so.1()(64bit) libzen.so.0()(64bit) rtld(GNU_HASH) mediaconch-debuginfo (rpmlib, GLIBC filtered): mediaconch (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdl.so.2()(64bit) libevent-2.0.so.5()(64bit) libexslt.so.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libgcrypt.so.20()(64bit) libgpg-error.so.0()(64bit) libjansson.so.4()(64bit) liblzma.so.5()(64bit) libm.so.6()(64bit) libmediainfo.so.0()(64bit) libpthread.so.0()(64bit) libsqlite3.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.5.2)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libxslt.so.1()(64bit) libxslt.so.1(LIBXML2_1.0.11)(64bit) libxslt.so.1(LIBXML2_1.0.18)(64bit) libz.so.1()(64bit) libzen.so.0()(64bit) rtld(GNU_HASH) mediaconch-server (rpmlib, GLIBC filtered): /bin/sh config(mediaconch-server) libc.so.6()(64bit) libdl.so.2()(64bit) libevent-2.0.so.5()(64bit) libexslt.so.0()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.4)(64bit) libgcrypt.so.20()(64bit) libgpg-error.so.0()(64bit) libjansson.so.4()(64bit) liblzma.so.5()(64bit) libm.so.6()(64bit) libmediainfo.so.0()(64bit) libpthread.so.0()(64bit) libsqlite3.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libxml2.so.2()(64bit) libxml2.so.2(LIBXML2_2.4.30)(64bit) libxml2.so.2(LIBXML2_2.5.2)(64bit) libxml2.so.2(LIBXML2_2.6.0)(64bit) libxslt.so.1()(64bit) libxslt.so.1(LIBXML2_1.0.11)(64bit) libxslt.so.1(LIBXML2_1.0.18)(64bit) libz.so.1()(64bit) libzen.so.0()(64bit) rtld(GNU_HASH) systemd Provides -------- mediaconch-gui: appdata() appdata(mediaconch-gui.appdata.xml) application() application(mediaconch-gui.desktop) mediaconch-gui mediaconch-gui(x86-64) mimehandler(application/ogg) mimehandler(application/vnd.rn-realmedia) mimehandler(application/x-extension-mp4) mimehandler(application/x-flac) mimehandler(application/x-matroska) mimehandler(application/x-ogg) mimehandler(application/x-shockwave-flash) mimehandler(application/x-shorten) mimehandler(audio/amr) mimehandler(audio/amr-wb) mimehandler(audio/mp4) mimehandler(audio/mpeg) mimehandler(audio/vnd.rn-realaudio) mimehandler(audio/webm) mimehandler(audio/x-ape) mimehandler(audio/x-flac) mimehandler(audio/x-m4a) mimehandler(audio/x-matroska) mimehandler(audio/x-mp3) mimehandler(audio/x-mpeg) mimehandler(audio/x-mpegurl) mimehandler(audio/x-ms-asf) mimehandler(audio/x-ms-asx) mimehandler(audio/x-ms-wax) mimehandler(audio/x-opus+ogg) mimehandler(audio/x-pn-aiff) mimehandler(audio/x-pn-au) mimehandler(audio/x-pn-realaudio) mimehandler(audio/x-pn-wav) mimehandler(audio/x-pn-windows-acm) mimehandler(audio/x-real-audio) mimehandler(audio/x-scpls) mimehandler(audio/x-tta) mimehandler(audio/x-vorbis+ogg) mimehandler(audio/x-wav) mimehandler(audio/x-wavpack) mimehandler(video/mp2t) mimehandler(video/mp4) mimehandler(video/mp4v-es) mimehandler(video/mpeg) mimehandler(video/msvideo) mimehandler(video/quicktime) mimehandler(video/vnd.rn-realvideo) mimehandler(video/webm) mimehandler(video/x-anim) mimehandler(video/x-avi) mimehandler(video/x-flc) mimehandler(video/x-fli) mimehandler(video/x-flv) mimehandler(video/x-matroska) mimehandler(video/x-mpeg) mimehandler(video/x-ms-asf) mimehandler(video/x-ms-wmv) mimehandler(video/x-msvideo) mimehandler(video/x-nsv) mimehandler(video/x-ogm+ogg) mediaconch-debuginfo: debuginfo(build-id) mediaconch-debuginfo mediaconch-debuginfo(x86-64) mediaconch: mediaconch mediaconch(x86-64) mediaconch-server: config(mediaconch-server) mediaconch-server mediaconch-server(x86-64) Source checksums ---------------- https://mediaarea.net/download/source/mediaconch/17.06/mediaconch_17.06.tar.xz : CHECKSUM(SHA256) this package : 7810d076d01cb21b2073a90adabd48fd213e16b54b3ff343f8be6a2421bd2be3 CHECKSUM(SHA256) upstream package : 7810d076d01cb21b2073a90adabd48fd213e16b54b3ff343f8be6a2421bd2be3 AutoTools: Obsoleted m4s found ------------------------------ AC_PROG_LIBTOOL found in: MediaConch/Project/GNU/CLI/configure.ac:29, MediaConch/Project/GNU/Server/configure.ac:29 Generated by fedora-review 0.6.1 (f03e4e7) last change: 2016-05-02 Command line :/usr/bin/fedora-review -b 1308488 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Manual checks: ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. Pass. [ ]: Package contains no static executables. Pass. Generic: [ ]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. Pass. [ ]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MPL (v2.0)", "*No copyright* CC by-sa (v4.0)", "GPL (v3 or later)", "Unknown or generated", "*No copyright* MPL (v2.0)". 446 files have unknown license. Detailed output of licensecheck in /home/vitaly/1308488-mediaconch/licensecheck.txt Pass. But some of source files don't contain license preamble. You should ask upstream to add it. [ ]: License file installed when any subpackage combination is installed. Pass. [ ]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. Pass. [ ]: Package requires other packages for directories it uses. Note: No known owner of /etc/mediaconch [ ]: Package must own all directories that it creates. Note: Directories without known owners: /etc/mediaconch Fail. Directory ownership /etc/mediaconch can be fixed during import to Fedora SCM. [ ]: %build honors applicable compiler flags or justifies otherwise. Pass. [ ]: Package contains no bundled libraries without FPC exception. Pass. [ ]: Changelog in prescribed format. Pass. [ ]: Sources contain only permissible code or content. Pass. [ ]: Development files must be in a -devel package Pass. [ ]: Package uses nothing in %doc for runtime. Pass. [ ]: Package consistently uses macros (instead of hard-coded directory names). Pass. [ ]: Package is named according to the Package Naming Guidelines. Pass. [ ]: Package does not generate any conflict. Pass. [ ]: Package obeys FHS, except libexecdir and /usr/target. Pass. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. Pass. [ ]: Requires correct, justified where necessary. Pass. [ ]: Spec file is legible and written in American English. Pass. [ ]: Package contains systemd file(s) if in need. Pass. [ ]: gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in mediaconch-gui Pass. [ ]: Useful -debuginfo package or justification otherwise. Pass. [ ]: Package is not known to require an ExcludeArch tag. Pass. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 6 files. Pass. [ ]: Package complies to the Packaging Guidelines Pass.
Now you need to fix directory ownership and obsoleted m4s. Then I will approve this package.
Spec URL: http://raw.githubusercontent.com/RussianFedora/mediaconch/master/mediaconch.spec SRPM URL: http://koji.russianfedora.pro/kojifiles/work/tasks/4044/54044/mediaconch-17.06-3.fc27.src.rpm All corrected.
LGTM. Package approved.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/mediaconch