Description of problem: Drools and jBPM engine tests do not support MariaDB: - org.drools.persistence.util.PersistenceUtil - org.jbpm.persistence.util.PersistenceUtil I would like to ask about the SQL scripts [1] and [2]: It seems that SQL scripts are defined for each hibernate dialect (and NOT for each database). Since MySQL and MariaDB share the same Hibernate dialect, is it safe to assume that the same SQL script would be used for both? Based on that decision, we might need to revisit [3]. [1] https://github.com/droolsjbpm/jbpm/tree/master/jbpm-installer/db/ddl-scripts [2] https://github.com/droolsjbpm/jbpm/tree/master/jbpm-installer/db/upgrade-scripts [3] https://github.com/droolsjbpm/jbpm/blob/master/jbpm-installer/src/test/java/org/jbpm/persistence/scripts/util/TestsUtil.java#L78 Version-Release number of selected component (if applicable): BRMS 6.3.0 DR1 Steps to Reproduce: 1. run drools/jbpm tests with MariaDB Actual results: Datasource cannot be created. Expected results: Datasource is created successfully.
I see that - org.drools.persistence.util.PersistenceUtil - org.jbpm.persistence.util.PersistenceUtil no longer exist on master (but do on 6.4.x). Would backporting the change from master be possible?
I see that the class PersistenceUtil has been moved to kie-test-util on master.
Created PR adding support for MariaDB to engine tests: https://github.com/droolsjbpm/drools/pull/649 The question about DDL scripts is still open.
Marek, am I assuming correctly that we need the same change in https://github.com/droolsjbpm/jbpm/blob/master/jbpm-persistence-jpa/src/test/java/org/jbpm/persistence/util/PersistenceUtil.java#L181 ? Since jBPM does not (yet) use the PersistenceUtil from kie-test-util, but rather has its own copy.
Petr, yes, we need it there as well, thanks!
Fixed in Drools and jBPM repos. This should hopefully be enough. Marek, if you could double check there isn't anything missing, that would be great. Commits (6.4.x): https://github.com/droolsjbpm/drools/commit/a4205d786efb https://github.com/droolsjbpm/jbpm/commit/613301ccbe8f Commits (master): https://github.com/droolsjbpm/drools/commit/1bd53e663d40 https://github.com/droolsjbpm/jbpm/commit/b9b0758c00f8
The changes have helped, but it seems we have missed one more occurrence [1]. Sorry for not getting to this sooner. [1] https://github.com/droolsjbpm/jbpm/blob/master/jbpm-human-task/jbpm-human-task-core/src/test/java/org/jbpm/services/task/identity/DBUserGroupCallbackImplTest.java
Fixed the (hopefully) last occurrence. 6.4.x: https://github.com/droolsjbpm/jbpm/commit/4f25f93f37142985 master: https://github.com/droolsjbpm/jbpm/commit/4d1ef8d51be4cdce
Verified in BRMS 6.3.0 ER3.