Bug 1309232 - fix options like --live --current for detach-interface command
fix options like --live --current for detach-interface command
Product: Red Hat Enterprise Linux 6
Classification: Red Hat
Component: libvirt (Show other bugs)
x86_64 Unspecified
medium Severity medium
: rc
: ---
Assigned To: Libvirt Maintainers
Virtualization Bugs
Depends On:
  Show dependency treegraph
Reported: 2016-02-17 04:59 EST by Pei Zhang
Modified: 2016-02-23 07:56 EST (History)
6 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2016-02-23 07:56:44 EST
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Pei Zhang 2016-02-17 04:59:17 EST
Description of problem:
As we already fixed some useful options for attach-interface command. the same issue still happens on detach-interface command. perhaps it also needs a fix.

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1.check with virsh help:
# virsh help detach-interface
    detach-interface - detach network interface

    detach-interface <domain> <type> [--mac <string>] [--config]

    Detach network interface.

    [--domain] <string>  domain name, id or uuid
    [--type] <string>  network interface type
    --mac <string>   MAC address
    --config         affect next boot

2.check document 
detach-interface domain type [--mac mac] [--config]
Detach a network interface from a domain.  type can be either network to indicate a physical network device or bridge to indicate a bridge to a device. It is recommended to use the mac option to
distinguish between the interfaces if more than one are present on the domain.  If --config is specified, alter persistent configuration, effect observed on next boot, for compatibility purposes,
--persistent is alias of --config.

3.use --config to detach, it works as --persistent, no only for next boot, but also works for current running states.

# virsh dumpxml r6 | grep interface -A 4
    <interface type='network'>
      <mac address='52:54:00:aa:b4:a1'/>
      <source network='default'/>
      <target dev='vnet0'/>
      <model type='virtio'/>
    <serial type='pty'>

# virsh detach-interface r6 --type network --mac "52:54:00:aa:b4:a1" --config
Interface detached successfully

# virsh dumpxml r6 | grep interface -A 4
# virsh dumpxml r6 --inactive | grep interface -A 4
Nothing output.

Actual results:
As above.

Expected results:
Fix it as same as attach-interface.  

Additional info:
This is only happened on rhel6. Rhel7 already provide other options for detach-interface.

Note You need to log in before you can comment on or make changes to this bug.