+++ This bug was initially created as a clone of Bug #1302040 +++
It will be nice to have option to pass to rpmbuild some argument which will override builhost.
This is useful if you are building inside of container, which have just uuid as host name.
Main question here is how to pass the name. Possible implementations can use a rpm macro - which has the benefit of being part of some package within the build root - or an environment variable - as in #1288713 . A command line option is possible but least preferred as you can also set macros on the command line.
Passing it as macro name is just fine.
FYI: I just started a thread on email@example.com about reproducible build in which this change fits into.
I have a patch to pass it as a macro:
Created attachment 1131998 [details]
Use the _buildhost macro as buildhost if defined
Here is a patch to use the _buildhost macro as buildhost if defined.
(In reply to Nicolas Vigier from comment #5)
> Created attachment 1131998 [details]
> Use the _buildhost macro as buildhost if defined
> Here is a patch to use the _buildhost macro as buildhost if defined.
I think it would be better to have an error when it's >= 1024 rather than silently using the hostname of the machine
(In reply to Pascal Terjan from comment #6)
> I think it would be better to have an error when it's >= 1024 rather than
> silently using the hostname of the machine
section 2.3.4 - the max length of FQDN is 255 characters. So 1024 is way over this limit and never should be reached. So getting to this point is probably result of some mistake or error and in this case throwing error is just fine.
Created attachment 1132230 [details]
Use the _buildhost macro as buildhost if defined v2
Here is a new version of the patch that adds a warning when _buildhost is too long.
Added upstream and to rawhide