Upstream, this software supports Python 3. Please provide a Python 3 package for Fedora. According to the Python packaging guidelines [0], software must be packaged for Python 3 if upstream supports it. The guidelines give detailed information on how to do this, and even provide an example spec file [1]. The current best practice is to provide subpackages for the two Python versions (called "Common SRPM" in the guidelines). Alternatively, if nothing depends on your Python2 package, you can just switch to Python 3 entirely. It's fine to do this in Rawhide only. If anything is unclear, or if you need any kind of assistance with the porting, you can ask on IRC (#fedora-python on Freenode), or reply here. We'll be happy to help! [0] https://fedoraproject.org/wiki/Packaging:Python [1] https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file
This bug appears to have been reported against 'rawhide' during the Fedora 24 development cycle. Changing version to '24'. More information and reason for this action is here: https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora24#Rawhide_Rebase
Created attachment 1180621 [details] python3 subpackages hello i add python3 subpackages and update to 0.9.38 version
Hello. Thank you for your patch. I am reviewing it and I have some suggestions: - Is better to use global definition for module name and then this variable many times in specfile than hardcoded name. You can define global macro this way: %global srcname ladon and then use %{srcname} in name, source url, subpackage names, paths etc. - When you change sw version to the newer one you should change Release back to 1%{?dist} instead of increasing it. - Is better to be more specific in dependencies names (if applicable) - for example python2-setuptools is better than just python-setuptools. - There are no license files. RPM should contain license file. More information and examples can be found in this guideline: http://python-rpm-porting.readthedocs.io/en/latest/index.html
I forgot to mention that this package needs to be rebased to newest specfile version.
(In reply to Lumír Balhar from comment #4) > I forgot to mention that this package needs to be rebased to newest specfile > version. *patch* not package of course :)
Created attachment 1186159 [details] py3 subpackage, update version of lib, add license py3 subpackage, update version of lib, add license
Created attachment 1186160 [details] py3 subpackage, update version of lib, add license
Hello. Patch now looks much better. Just last few points: - You can use %{pypi_name} in %setup line, rm egg-info line, chmod & rm lines in %install and in paths in %files sections (also in name of py3 %files). - There are missing descriptions in subpackages. Also, could you please provide a link to Koji scratch build? Thank you for your work.
Created attachment 1193244 [details] Updates and fixes Hello. Because I've found some issues in Dmitry's patch, I've created new one and tested it in Koji and mock (build, installation and usage). Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15347819
Hi Lumir! Just a few details: 1. There's no text under the %description sections of the two subpackages. 2. I believe it's preferable to make the bindir symlink use a relative path, as both files are in the same folder. I.e.: ln -s ./%{pypi_name}-%{python2_version}-ctl %{buildroot}/%{_bindir}/%{pypi_name}-ctl 3. in the %check section there are 2 annoying warnings for 'macro-in-comment', I suggest adding a second %.
Created attachment 1193337 [details] Updated patch after review Hello Tomas. Here is updated patch with fixed issues. Thank you for review.
Looks good to me, Lumir! Good work!
Hi Matthias, as this is a bit of a time sensitive issue, we would really appreciate if you could take a look at the patch as soon as possible. If you are time constrained right now, I hope you won't mind if we do the review and push the changes ourselves in case you are unable. Thank you!
iirc, adding a license file from somewhere else, other than package upstream is a review blocker. Please remove it and ask upstream, if they could add a license file.
btw: New in 0.9.38 Always bundle both python versions of chardet with the source distribution. That needs careful evaluation. I remember, I unbundled that once, back in the time, where chardet was unmaintained, and python3 version was *created* by running it through 2to3. Now
(In reply to Matthias Runge from comment #14) > iirc, adding a license file from somewhere else, other than package upstream > is a review blocker. Please remove it and ask upstream, if they could add a > license file. I've opened issue in launchpad to add license file to PyPI package [0] and I will replace source link to license file to current revision on launchpad bzr [1] in next version of patch. [0] https://answers.launchpad.net/ladon/+question/359331 [1] http://bazaar.launchpad.net/~ladon-dev-team/ladon/ladon/download/head:/license.txt-20110711093707-sf2ym6bw134bxkep-7/LICENSE.txt?start_revid=142 (In reply to Matthias Runge from comment #15) > btw: > > New in 0.9.38 > > Always bundle both python versions of chardet with the source > distribution. > > > That needs careful evaluation. I remember, I unbundled that once, back in > the time, where chardet was unmaintained, and python3 version was *created* > by running it through 2to3. Now Is possible for you to test this package with chardet installed as dependency? If not, I think we can follow upstream suggestion and leave bundled chardet in package. Thank you for comments.
Are you sure the launchpad page is the right page for ladon? I never communicated with upstream via launchpad. The referenced 'question' seems to be spam, or some copy/paste issue. I always had a direct contact to Jakob, he was very nice and responsive. I just sent him a mail. Let's wait and see what happens. I'd vote AGAINST bundling, and my last version still unbundled. Otherwise I'm fine with retiring the package, I don't use it anymore. Upstream used their bundled version to make chardet ready, iirc. The situation changed with chardet being maintained actively. Another nit: Source0: should be something like https://http://files.pythonhosted.prg/packages/source/l/%{pypi_name}/%{pypi_name}-%{version}.tar.gz
The license file is included in ladon for quite a while now: http://bazaar.launchpad.net/~ladon-dev-team/ladon/ladon/view/head:/frameworks/python/LICENSE.txt
Hello. (In reply to Matthias Runge from comment #17) > Are you sure the launchpad page is the right page for ladon? I never > communicated with upstream via launchpad. Ladon project is hosted on launchpad with all source code, issues and questions. So I think that this is the right place to submit a question. > The referenced 'question' seems to be spam, or some copy/paste issue. I > always had a direct contact to Jakob, he was very nice and responsive. I > just sent him a mail. Let's wait and see what happens. Yes, something went wrong with my question and some robot pasted some mess into my question. I have an email notification about this. > I'd vote AGAINST bundling, and my last version still unbundled. Otherwise > I'm fine with retiring the package, I don't use it anymore. Upstream used > their bundled version to make chardet ready, iirc. The situation changed > with chardet being maintained actively. If you don't want to maintain this package anymore and you haven't anybody who wants, we can stop our porting effort and package can be retired.
This package has changed ownership in the Fedora Package Database. Reassigning to the new owner of this component.
python-ladon-0.9.38-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-7cebe9c1c5
python-ladon-0.9.38-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a32866de98
python-ladon-0.9.38-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a32866de98
python-ladon-0.9.38-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7cebe9c1c5
Created attachment 1258406 [details] Patch to fix python-ladon dragging in Python 2 Hello CAI, thank you for the effort in switching python-ladon to Python 3. However it needs one final touch to be Python 3 ready. Currently, the python-ladon-0.9.38-2 RPM requires both Python 2 and Python 3. There is a stray "/usr/bin/python" shebang in one of the files, which auto-generates the dependency on Python 2 . You may find the change needed to fix auto-generating Python 2 dependency attached. Please review and apply it. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=18108779
Applied. Thank you.
python-ladon-0.9.38-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-49450fc141
python-ladon-0.9.38-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-4b0e3cb7e6
python-ladon-0.9.38-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-49450fc141
python-ladon-0.9.38-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-4b0e3cb7e6
python-ladon-0.9.38-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.
python-ladon-0.9.38-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.