Spec URL: https://rbarlow.fedorapeople.org/erlang-goldrush.spec SRPM URL: https://rbarlow.fedorapeople.org/erlang-goldrush-0.1.8-1.fc24.src.rpm Description: Goldrush is a small Erlang app that provides fast event stream processing. Fedora Account System Username: rbarlow
Peter or Jeremy, Would one of you review this for me? It is needed by erlang-lager-3.1.0, which we need to update for ejabberd-16.01.
rbarlow's scratch build of erlang-goldrush-0.1.8-1.fc24.src.rpm for rawhide completed http://koji.fedoraproject.org/koji/taskinfo?taskID=13043449
(In reply to Randy Barlow from comment #1) > Peter or Jeremy, > > Would one of you review this for me? It is needed by erlang-lager-3.1.0, > which we need to update for ejabberd-16.01. I'll review it.
REVIEW: [+] rpmlint is silent (or produces only messages which can be safely ignored: lemenkov ~/Downloads: rpmlint erlang-goldrush-0.1.8-1.fc24.* erlang-goldrush.x86_64: E: no-binary erlang-goldrush.x86_64: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 1 errors, 1 warnings. lemenkov ~/Downloads: [+] The package is named according to the Package Naming Guidelines. [+] The spec file name matches the base package %{name}, in the format %{name}.spec. [+] The package meets the Packaging Guidelines. [+] The package is licensed with a Fedora approved license and meets the Licensing Guidelines. [+] The License field in the package spec file matches the actual license (MIT). [+] The file, containing the text of the license(s) for the package, is included and marked as %license. [+] The spec file is written in American English. [+] The spec file for the package is legible. [+] The sources used to build the package matches the upstream source, as provided in the spec URL. lemenkov ~/Downloads: sha256sum 0.1.8.tar.gz* 739d8ce15049c54f7e00528edbf536f63a24fdb9dfa053d176e6f97a9832b834 0.1.8.tar.gz 739d8ce15049c54f7e00528edbf536f63a24fdb9dfa053d176e6f97a9832b834 0.1.8.tar.gz.1 lemenkov ~/Downloads: [+] The package successfully compiles and builds into binary rpms. See koji link above. [+] All build dependencies are listed in BuildRequires. [0] No need to handle locales. [0] The package does not contain any shared library files. [+] Packages does not bundle copies of system libraries. [+] The package isn't designed to be relocatable. [+] The package owns all directories that it creates. [+] The package does not list a file more than once in the spec file's %files listings. [+] Permissions on files are set properly. [+] The package consistently uses macros. [+] The package contains code, or permissible content. [0] No large documentation files. [+] Anything, the package includes as %doc, does not affect the runtime of the application. [0] No static libraries. [0] No -devel sub-package. [+] The package does not contain any .la libtool archives. [0] Not a GUI application. [+] The package does not own files or directories already owned by other packages. [+] All filenames in rpm packages are valid UTF-8. APPROVED!
Thanks for grabbing this so quickly, Peter!
Thank you for the review Peter!
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/erlang-goldrush
http://koji.fedoraproject.org/koji/taskinfo?taskID=13052960