Bug 1310390 - Restore snapshot with only subset of vm's disks will stuck the vm in image locked state
Summary: Restore snapshot with only subset of vm's disks will stuck the vm in image lo...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: BLL.Storage
Version: 3.6.3.1
Hardware: Unspecified
OS: Unspecified
unspecified
urgent
Target Milestone: ovirt-3.6.4
: 3.6.4
Assignee: Daniel Erez
QA Contact: Aharon Canan
URL:
Whiteboard:
Depends On:
Blocks: 1317258
TreeView+ depends on / blocked
 
Reported: 2016-02-21 09:50 UTC by Raz Tamir
Modified: 2016-04-05 13:54 UTC (History)
8 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-04-05 13:54:09 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-3.6.z+
rule-engine: blocker+
ylavi: planning_ack+
rule-engine: devel_ack+
acanan: testing_ack+

Attachments (Terms of Use)
engine and vdsm logs (1.40 MB, application/x-gzip)
2016-02-21 09:50 UTC, Raz Tamir 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 53877 0 master MERGED core: Remove condition for AsyncTaskType.notSupported. 2016-02-23 11:34:10 UTC
oVirt gerrit 53887 0 ovirt-engine-3.6 MERGED core: Remove condition for AsyncTaskType.notSupported. 2016-02-23 12:22:59 UTC
oVirt gerrit 54015 0 master MERGED core: CommandBase - avoid setting end status prematurely 2016-03-07 08:09:25 UTC
oVirt gerrit 54017 0 master MERGED Revert "core: Remove condition for AsyncTaskType.notSupported." 2016-02-25 13:34:25 UTC
oVirt gerrit 54019 0 ovirt-engine-3.6 ABANDONED Revert "core: Remove condition for AsyncTaskType.notSupported." 2016-02-25 13:37:55 UTC
oVirt gerrit 54020 0 ovirt-engine-3.6 MERGED Revert "core: Remove condition for AsyncTaskType.notSupported." 2016-02-25 14:56:30 UTC
oVirt gerrit 54393 0 ovirt-engine-3.6 MERGED core: CommandBase - avoid setting end status prematurely 2016-03-07 12:56:08 UTC
oVirt gerrit 54433 0 ovirt-engine-3.6.4 MERGED core: CommandBase - avoid setting end status prematurely 2016-03-07 15:37:01 UTC

Description Raz Tamir 2016-02-21 09:50:54 UTC 
Created attachment 1128943 [details]
engine and vdsm logs

Description of problem:
After restoring a previewed snapshot that contain only subset ov the vm's disks, the vm state will stuck in 'image locked'.
Setup:
VM + 1 disk
Create a snapshot and after, create a new disk.
After the second disk s created, create second snapshot.
Preview the first snapshot and choose the option:
"Include in the previewed VM only the disks that are included in the snapshot."

Restore the previewed snapshot and wait for the vm state to change to 'image locked'.

Version-Release number of selected component (if applicable):
rhevm-3.6.3-0.1.el6.noarch
vdsm-4.17.21-0.el7ev.noarch

How reproducible:
100%

Steps to Reproduce:
1. Create vm + 1 disk
2. Create snapshot from the vm
3. Create second disk + second snapshot containing both disks
4. preview the first snapshot (step 2) and choose the option to "previewed VM only the disks that are included in the snapshot"
5. commit

Actual results:
The vm state will stuck on 'image locked'

Expected results:


Additional info:
Comment 1 Allon Mureinik 2016-02-21 11:36:36 UTC 
Daniel, can you please take a look at this ASAP?
Comment 2 Red Hat Bugzilla Rules Engine 2016-02-21 11:36:42 UTC 
This bug report has Keywords: Regression or TestBlocker.
Since no regressions or test blockers are allowed between releases, it is also being identified as a blocker for this release. Please resolve ASAP.
Comment 3 Daniel Erez 2016-02-21 14:06:37 UTC 
Hi Raz,

The issue doesn't seem to reproduce on my local env (latest build). In which build did you reproduce it? Can you please attach a screencast with the exact steps (just in case I didn't follow it accurately).

Thanks!
Comment 4 Raz Tamir 2016-02-22 13:09:42 UTC 
Hi Daniel,
I use rhevm-3.6.3-0.1.el6.noarch on my environment.
1) Create vm
2) Add disk to vm
3) create snapshot
4) Add disk to vm
5) create snapshot
6) Preview the first snapshot (step 2) and choose the option to "previewed VM only the disks that are included in the snapshot"
7) Commit
Comment 5 Elad 2016-03-17 08:42:47 UTC 
Commit snapshot gets completed successfully after the following:
1. Create vm + 1 disk
2. Create snapshot from the vm
3. Create second disk + second snapshot containing both disks
4. preview the first snapshot (step 2) and choose the option to "previewed VM only the disks that are included in the snapshot"
5. commit

VM and its attached images get unlocked once commit snapshot is finished.

Used:
rhevm-3.6.4-0.1.el6.noarch
vdsm-4.17.23.1-0.el7ev.noarch
Note You need to log in before you can comment on or make changes to this bug.