Hide Forgot
Spec URL: https://jpopelka.fedorapeople.org/rubygem-github-linguist.spec SRPM URL: https://jpopelka.fedorapeople.org/rubygem-github-linguist-4.7.5-1.fc23.src.rpm Description: Library to detect blob languages, highlight code, ignore binary files, suppress generated files in diffs, and generate language breakdown graphs. Fedora Account System Username: jpopelka
For successful build(s) see https://copr.fedorainfracloud.org/coprs/jpopelka/rubygem-github-linguist/builds/
jpopelka's scratch build of rubygem-github-linguist-4.7.5-1.fc23.src.rpm for f23-candidate completed http://koji.fedoraproject.org/koji/taskinfo?taskID=13093541
Updated %check section Spec URL: https://jpopelka.fedorapeople.org/rubygem-github-linguist.spec SRPM URL: https://jpopelka.fedorapeople.org/rubygem-github-linguist-4.7.5-2.fc23.src.rpm
I'll take this for a review.
As far as I can say, it would be worth of enabling the test suite. With little effort, I was able to achieve this test result: 914 runs, 9700 assertions, 3 failures, 16 errors, 1 skips This gives higher confidence in functionality of linguist then no test suite.
How should I handle the missing dependencies (for tests) ? Do I need to package them or is there other option ?
jpopelka's scratch build of rubygem-github-linguist-4.7.6-2.fc23.src.rpm for f23-candidate completed http://koji.fedoraproject.org/koji/taskinfo?taskID=13202610
Spec URL: https://jpopelka.fedorapeople.org/rubygem-github-linguist.spec SRPM URL: https://jpopelka.fedorapeople.org/rubygem-github-linguist-4.7.6-2.fc23.src.rpm PTAL :-)
First of all, thank you for enabling most parts of the test suite. Great job! A few random notes: * Source1 comments - I would suggest to convert the vim commentary into seds, that would make it more or less executable. And since I am at it, if you moved these into %check section, they would really be executable. Not a blocker however. * The test result grep - You are checking just for failures, but I would suggest to check also for errors, e.g. currently to grep for "3 failures, 14 errors" - The comment could be more to the point, why there are still some failures. - Neither of this is blocker. * Changelog entries - The changelog entries could be more descriptive probably ... * rpmlint - rplint complains about one file: rubygem-github-linguist.noarch: E: script-without-shebang /usr/share/gems/gems/github-linguist-4.7.6/lib/linguist/languages.yml * BR: npm - I don't think that you need the npm dependency. I just tested the build without NPM and it just passes. Since these are just minor nits, I am going to APPROVE the package, but please fix the issues prior import.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rubygem-github-linguist
Thanks Víťo, I've tried to address most of the issues. http://pkgs.fedoraproject.org/cgit/rpms/rubygem-github-linguist.git/tree/rubygem-github-linguist.spec
rubygem-github-linguist-4.7.6-4.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-90c6327748
rubygem-github-linguist-4.7.6-4.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-87ee5141ef
rubygem-github-linguist-4.7.6-4.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-87ee5141ef
rubygem-github-linguist-4.7.6-4.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-90c6327748
rubygem-github-linguist-4.7.6-4.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
rubygem-github-linguist-4.7.6-4.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.