Red Hat Bugzilla – Bug 1310676
available connection not connected after team slave disconnected because master deleted
Last modified: 2017-10-27 08:09:22 EDT
Description of problem:
available ethernet connection is not reconnected after team slave connection disconnected due to removed master connection.
Version-Release number of selected component (if applicable):
Steps to Reproduce:
1.create wired connection for eth0
2.create team and team slave for eth0 connection
3.connect team and slave
4.delete team master connection
ethernet connection should be started
Assigning for now to Lubomir as he was just yesterday looking into activation of team devices.
Created attachment 1331126 [details]
[PATCH] policy: watch active-connection state to detect autoconnect early failures
(In reply to Beniamino Galvani from comment #2)
> Created attachment 1331126 [details]
> [PATCH] policy: watch active-connection state to detect autoconnect early
+ nm_assert (g_hash_table_remove (priv->pending_active_connections, ac));
asserts must have no side-effect.
+pending_ac_gone (gpointer data, GObject *where_the_object_was)
+ g_hash_table_remove (priv->pending_active_connections, where_the_object_was);
+ g_object_unref (self);
pretty sure that weak-ref callbacks are invoked only once. Anyway, to be sure, can you do
(In reply to Thomas Haller from comment #3)
> asserts must have no side-effect.
> pretty sure that weak-ref callbacks are invoked only once. Anyway, to be
> sure, can you do
> if (g_hash_table_remove...
> g_object_unref (self);
Both fixed and applied, thanks.
THe commit broke some CI tests; moving back to POST and attaching follow-up patches, please review.
Created attachment 1332026 [details]
[PATCH 1/2] core: make auto-connect-blocked-reason more specific
Created attachment 1332027 [details]
[PATCH 2/2] core: unblock failed connections when the master is available
patches 1+2 lgtm
(In reply to Thomas Haller from comment #8)
> patches 1+2 lgtm