Bug 1310676
| Summary: | available connection not connected after team slave disconnected because master deleted | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Vladimir Benes <vbenes> |
| Component: | NetworkManager | Assignee: | Beniamino Galvani <bgalvani> |
| Status: | CLOSED ERRATA | QA Contact: | Desktop QE <desktop-qa-list> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | 7.3 | CC: | aloughla, atragler, bgalvani, lrintel, mleitner, rkhan, sukulkar, thaller |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-04-10 13:19:11 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1470965 | ||
| Attachments: | |||
|
Description
Vladimir Benes
2016-02-22 13:45:55 UTC
Assigning for now to Lubomir as he was just yesterday looking into activation of team devices. Created attachment 1331126 [details]
[PATCH] policy: watch active-connection state to detect autoconnect early failures
(In reply to Beniamino Galvani from comment #2) > Created attachment 1331126 [details] > [PATCH] policy: watch active-connection state to detect autoconnect early > failures + nm_assert (g_hash_table_remove (priv->pending_active_connections, ac)); asserts must have no side-effect. if (!g_hash_table_remove...) nm_assert_not_reached() +pending_ac_gone (gpointer data, GObject *where_the_object_was) +{ ... + + g_hash_table_remove (priv->pending_active_connections, where_the_object_was); + g_object_unref (self); +} pretty sure that weak-ref callbacks are invoked only once. Anyway, to be sure, can you do if (g_hash_table_remove... g_object_unref (self); otherwise, lgtm (In reply to Thomas Haller from comment #3) > asserts must have no side-effect. > pretty sure that weak-ref callbacks are invoked only once. Anyway, to be > sure, can you do > > if (g_hash_table_remove... > g_object_unref (self); Both fixed and applied, thanks. https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=a1ea422aadffa808dda780e005969ecadb8c260e THe commit broke some CI tests; moving back to POST and attaching follow-up patches, please review. Created attachment 1332026 [details]
[PATCH 1/2] core: make auto-connect-blocked-reason more specific
Created attachment 1332027 [details]
[PATCH 2/2] core: unblock failed connections when the master is available
patches 1+2 lgtm (In reply to Thomas Haller from comment #8) > patches 1+2 lgtm Applied: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=1ed9e68af04f70c25d0f7ac8ce396e0773f32910 wrong bug :-( Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:0778 |