RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1310676 - available connection not connected after team slave disconnected because master deleted
Summary: available connection not connected after team slave disconnected because mast...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: NetworkManager
Version: 7.3
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: rc
: ---
Assignee: Beniamino Galvani
QA Contact: Desktop QE
URL:
Whiteboard:
Depends On:
Blocks: 1470965
TreeView+ depends on / blocked
 
Reported: 2016-02-22 13:45 UTC by Vladimir Benes
Modified: 2018-04-10 13:21 UTC (History)
8 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-04-10 13:19:11 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
[PATCH] policy: watch active-connection state to detect autoconnect early failures (6.50 KB, patch)
2017-09-26 13:57 UTC, Beniamino Galvani 		no flags Details | Diff
[PATCH 1/2] core: make auto-connect-blocked-reason more specific (4.94 KB, patch)
2017-09-28 15:00 UTC, Beniamino Galvani 		no flags Details | Diff
[PATCH 2/2] core: unblock failed connections when the master is available (3.00 KB, patch)
2017-09-28 15:00 UTC, Beniamino Galvani 		no flags Details | Diff
View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2018:0778 0 None None None 2018-04-10 13:21:22 UTC

Description Vladimir Benes 2016-02-22 13:45:55 UTC 
Description of problem:
available ethernet connection is not reconnected after team slave connection disconnected due to removed master connection.  

Version-Release number of selected component (if applicable):
NetworkManager-1.0.6-27.el7.x86_64

How reproducible:
alwyas

Steps to Reproduce:
1.create wired connection for eth0
2.create team and team slave for eth0 connection
3.connect team and slave
4.delete team master connection

Actual results:
network disconnected

Expected results:
ethernet connection should be started

Additional info:
Comment 1 Thomas Haller 2016-07-05 14:36:59 UTC 
Assigning for now to Lubomir as he was just yesterday looking into activation of team devices.
Comment 2 Beniamino Galvani 2017-09-26 13:57:00 UTC 
Created attachment 1331126 [details]
[PATCH] policy: watch active-connection state to detect autoconnect early failures
Comment 3 Thomas Haller 2017-09-26 18:24:47 UTC 
(In reply to Beniamino Galvani from comment #2)
> Created attachment 1331126 [details]
> [PATCH] policy: watch active-connection state to detect autoconnect early
> failures

+         nm_assert (g_hash_table_remove (priv->pending_active_connections, ac));

asserts must have no side-effect.

 if (!g_hash_table_remove...)
    nm_assert_not_reached()




+pending_ac_gone (gpointer data, GObject *where_the_object_was)
+{
...
+
+    g_hash_table_remove (priv->pending_active_connections, where_the_object_was);
+    g_object_unref (self);
+}


pretty sure that weak-ref callbacks are invoked only once. Anyway, to be sure, can you do

  if (g_hash_table_remove...
      g_object_unref (self);



otherwise, lgtm
Comment 4 Beniamino Galvani 2017-09-27 11:56:06 UTC 
(In reply to Thomas Haller from comment #3)
> asserts must have no side-effect.

> pretty sure that weak-ref callbacks are invoked only once. Anyway, to be
> sure, can you do
> 
>   if (g_hash_table_remove...
>       g_object_unref (self);

Both fixed and applied, thanks.

https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=a1ea422aadffa808dda780e005969ecadb8c260e
Comment 5 Beniamino Galvani 2017-09-28 14:59:29 UTC 
THe commit broke some CI tests; moving back to POST and attaching follow-up patches, please review.
Comment 6 Beniamino Galvani 2017-09-28 15:00:18 UTC 
Created attachment 1332026 [details]
[PATCH 1/2] core: make auto-connect-blocked-reason more specific
Comment 7 Beniamino Galvani 2017-09-28 15:00:42 UTC 
Created attachment 1332027 [details]
[PATCH 2/2] core: unblock failed connections when the master is available
Comment 8 Thomas Haller 2017-09-29 12:48:55 UTC 
patches 1+2 lgtm
Comment 9 Beniamino Galvani 2017-09-29 13:42:35 UTC 
(In reply to Thomas Haller from comment #8)
> patches 1+2 lgtm

Applied:

https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=1ed9e68af04f70c25d0f7ac8ce396e0773f32910
Comment 11 Vladimir Benes 2017-12-08 10:47:28 UTC 
wrong bug :-(
Comment 14 errata-xmlrpc 2018-04-10 13:19:11 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2018:0778
Note You need to log in before you can comment on or make changes to this bug.