Hide Forgot
Description of problem: available ethernet connection is not reconnected after team slave connection disconnected due to removed master connection. Version-Release number of selected component (if applicable): NetworkManager-1.0.6-27.el7.x86_64 How reproducible: alwyas Steps to Reproduce: 1.create wired connection for eth0 2.create team and team slave for eth0 connection 3.connect team and slave 4.delete team master connection Actual results: network disconnected Expected results: ethernet connection should be started Additional info:
Assigning for now to Lubomir as he was just yesterday looking into activation of team devices.
Created attachment 1331126 [details] [PATCH] policy: watch active-connection state to detect autoconnect early failures
(In reply to Beniamino Galvani from comment #2) > Created attachment 1331126 [details] > [PATCH] policy: watch active-connection state to detect autoconnect early > failures + nm_assert (g_hash_table_remove (priv->pending_active_connections, ac)); asserts must have no side-effect. if (!g_hash_table_remove...) nm_assert_not_reached() +pending_ac_gone (gpointer data, GObject *where_the_object_was) +{ ... + + g_hash_table_remove (priv->pending_active_connections, where_the_object_was); + g_object_unref (self); +} pretty sure that weak-ref callbacks are invoked only once. Anyway, to be sure, can you do if (g_hash_table_remove... g_object_unref (self); otherwise, lgtm
(In reply to Thomas Haller from comment #3) > asserts must have no side-effect. > pretty sure that weak-ref callbacks are invoked only once. Anyway, to be > sure, can you do > > if (g_hash_table_remove... > g_object_unref (self); Both fixed and applied, thanks. https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=a1ea422aadffa808dda780e005969ecadb8c260e
THe commit broke some CI tests; moving back to POST and attaching follow-up patches, please review.
Created attachment 1332026 [details] [PATCH 1/2] core: make auto-connect-blocked-reason more specific
Created attachment 1332027 [details] [PATCH 2/2] core: unblock failed connections when the master is available
patches 1+2 lgtm
(In reply to Thomas Haller from comment #8) > patches 1+2 lgtm Applied: https://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=1ed9e68af04f70c25d0f7ac8ce396e0773f32910
wrong bug :-(
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2018:0778