Red Hat Bugzilla – Bug 1310886
Review Request: notary - A server and client for running and interacting with trusted collections
Last modified: 2017-05-09 08:56:10 EDT
Spec URL: http://people.redhat.com/mitr/notary/notary.spec SRPM URL: http://people.redhat.com/mitr/notary/notary-0.1-1.20160219git8a5c8c0.fc24.src.rpm Description: A server and client for running and interacting with trusted collections Fedora Account System Username: mitr
Hi Miloslav, can you create PR on gofed/reviews [1]? There I can comment individual lines of the spec file and others can see golang spec file reviews. Spec file and srpm are sufficient. [1] https://github.com/gofed/reviews Thanks Jan
https://github.com/gofed/reviews/pull/4
mitr's scratch build of notary-0.1-2.20160219git8a5c8c0.fc24.src.rpm for f23-candidate completed http://koji.fedoraproject.org/koji/taskinfo?taskID=13115407
Please stop this madness and follow the Fedora Reviews Process.
(In reply to Haïkel Guémar from comment #4) > Please stop this madness and follow the Fedora Reviews Process. Could you please explain why you think this is madness? I don't see anything in the Fedora Review Process that would qualify this as such.
Haïkel, once the review is done on the github, it will continue here. The github is here for golang specific issues. If you see any violation of the review process, can you be more specific? Thanks
With this [1] I am able to build notary locally. There are 6 packages missing in Fedora [2]. Plus docker distribution has to be update to provide devel subpackage (already fix locally, waiting for 3 packages from [2]). Once all new spec [2] are reviewed and built in Fedora, notary can be built from debundled deps. [1] https://github.com/gofed/reviews/commit/a4050519e547eadd3d54dac9b571f7ef420c45a2 [2] https://bugzilla.redhat.com/buglist.cgi?quicksearch=1314977%201314978%201314979%201315099%201313942%2C%201314213&list_id=4739512
All outdated deps are updated as well
All missing deps are built as well for f23, f24 and rawhide. I am able to build notary from debundled dependencies. Still, not all tests pass [1]. Most likely some of them need special environment or additional dependencies. Locally, all tests pass (f20). What version of Fedora are you running on? Can you check f23 (this is independent of the way of bulding: bundled vs. debundled)? [1] https://kojipkgs.fedoraproject.org//work/tasks/7332/13347332/build.log
This works fine on F22 and F23, breaks only on F24: http://koji.fedoraproject.org/koji/taskinfo?taskID=13352935 http://koji.fedoraproject.org/koji/taskinfo?taskID=13352940 http://koji.fedoraproject.org/koji/taskinfo?taskID=13352933 The tests are ignoring some errors, investigating…
Created attachment 1136612 [details] Update reflection use for go 1.6 Tracked this down to https://golang.org/doc/go1.6#reflect , and the attached patch. Instead of patching this locally we should just update notary to a later checkout, which includes the fix.
The fix is for [1]. I have update the dependency to the latest commit. I am able to build notary in rawhide as well now. Thanks for the investigation. The review can be now finished. [2] commit is still valid. Let's rebase to notary-v0.2 after this is done. The rebase may require update of some dependencies and new packages again. Let's open another bugzilla for that and further analysis or requirements. [1] https://github.com/docker/go/commit/c82d2d98a6942e0004eb0e8bf34b94077c3cc9e3#diff-382fdb4896cb4e5aa5d123d7d8e40afbR1060 [2] https://github.com/gofed/reviews/commit/a4050519e547eadd3d54dac9b571f7ef420c45a2
Any update here?
(In reply to Jan Chaloupka from comment #13) > Any update here? https://github.com/gofed/reviews/pull/4#issuecomment-216554487
Jan, FWIW I don’t plan to work on this package any more. If it is not important to you either, I guess we can close this.
Thanks for letting me know.