Bug 1311052 - cannot add VM from a template as a PowerUser
Summary: cannot add VM from a template as a PowerUser
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.UserPortal
Version: 3.6.3.2
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ovirt-3.6.5
: 3.6.5.3
Assignee: Tomer Saban
QA Contact: Gonza
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-02-23 09:31 UTC by Michal Skrivanek
Modified: 2016-05-05 05:24 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-04-21 14:39:09 UTC
oVirt Team: SLA
Embargoed:
rule-engine: ovirt-3.6.z+
mgoldboi: planning_ack+
rgolan: devel_ack+
pstehlik: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 55346 0 master MERGED core: Added permissions to Power User 2016-03-29 11:48:45 UTC
oVirt gerrit 55406 0 ovirt-engine-3.6 MERGED core: Added permissions to Power User 2016-04-05 07:04:52 UTC
oVirt gerrit 55446 0 ovirt-engine-3.6.5 MERGED core: Added permissions to Power User 2016-04-06 11:24:59 UTC

Description Michal Skrivanek 2016-02-23 09:31:31 UTC
Version: rhevm-3.6.3.2-0.1.el6.noarch

Created a user "user" as a  PowerUser on the Data Center
In Power User Portal tried to create a VM from existing template (template has 1 disk). The disk profile is empty, resulting in:

2015-11-13 22:24:43,816 WARN  [org.ovirt.engine.core.bll.AddVmCommand] (ajp-/127.0.0.1:8702-6) [] CanDoAction of action 'AddVm' failed for user user@internal. Reasons: VAR__ACTION__ADD,VAR__TYPE__VM,USER_NOT_AUTHORIZED_TO_ATTACH_DISK_PROFILE

when tried to create the VM.
In Storage/Disk Profiles the user is listed (not sure why or what it is supposed to mean, as the Administration Guide doesn't explain it).

I was able to make it work by granting DiskProfileUser to DC, then it worked, though the profile (there is only one) was not shown in the dialog

Comment 1 Michal Skrivanek 2016-02-23 15:11:16 UTC
worth noting I had the data domain on local storage

Comment 2 Red Hat Bugzilla Rules Engine 2016-02-24 15:37:06 UTC
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.

Comment 3 Michal Skrivanek 2016-03-14 07:52:16 UTC
restoring flags

Comment 4 Tomer Saban 2016-03-28 13:01:22 UTC
I added a patch that solved this bug. But, unfortunately it revealed a new bug that prevents us from creating a VM from a template with disk.

virt team is working on it.

The problem that Power User doesn't have the necessary permissions to create a VM from a template with disk is solved by this patch.

Comment 5 Gonza 2016-04-13 09:03:59 UTC
Isn't this a duplicate of bz1209505?

If that is the case, we should be adding 'Attach Disk Profile' permission to all roles.

Comment 6 Gonza 2016-04-14 15:03:23 UTC
Verified with:
rhevm-3.6.5.3-0.1.el6.noarch

2016-04-14 17:00:17,144 INFO  [org.ovirt.engine.core.bll.AddVmCommand] (ajp-/127.0.0.1:8702-9) [5f76c910] Lock Acquired to object 'EngineLock:{exclusiveLocks='[vm_from_template1=<VM_NAME, ACTION_TYPE_FAILED_OBJECT_LOCKED>]', sharedLocks='[e0556af5-ccea-4e0a-b4cc-5c429863622e=<TEMPLATE, ACTION_TYPE_FAILED_TEMPLATE_IS_USED_FOR_CREATE_VM$VmName vm_from_template1>, fa684148-ee6b-4407-9ee7-75e770da8d03=<DISK, ACTION_TYPE_FAILED_DISK_IS_USED_FOR_CREATE_VM$VmName vm_from_template1>]'}'
2016-04-14 17:00:19,999 INFO  [org.ovirt.engine.core.bll.AddVmCommand] (ajp-/127.0.0.1:8702-9) [5f76c910] Running command: AddVmCommand internal: false. Entities affected :  ID: 00000002-0002-0002-0002-00000000024a Type: VdsGroupsAction group CREATE_VM with role type USER,  ID: e0556af5-ccea-4e0a-b4cc-5c429863622e Type: VmTemplateAction group CREATE_VM with role type USER,  ID: 9334a0df-51f6-48fb-90eb-5c67e742b0e4 Type: StorageAction group CREATE_DISK with role type USER
...
2016-04-14 17:00:37,195 INFO  [org.ovirt.engine.core.bll.AddVmCommand] (DefaultQuartzScheduler_Worker-47) [] Lock freed to object 'EngineLock:{exclusiveLocks='[vm_from_template1=<VM_NAME, ACTION_TYPE_FAILED_OBJECT_LOCKED>]', sharedLocks='[e0556af5-ccea-4e0a-b4cc-5c429863622e=<TEMPLATE, ACTION_TYPE_FAILED_TEMPLATE_IS_USED_FOR_CREATE_VM$VmName vm_from_template1>, fa684148-ee6b-4407-9ee7-75e770da8d03=<DISK, ACTION_TYPE_FAILED_DISK_IS_USED_FOR_CREATE_VM$VmName vm_from_template1>]'}'
2016-04-14 17:00:37,331 INFO  [org.ovirt.engine.core.dal.dbbroker.auditloghandling.AuditLogDirector] (DefaultQuartzScheduler_Worker-47) [] Correlation ID: 5f76c910, Job ID: 8473bf5a-7933-40e1-b63f-081d4534440c, Call Stack: null, Custom Event ID: -1, Message: VM vm_from_template1 creation has been completed.

Comment 7 Tomer Saban 2016-04-19 12:55:05 UTC
It's not a duplicate since this happens also when no storage domain is created. Power user should be able to 'create vm from existing template' and for that he/she needs permissions to 'attach disk profile'. This patch should be part of the code base.


Note You need to log in before you can comment on or make changes to this bug.