Bug 1311907 - curl loops when storing cookies
Summary: curl loops when storing cookies
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: curl
Version: 23
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kamil Dudka
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-02-25 10:02 UTC by Jan Pazdziora
Modified: 2016-02-28 12:19 UTC (History)
2 users (show)

Fixed In Version: curl-7.43.0-6.fc23
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-02-28 12:19:45 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Jan Pazdziora 2016-02-25 10:02:55 UTC
Description of problem:

I have tests that do

curl -b /tmp/headers.$$ -c /tmp/cookies.$$ -Lksi https://$( hostname )$LOGIN_URL

I see them fail due to curl going into 100% CPU infinite loop.

Version-Release number of selected component (if applicable):

curl-7.43.0-5.fc23.x86_64

How reproducible:

Deterministic but part of large test.

Steps to Reproduce:
1. Look at lib/cookie.c code, function cookie_output.

Actual results:

    while(co) {
      if(!co->domain)
        continue;

Expected results:

Something which has lower potential of going into infinite loop.

Additional info:

I believe ef0fdb83b89c87b63e94bf6ecdab5cd8c6458b2e addresses the problem. Please consider backporting it to Fedora 23.

Comment 1 Kamil Dudka 2016-02-25 10:25:29 UTC
Thank you for reporting the bug!  I have included the upstream fix in f23:

http://pkgs.fedoraproject.org/cgit/rpms/curl.git/commit/?id=0c9fbb7e

Comment 2 Fedora Update System 2016-02-25 11:54:59 UTC
curl-7.43.0-6.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-c652a79610

Comment 3 Fedora Update System 2016-02-26 20:53:07 UTC
curl-7.43.0-6.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c652a79610

Comment 4 Fedora Update System 2016-02-28 12:19:41 UTC
curl-7.43.0-6.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.