Red Hat Bugzilla – Bug 1312185
[GSS](JDG 6.x) Double invalidate of invalid Hot Rod connections
Last modified: 2018-01-29 11:08:05 EST
When there's a problem with a Hot Rod operation, RetryOnFailureOperation invalidates the connection twice (once in a catch block, and once in a finally block). This causes the GenericKeyedObjectPool counts to get off, and anything relying on that count (such as the maxTotal configuration for the pool) to break.
org.infinispan.client.hotrod.impl.operations.RetryOnFailureOperation public T execute() { ... try { transport = getTransport(retryCount, failedServers); return executeOperation(transport); } catch (TransportException te) { ... if (transport != null) transportFactory.invalidateTransport(te.getServerAddress(), transport); ... } finally { releaseTransport(transport); } ... protected void releaseTransport(Transport transport) { if (transport != null) transportFactory.releaseTransport(transport); } org.infinispan.client.hotrod.impl.transport.tcp.TcpTransportFactory: public void invalidateTransport(SocketAddress serverAddress, Transport transport) { ... pool.invalidateObject(serverAddress, (TcpTransport) transport); public void releaseTransport(Transport transport) { TcpTransport tcpTransport = (TcpTransport) transport; if (!tcpTransport.isValid()) { ... pool.invalidateObject(tcpTransport.getServerAddress(), tcpTransport);
the impact of this issue for this customer is that more sockets then expected are getting created and using more memory , which results in server stability issues
Galder Zamarreño <galder.zamarreno@redhat.com> updated the status of jira ISPN-6275 to Coding In Progress
Sebastian Łaskawiec <slaskawi@redhat.com> updated the status of jira ISPN-6275 to Closed
Galder Zamarreño <galder.zamarreno@redhat.com> updated the status of jira JDG-82 to Resolved