Hide Forgot
Upstream, this software supports Python 3. Please provide a Python 3 package for Fedora. According to the Python packaging guidelines [0], software must be packaged for Python 3 if upstream supports it. The guidelines give detailed information on how to do this, and even provide an example spec file [1]. The current best practice is to provide subpackages for the two Python versions (called "Common SRPM" in the guidelines). Alternatively, if nothing depends on your Python2 package, you can just switch to Python 3 entirely. It's ok to do this in Rawhide only, however, it would be greatly appreciated if you could push it to Fedora 24 as well. If anything is unclear, or if you need any kind of assistance with the porting, you can ask on IRC (#fedora-python on Freenode), or reply here. We'll be happy to help! [0] https://fedoraproject.org/wiki/Packaging:Python [1] https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file
Hi Eduardo, Do you need any help adding Python 3 support to the RPM? If you need more instructions, a [guide] for porting Python-based RPMs is available. [guide] http://python-rpm-porting.readthedocs.org/en/latest/index.html
This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle. Changing version to '25'.
Created attachment 1192204 [details] Update to 5.8.9 version including Python 3 subpackage The patch includes - update to version 5.8.9 - source update - modernized specfile with Python 3 packaging
Hi Jan! The patch looks good, only has one minor fault: The names of the subpackages. The package name in Fedora is "python-django-select2", so we want the two subpackages to be named "python2-django-select2" and "python3-django-select2". However, since you used the macro %{pkgname} in naming of the subpackages, you'll actually get subpackages named "python2-Django-Select2" and "python3-Django-Select2"—notice the capitalization. (Sub)package names are case sensitive, so this isn't good. The macro %{pkgname} is there only for identifying the sources in upstream, as upstream uses the capitalisation. For Fedora subpackages we want the name in lower case, so I suggest creating a second macro %{srcname} and using that to name the subpackages.
Created attachment 1192257 [details] Updated spec file Hi Tomáš, thank you for the review. I made the corrections, and attach the updated spec file.
Hi Jan, Looks good to me!
Hi Eduardo, as this is a bit of a time sensitive issue, we would really appreciate if you could take a look at the patch as soon as possible. If you are time constrained right now, I hope you won't mind if we do the review and push the changes ourselves in case you are unable. Thank you!
Here's a scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=15348391 P.S.: Before pushing, one needs to do a fedpkg new-sources.