Bug 1313470 - advertise e1000 supported for windows
Summary: advertise e1000 supported for windows
Keywords:
Status: CLOSED UPSTREAM
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libosinfo
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Fabiano Fidêncio
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-03-01 16:22 UTC by Agostino Sarubbo
Modified: 2018-10-01 06:57 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2018-10-01 06:57:45 UTC
Embargoed:


Attachments (Terms of Use)

Description Agostino Sarubbo 2016-03-01 16:22:58 UTC
I did an installation of a WINDOWS 7 guest. If I don't specify anything it picks rtl8139 as default.

Since I need a gigabit card I need to specify model=e1000.


So I guess virt-install should pick e1000 instead of rtl3189 by default.


on this system I have:
horizon ~ # qemu-system-x86_64 -net nic,model=?
qemu: Supported NIC models: ne2k_pci,i82551,i82557b,i82559er,rtl8139,e1000,pcnet,virtio


horizon ~ # virt-install --version
1.3.2

Comment 1 Daniel Berrangé 2016-03-01 16:26:14 UTC
Looking at the libosinfo database, it appears that the windows XML data files are configured on the assumption that the application will be installing the windows virtio driver add-ons.

This may be desirable, but we shouldn't assume that, so I think libosinfo database probably ought to *also* list e1000 as a valid NIC for windows, so that e1000 gets used in cases where virtio drivers are not installed by the virt-manager

Comment 3 Fabiano Fidêncio 2018-10-01 06:57:45 UTC
master:
 9de37b18e826636d24c8f4641e53dfcf07163d30


Note You need to log in before you can comment on or make changes to this bug.