Bug 131413 - fstab-sync should not create new fstab file in /tmp
Summary: fstab-sync should not create new fstab file in /tmp
Keywords:
Status: CLOSED DUPLICATE of bug 131187
Alias: None
Product: Fedora
Classification: Fedora
Component: hal
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: David Zeuthen
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: FC3Blocker
TreeView+ depends on / blocked
 
Reported: 2004-09-01 03:49 UTC by Russell Coker
Modified: 2013-03-06 03:41 UTC (History)
1 user (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2006-02-21 19:05:24 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Russell Coker 2004-09-01 03:49:02 UTC
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (compatible; Konqueror/3.3; Linux) (KHTML, like Gecko)

Description of problem:
fstab-sync creates a new file under /tmp.  This causes at least two problems.

One problem is that if /tmp and /etc are not on the same file system then the process of moving the temporary file to /etc has race conditions that could potentially leave a machine unbootable if a power failure occurs at the wrong time.

Another problem is that in SE Linux a file created in /tmp gets the type tmp_t by default.  If /etc/fstab gets this type then it can't be used by most programs (the system may fail to boot).


Version-Release number of selected component (if applicable):


How reproducible:
Always

Steps to Reproduce:
boot machine

Additional info:

The solution is to use a temporary file name /etc/fstab.new or similar.

Comment 1 David Zeuthen 2004-09-01 10:05:43 UTC
This have been addressed in bug #131187; the fix is in Rawhide
(hal-0.2.97.cvs20040901-1). I have some concerns on how to properly
update files atomically if relabeling is required; expressed here:

 https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=131187#c9.

comments, suggestions are welcome.

Thanks.

*** This bug has been marked as a duplicate of 131187 ***

Comment 2 Red Hat Bugzilla 2006-02-21 19:05:24 UTC
Changed to 'CLOSED' state since 'RESOLVED' has been deprecated.


Note You need to log in before you can comment on or make changes to this bug.