Bug 1314529 - python2-bashate - requires both python2 and python3
Summary: python2-bashate - requires both python2 and python3
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-bashate
Version: 24
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: hguemar
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3
TreeView+ depends on / blocked
 
Reported: 2016-03-03 20:32 UTC by William Moreno
Modified: 2016-06-26 01:45 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-06-26 01:45:43 UTC


Attachments (Terms of Use)

Description William Moreno 2016-03-03 20:32:23 UTC
Hi, there is a issue with the spec:

%install
%py2_install

%if 0%{with_python3}
%py3_install
%endif

And then in both packages:
%{_bindir}/%{pypi_name}

This mean you are including in the python2 subpackage a executable than requires the python3 version of this package, you must update your spec to something like:

%install
%py2_install
mv %buildroot/%{_bindir}/%{pypi_name} %buildroot/%{_bindir}/%{pypi_name}-py2

and then in the python2 subpackage
%{_bindir}/%{pypi_name}-py2

See:
https://fedoraproject.org/wiki/Packaging:Python#Avoiding_collisions_between_the_python_2_and_python_3_stacks

Comment 1 Petr Viktorin 2016-03-04 09:53:37 UTC
Actually, the guidelines specify how the scripts should be named, so that users can use a sane "default" but also explicitly request a specific version:
https://fedoraproject.org/wiki/Packaging:Python#Naming

There are two cases:
1) If the script works the same under both python2 and python3, only the python3 scripts can be packaged

2) Otherwise, there should be /usr/bin/script, /usr/bin/script-2, /usr/bin/script-2.7 for Python 2, and /usr/bin/script-3, /usr/bin/script-3.5 for Python 3.
You can do that like this:

%py3_install
mv %{buildroot}/%{_bindir}/%{pypi_name} %{buildroot}/%{_bindir}/%{pypi_name}-3 
ln -s %{buildroot}/%{_bindir}/%{pypi_name}-3 %{buildroot}/%{_bindir}/%{pypi_name}-%{python3_version}

%py2_install
ln -s %{buildroot}/%{_bindir}/%{pypi_name} %{buildroot}/%{_bindir}/%{pypi_name}-%2
ln -s %{buildroot}/%{_bindir}/%{pypi_name} %{buildroot}/%{_bindir}/%{pypi_name}-%{python2_version}

Comment 2 hguemar 2016-06-25 22:48:22 UTC
Reassigning to myself as provenpackager.

Comment 3 hguemar 2016-06-26 01:45:43 UTC
Updated to 0.5.1, I fixed the symlinks, now default binary is python3 version.


Note You need to log in before you can comment on or make changes to this bug.