Bug 1314992 - playonlinux not built with $RPM_OPT_FLAGS
Summary: playonlinux not built with $RPM_OPT_FLAGS
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: playonlinux
Version: rawhide
Hardware: All
OS: All
unspecified
unspecified
Target Milestone: ---
Assignee: Jiri Konecny
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: DebugInfo
TreeView+ depends on / blocked
 
Reported: 2016-03-05 13:40 UTC by Ville Skyttä
Modified: 2016-03-20 02:30 UTC (History)
2 users (show)

Fixed In Version: playonlinux-4.2.10-7.fc23
Clone Of:
Environment:
Last Closed: 2016-03-20 02:30:09 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
Build with $RPM_OPT_FLAGS (1.20 KB, patch)
2016-03-05 13:40 UTC, Ville Skyttä
no flags Details | Diff

Description Ville Skyttä 2016-03-05 13:40:53 UTC
'git am'able fix attached.

Comment 1 Ville Skyttä 2016-03-05 13:40:56 UTC
Created attachment 1133317 [details]
Build with $RPM_OPT_FLAGS

Comment 2 Zbigniew Jędrzejewski-Szmek 2016-03-05 14:24:58 UTC
Shouldn't this be part of %make_build?

Comment 3 Ville Skyttä 2016-03-05 14:29:36 UTC
No. Build systems are quite sensitive and different on how to override compiler flags. Some need them as env vars such as in this case, some need them specified as arguments to make, and the variable names differ etc.

Comment 4 Zbigniew Jędrzejewski-Szmek 2016-03-05 15:22:36 UTC
OK.

Comment 5 Jiri Konecny 2016-03-07 07:26:48 UTC
Thank you for the patch. I'll apply it soon.

Comment 6 Fedora Update System 2016-03-07 08:49:41 UTC
playonlinux-4.2.10-6.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-770d520ac2

Comment 7 Fedora Update System 2016-03-09 22:57:38 UTC
playonlinux-4.2.10-6.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-770d520ac2

Comment 8 Fedora Update System 2016-03-20 02:30:07 UTC
playonlinux-4.2.10-7.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.