Bug 1315047 - Incorrect ExecStop= directive in ejabberd.service
Summary: Incorrect ExecStop= directive in ejabberd.service
Keywords:
Status: CLOSED EOL
Alias: None
Product: Fedora
Classification: Fedora
Component: ejabberd
Version: 22
Hardware: All
OS: Linux
unspecified
unspecified
Target Milestone: ---
Assignee: Peter Lemenkov
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1314753
Blocks: 1315046
TreeView+ depends on / blocked
 
Reported: 2016-03-06 06:49 UTC by Randy Barlow
Modified: 2016-06-06 13:56 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of: 1314753
Environment:
Last Closed: 2016-06-06 13:56:39 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Randy Barlow 2016-03-06 06:49:30 UTC
+++ This bug was initially created as a clone of Bug #1314753 +++

Description of problem:
Incorrect ExecStop= directive in ejabberd.service resulting in unit stop failing.
The correct directive is:
ExecStop=/usr/bin/bash /usr/bin/ejabberdctl stop

Version-Release number of selected component (if applicable):
ejabberd-14.07-6.fc22.x86_64

How reproducible:
Always.

Steps to Reproduce:
1. systemctl stop ejabberd.service
2. systemctl status ejabberd.service

Actual results:
systemd[1]: Stopping A distributed, fault-tolerant Jabber/XMPP server...
ejabberdctl[3067]: Refusing to render service to dead parents.
systemd[1]: ejabberd.service: Control process exited, code=exited status=127
systemd[1]: Stopped A distributed, fault-tolerant Jabber/XMPP server.
systemd[1]: ejabberd.service: Unit entered failed state.
systemd[1]: ejabberd.service: Failed with result 'exit-code'.

Expected results:
# grep ExecStop= /usr/lib/systemd/system/ejabberd.service 
ExecStop=/usr/bin/bash /usr/bin/ejabberdctl stop

--- Additional comment from Randy Barlow on 2016-03-06 01:48:08 EST ---

This is easy to fix in Fedora 24, but unfortunately the SRPM does not build anymore on F22 or F23 with this build error:

Compiling /builddir/build/BUILD/ejabberd-14.07/deps/jiffy/c_src/double-conversion/bignum.cc
/builddir/build/BUILD/ejabberd-14.07/deps/jiffy/c_src/double-conversion/bignum.cc: In member function 'void double_conversion::Bignum::AssignDecimalString(double_conversion::Vector<const char>)':
/builddir/build/BUILD/ejabberd-14.07/deps/jiffy/c_src/double-conversion/bignum.cc:101:6: error: assuming signed overflow does not occur when assuming that (X + c) < X is always false [-Werror=strict-overflow]
 void Bignum::AssignDecimalString(Vector<const char> value) {
      ^
cc1plus: all warnings being treated as errors

I will have an F24 fix out shortly, but I don't have time to investigate these build failures this weekend.

Comment 1 Peter Lemenkov 2016-06-06 13:56:39 UTC
I don't think we're going to fix anything in F22. If anyone is affected by this change then please upgrade at least to Fedora 24 which is very much supported.


Note You need to log in before you can comment on or make changes to this bug.