Hide Forgot
Description of problem: JSON output of atomic scan contains string "Scanning..." before the actual JSON starts, which is invalid JSON syntax. Version-Release number of selected component (if applicable): atomic-1.6-6.gitca1e384.el7.x86_64 How reproducible: always Steps to Reproduce: 1. atomic scan <ID> --json Actual results: JSON is preceded by "\nScanning...\n" Expected results: Only JSON on stdout. Additional info: I have found that the issue has been fixed upstream in https://github.com/projectatomic/atomic/commit/7ce96abdda930d9716e48479cb3c0cd080fe263b
(In reply to Jan Černý from comment #0) > Additional info: > I have found that the issue has been fixed upstream in > https://github.com/projectatomic/atomic/commit/ > 7ce96abdda930d9716e48479cb3c0cd080fe263b Yes, the patch has been backported to v1.6. [root@dell-per630-02 atomic]# git tag --contains 7ce96ab v1.6 v1.8 [root@dell-per630-02 atomic]# git branch * (detached from v1.6) jzb-patch-1 master [root@dell-per630-02 atomic]# git show 7ce96ab commit 7ce96abdda930d9716e48479cb3c0cd080fe263b Author: Dan Walsh <dwalsh> Date: Mon Nov 23 08:22:35 2015 -0500 Don't output Scanning, user knows that diff --git a/Atomic/atomic.py b/Atomic/atomic.py index 85312bb..a668037 100644 --- a/Atomic/atomic.py +++ b/Atomic/atomic.py @@ -472,7 +472,6 @@ class Atomic(object): "use) and therefore cannot be scanned.\n" .format(docker_obj)) sys.exit(1) - util.writeOut("\nScanning...\n") bus = dbus.SystemBus() try: oscap_d = bus.get_object(BUS_NAME, OBJECT_PATH)
(In reply to Alex Jia from comment #2) > Yes, the patch has been backported to v1.6. s/backported/cherry-pick/
Fixed in atomic-1.10
Brent please comment on this.
The --json switch was removed in the following commit -> https://github.com/projectatomic/atomic/commit/6ed4994b0d6091ccfe171b9c8e48714c53a868d6 For the record, with the re-design of the scanner at that time, atomic no longer forms the JSON output that is stored in the filesystem. This is always done by the scanners themselves.
(In reply to Brent Baude from comment #8) > The --json switch was removed in the following commit -> > > https://github.com/projectatomic/atomic/commit/ > 6ed4994b0d6091ccfe171b9c8e48714c53a868d6 > > For the record, with the re-design of the scanner at that time, atomic no > longer forms the JSON output that is stored in the filesystem. This is > always done by the scanners themselves. Brent, okay, because the --json switch has been removed, and I can't give a further testing due to bug 1343944 and 1343939, so I tend to close the bug.
Brent, can we remove this bug from the advisory?
I dont see why not. Do others object?
Not really, just wanted to make sure :)
Just a record, atomic scan will put test report in *.xml and json format under the /var/lib/atomic/openscap/$date/$image_id/, I used python -m json.tool to check /var/lib/atomic/openscap/$date/$image_id/json, it's valid json format, so I tend to close the bug as VERIFIED.