Bug 1315657 - No auto-completion option for scheduling policy name in update cluster
Summary: No auto-completion option for scheduling policy name in update cluster
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine-sdk-python
Classification: oVirt
Component: Core
Version: 3.6.8.0
Hardware: Unspecified
OS: Unspecified
low
medium
Target Milestone: ovirt-4.0.4
: 3.6.9.1
Assignee: Juan Hernández
QA Contact: Artyom
URL:
Whiteboard:
Depends On:
Blocks: 1361556
TreeView+ depends on / blocked
 
Reported: 2016-03-08 11:12 UTC by Nelly Credi
Modified: 2016-09-26 12:33 UTC (History)
9 users (show)

Fixed In Version: 3.6.9.1
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1361556 (view as bug list)
Environment:
Last Closed: 2016-09-26 12:33:28 UTC
oVirt Team: SLA
Embargoed:
rule-engine: ovirt-4.0.z+
mgoldboi: planning_ack+
dfediuck: devel_ack+
mavital: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 54962 0 master MERGED restapi: schema: Allow to pass scheduling policy name for Update Cluster 2016-03-28 12:46:05 UTC
oVirt gerrit 55353 0 ovirt-engine-3.6 MERGED restapi: schema: Allow to pass scheduling policy name for Update Cluster 2016-03-28 17:30:38 UTC
oVirt gerrit 58490 0 master MERGED restapi: Allow passing of scheduling policy name for Update Cluster 2016-07-06 10:31:23 UTC
oVirt gerrit 58788 0 ovirt-engine-3.6 MERGED restapi: Allow passing of scheduling policy name for Update Cluster 2016-08-08 09:55:34 UTC
oVirt gerrit 60218 0 ovirt-engine-4.0 MERGED restapi: Allow passing of scheduling policy name for Update Cluster 2016-07-28 06:47:22 UTC

Description Nelly Credi 2016-03-08 11:12:40 UTC
Description of problem:
There is no 'name' attribute under scheduling policy object, when trying to update cluster, only scheduling-policy-policy, which is not compatible with other APIs

Version-Release number of selected component (if applicable):


How reproducible:
100%

Steps to Reproduce:
1.add cluster
2.update cluster's scheduling policy
3.

Actual results:
scheduling-policy-policy exists, but incompatible with other APIs 

Expected results:
scheduling-policy-name should exist

Additional info:

Comment 1 Juan Hernández 2016-03-08 11:16:44 UTC
This needs to be fixed in the rsdl_metadata.yaml file, then the Python SDK will need to be regenerated. The CLI won't need any change.

Comment 2 Nelly Credi 2016-04-03 12:42:01 UTC
I still dont see this option in CLI:

[RHEVM shell (connected)]# update cluster scheduling_policy-
scheduling_policy-id                   scheduling_policy-properties-property  scheduling_policy-thresholds-high
scheduling_policy-policy               scheduling_policy-thresholds-duration  scheduling_policy-thresholds-low


rhevm-3.6.5-0.1.el6.noarch
rhevm-sdk-java-3.6.5.0-1.el6ev.noarch
rhevm-sdk-python-3.6.5.0-1.el6ev.noarch
rhevm-cli-3.6.2.0-1.el6ev.noarch

Juan, should it work with this CLI version?

Comment 3 Roy Golan 2016-04-03 14:37:35 UTC
(In reply to Nelly Credi from comment #2)
> I still dont see this option in CLI:
> 
> [RHEVM shell (connected)]# update cluster scheduling_policy-
> scheduling_policy-id                   scheduling_policy-properties-property
> scheduling_policy-thresholds-high
> scheduling_policy-policy               scheduling_policy-thresholds-duration
> scheduling_policy-thresholds-low
> 
> 
> rhevm-3.6.5-0.1.el6.noarch
> rhevm-sdk-java-3.6.5.0-1.el6ev.noarch
> rhevm-sdk-python-3.6.5.0-1.el6ev.noarch
> rhevm-cli-3.6.2.0-1.el6ev.noarch
> 
> Juan, should it work with this CLI version?

Nelly the fix wasn't no backported to ovirt-engine-3.6.5 and the automation moved the bug to MODIFY after the patch was merged to ovirt-engine-3.6.

Comment 4 Red Hat Bugzilla Rules Engine 2016-04-03 14:37:39 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 6 Nelly Credi 2016-04-04 13:58:57 UTC
your fix is for:
/datacenter/{datacenter:id}/clusters/{cluster:id}
while I asked for 
/clusters/{cluster:id}

Comment 7 Nelly Credi 2016-04-04 13:59:23 UTC
reopening see comment 6

Comment 8 Red Hat Bugzilla Rules Engine 2016-04-04 13:59:27 UTC
Target release should be placed once a package build is known to fix a issue. Since this bug is not modified, the target version has been reset. Please use target milestone to plan a fix for a oVirt release.

Comment 9 Sandro Bonazzola 2016-07-29 11:20:05 UTC
3.6 is gone EOL; Please re-target this bug to a 4.0 release.

Comment 10 Phillip Bailey 2016-08-08 12:08:48 UTC
Bug closed as next release.

Comment 11 Roy Golan 2016-08-09 12:26:13 UTC
I mixed this one with the cloned. moving to on_qa

Comment 12 Artyom 2016-08-11 14:59:12 UTC
Checked on rhevm-4.0.2.6-0.1.el7ev.noarch

[oVirt shell (connected)]# update cluster scheduling_policy-
scheduling_policy-id                   scheduling_policy-properties-property  scheduling_policy-thresholds-high
scheduling_policy-policy               scheduling_policy-thresholds-duration  scheduling_policy-thresholds-low


I can not see cherry-pick to 4.0 of patch "restapi: schema: Allow to pass scheduling policy name for Update Cluster	"

Comment 13 Phillip Bailey 2016-08-17 12:50:50 UTC
(In reply to Artyom from comment #12)
> Checked on rhevm-4.0.2.6-0.1.el7ev.noarch
> 
> [oVirt shell (connected)]# update cluster scheduling_policy-
> scheduling_policy-id                   scheduling_policy-properties-property
> scheduling_policy-thresholds-high
> scheduling_policy-policy               scheduling_policy-thresholds-duration
> scheduling_policy-thresholds-low
> 
> 
> I can not see cherry-pick to 4.0 of patch "restapi: schema: Allow to pass
> scheduling policy name for Update Cluster	"

I apologize for the confusion. That patch doesn't need to be cherry-picked, as it didn't correct the problem, per Comment 6.

Patch 60218 is the one that corrects the problem, and was merged to 4.0 on July 28th. 

Moving back to ON_QA

Comment 14 Phillip Bailey 2016-08-17 12:59:10 UTC
Moving to MODIFIED as target milestone is now 4.0.6.

Comment 15 Artyom 2016-09-18 12:03:26 UTC
Checked on ovirt-engine-restapi-4.0.4.2-0.1.el7ev.noarch
Still, can not see auto-completion options for scheduling_policy-name

[oVirt shell (connected)]# update cluster scheduling_policy-
scheduling_policy-id                   scheduling_policy-properties-property  scheduling_policy-thresholds-high
scheduling_policy-policy               scheduling_policy-thresholds-duration  scheduling_policy-thresholds-low

Comment 16 Roy Golan 2016-09-19 10:22:16 UTC
https://gerrit.ovirt.org/#/c/60218/2/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml

Juan do you know why even thought we have this fix Artyom still see's comment 15?

Comment 17 Juan Hernández 2016-09-19 10:47:38 UTC
The reason is that this fix requires version 3.6.9.0 of the Python SDK, and oVirt 4.0.4 doesn't include that version. I'm requesting that the fixed version is added to the RC4:

  releases: 4.0.4_rc4: Add version 3.6.9.1 of Python SDK
  https://gerrit.ovirt.org/64122

Comment 18 Artyom 2016-09-21 09:57:28 UTC
Verified on rhevm-restapi-3.6.9.2-0.1.el6.noarch

# update cluster scheduling_policy-
scheduling_policy-id                   scheduling_policy-properties-property  scheduling_policy-thresholds-low
scheduling_policy-name                 scheduling_policy-thresholds-duration  
scheduling_policy-policy               scheduling_policy-thresholds-high


Note You need to log in before you can comment on or make changes to this bug.