Spec URL: https://raw.githubusercontent.com/remicollet/remirepo/47b64f8f7d7705ac2b3ea53767f0dee5631b97be/php/sabredav/php-sabre-xml/php-sabre-xml.spec SRPM URL: http://rpms.famillecollet.com/SRPMS/php-sabre-xml-1.4.0-1.remi.src.rpm Description: The sabre/xml library is a specialized XML reader and writer. Autoloader: /usr/share/php/Sabre/Xml/autoload.php Fedora Account System Username: remi
Fix Changelog https://github.com/remicollet/remirepo/commit/1044e8ae349a524b20a64c7ff3ba366b416d7e9a Spec: https://raw.githubusercontent.com/remicollet/remirepo/b80232f6c76e1a499d6eaa7d5f7cde0e61ceb028/php/sabredav/php-sabre-xml/php-sabre-xml.spec Srpm: http://rpms.famillecollet.com/SRPMS/php-sabre-xml-1.4.0-1.remi.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ===== * Required due to not requiring a parent package that includes this, compatible with others * EPEL5 stuff to be stripped after initial import. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "BSD (3 clause)", "Unknown or generated". 40 files have unknown license. Detailed output of licensecheck in /home/james/workspace /fedora-scm/1316912-php-sabre-xml/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [!]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [!]: Each %files section contains %defattr if rpm < 4.4 Note: %defattr present but not needed [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Buildroot is not present Note: Buildroot: present but not needed [!]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: %clean present but not required [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. PHP: [x]: Run phpci static analyze on all php files. Note: phpCompatInfo version 5.0.0 DB built Mar 07 2016 07:28:32 CET static analyze results in /home/james/workspace/fedora-scm/1316912 -php-sabre-xml/phpci.log Rpmlint ------- Checking: php-sabre-xml-1.4.0-1.fc25.noarch.rpm php-sabre-xml-1.4.0-1.fc25.src.rpm php-sabre-xml.noarch: W: spelling-error %description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader php-sabre-xml.noarch: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology php-sabre-xml.src: W: spelling-error %description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader php-sabre-xml.src: W: spelling-error %description -l en_US usr -> use, us, user php-sabre-xml.src: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology 2 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory php-sabre-xml.noarch: W: spelling-error %description -l en_US Autoloader -> Auto loader, Auto-loader, Freeloader php-sabre-xml.noarch: W: spelling-error %description -l en_US autoload -> auto load, auto-load, tautology 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Requires -------- php-sabre-xml (rpmlib, GLIBC filtered): php(language) php-composer(sabre/uri) php-composer(symfony/class-loader) php-dom php-pcre php-spl php-xmlreader php-xmlwriter Provides -------- php-sabre-xml: php-composer(sabre/xml) php-sabre-xml Source checksums ---------------- https://github.com/fruux/sabre-xml/archive/fb07d78e232ec37f5760f579e15694d150ff0da6/sabre-xml-1.4.0-fb07d78.tar.gz : CHECKSUM(SHA256) this package : 3d377e91e997114c0d2276d9c863ff2f318bac6c0403eea7ee76c2d169cfb185 CHECKSUM(SHA256) upstream package : 3d377e91e997114c0d2276d9c863ff2f318bac6c0403eea7ee76c2d169cfb185 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1316912 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, PHP, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, Ruby Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6 ==== Result ==== APPROVED (with the EPEL5 boilerplate removed after import)
Thanks for the review. SCM request open.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-sabre-xml
php-sabre-xml-1.4.0-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9c67ca3a23
php-sabre-xml-1.4.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-7aa02e38bb
php-sabre-xml-1.4.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a0c414b049
php-sabre-xml-1.4.0-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-c8e6c54297
php-sabre-xml-1.4.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-7aa02e38bb
php-sabre-xml-1.4.0-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c8e6c54297
php-sabre-xml-1.4.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a0c414b049
php-sabre-xml-1.4.0-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9c67ca3a23
php-sabre-xml-1.4.1-1.el7 has been submitted as an update to Fedora EPEL 7. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9c67ca3a23
php-sabre-xml-1.4.1-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-a0c414b049
php-sabre-xml-1.4.1-1.fc22 has been submitted as an update to Fedora 22. https://bodhi.fedoraproject.org/updates/FEDORA-2016-c8e6c54297
php-sabre-xml-1.4.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
php-sabre-xml-1.4.1-1.el7 has been pushed to the Fedora EPEL 7 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2016-9c67ca3a23
php-sabre-xml-1.4.1-1.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-c8e6c54297
php-sabre-xml-1.4.1-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-a0c414b049
php-sabre-xml-1.4.1-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
php-sabre-xml-1.4.1-1.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.
php-sabre-xml-1.4.1-1.el7 has been pushed to the Fedora EPEL 7 stable repository. If problems still persist, please make note of it in this bug report.