Bug 1317083 - No IPv6 support
No IPv6 support
Status: NEW
Product: Fedora
Classification: Fedora
Component: nsca (Show other bugs)
25
Unspecified Linux
unspecified Severity medium
: ---
: ---
Assigned To: Xavier Bachelot
Fedora Extras Quality Assurance
: Reopened
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2016-03-11 17:49 EST by Stuart D Gathman
Modified: 2017-07-08 23:51 EDT (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2016-12-20 14:24:06 EST
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
Patch to my_connect() to support IPv6 (2.19 KB, patch)
2016-03-11 17:49 EST, Stuart D Gathman
no flags Details | Diff
SPEC file used to test (7.49 KB, text/plain)
2016-03-11 17:50 EST, Stuart D Gathman
no flags Details

  None (edit)
Description Stuart D Gathman 2016-03-11 17:49:34 EST
Created attachment 1135430 [details]
Patch to my_connect() to support IPv6

Description of problem:
nsca does not support IPv6

Version-Release number of selected component (if applicable):
nsca-client-2.9.1-12.fc23.x86_64

How reproducible:
always

Steps to Reproduce:
1. send_nsca -H some.ipv6.host.name -c /etc/nagios/send_nsca.cfg 
2.
3.

Actual results:
Invalid host name 'some.ipv6.host.name'
Error: Could not connect to host some.ipv6.host.name on port 5667


Expected results:
1 data packet(s) sent to host successfully.


Additional info:
Patch attached that fixes send_nsca at least.
Comment 1 Stuart D Gathman 2016-03-11 17:50 EST
Created attachment 1135431 [details]
SPEC file used to test
Comment 2 Stuart D Gathman 2016-03-11 17:53:20 EST
Patching the server end is not as critical, because you typically use xinetd or a systemd.socket to listen on IP6 and then pass the socket to nsca.
Comment 3 Xavier Bachelot 2016-05-05 05:21:53 EDT
Hi Stuart,

Could you please submit this to upstream ? I'm not comfortable carrying out of tree patches, at least without upstream giving their opinion.

Regards,
Xavier
Comment 4 Stuart D Gathman 2016-05-05 13:34:59 EDT
https://github.com/NagiosEnterprises/nsca/pull/6
Comment 5 Fedora End Of Life 2016-11-24 11:02:19 EST
This message is a reminder that Fedora 23 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 23. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '23'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 23 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.
Comment 6 Fedora End Of Life 2016-12-20 14:24:06 EST
Fedora 23 changed to end-of-life (EOL) status on 2016-12-20. Fedora 23 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.
Comment 7 Stuart D Gathman 2016-12-20 15:54:06 EST
My Fedora packager id is sdgathman.  I can push this if you want to add me.

diff --git a/nsca.spec b/nsca.spec
index 1c6ba71..84c3777 100644
--- a/nsca.spec
+++ b/nsca.spec
@@ -7,7 +7,7 @@
 Summary:        Nagios Service Check Acceptor
 Name:           nsca
 Version:        2.9.1
-Release:        13%{?dist}
+Release:        13.1%{?dist}
 License:        GPLv2+
 Group:          Applications/System
 URL:            http://www.nagios.org/
@@ -21,6 +21,8 @@ Patch0:         nsca-2.9-initscript.patch
 Patch1:         nsca-2.9-confpath.patch
 # http://tracker.nagios.org/view.php?id=286
 Patch2:         nsca-2.9-fix_open_missing_arg.patch
+# https://github.com/NagiosEnterprises/nsca/pull/6
+Patch3:         nsca-2.9-ipv6.patch
 
 BuildRequires:  libmcrypt-devel
 %if %{systemd_support}
@@ -58,6 +60,7 @@ Client application for sending updates to a nsca server.
 %patch0 -p0 -b .initscript
 %patch1 -p1 -b .confpath
 %patch2 -p1 -b .open
+%patch3 -p1 -b .ipv6
 # Change defaults in the config file to match the nagios package
 sed -i -e "s|^command_file=.*|command_file=%{_localstatedir}/spool/nagios/cmd/nagios.cmd|" \
        -e "s|^alternate_dump_file=.*|alternate_dump_file=%{_localstatedir}/spool/nagios/cmd/nsca.dump|" \
@@ -141,6 +144,9 @@ rm -rf %{buildroot}
 
 
 %changelog
+* Tue Dec 20 2016 Stuart D. Gathman <stuart@gathman.org> - 2.9.1-13.1
+- IPv6 support for nsca-client
+
 * Thu Feb 04 2016 Fedora Release Engineering <releng@fedoraproject.org> - 2.9.1-13
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_24_Mass_Rebuild
Comment 8 Stuart D Gathman 2017-07-08 23:51:26 EDT
Please note that upstream has accepted this patch.

https://github.com/NagiosEnterprises/nsca/pull/24

Note You need to log in before you can comment on or make changes to this bug.