Bug 1317624 - Review Request: fpc-srpm-macros - RPM macros needed by packages built with Free Pascal Compiler
Summary: Review Request: fpc-srpm-macros - RPM macros needed by packages built with Fr...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Zbigniew Jędrzejewski-Szmek
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-03-14 17:17 UTC by Mattia Verga
Modified: 2016-11-24 12:30 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-04-09 15:26:07 UTC
Type: ---
zbyszek: fedora-review+


Attachments (Terms of Use)

Description Mattia Verga 2016-03-14 17:17:16 UTC
Spec URL: http://www.coolbits.it/fedora/fpc-srpm-macros.spec
SRPM URL: http://www.coolbits.it/fedora/fpc-srpm-macros-1.0-1.fc23.src.rpm
Description: This package contains RPM macros needed by packages built with the
Free Pascal Compiler. For example, it makes available a macro that
lists all architectures where fpc is available.

Fedora Account System Username: mattia

Comment 1 Zbigniew Jędrzejewski-Szmek 2016-04-04 02:31:07 UTC
URL is bogus — it's the project page, not the Fedora package page... Or is the project not supposed to exists outside of dist-git at all? That'd be fine, but please add a comment in the spec file to not confuse people.

Both the macros file and the srpm follow convention.

You should add a %license file. Or, maybe the license should be changed to Public Domain? I think that's more reasonable for a package this small, and no license file would be needed.

Anyway, package is APPROVED.

Comment 2 Mattia Verga 2016-04-04 14:45:49 UTC
Thanks.
I made this package similar to gnat-srpm-macros.git. Yes, there's no URL outside dist-git, so I used the same approach of gnat-srpm-macros. I will add a comment to clarify that.

About the license: I used MIT because the Fedora Project Contributor Agreement states that the default license for contributions in Fedora is MIT. However I have no problem to change it to Public Domain. I will do that while importing.

Comment 3 Gwyn Ciesla 2016-04-04 16:28:10 UTC
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/fpc-srpm-macros

Comment 4 Fedora Update System 2016-04-05 06:49:33 UTC
fpc-srpm-macros-1.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-d94fe63c90

Comment 5 Fedora Update System 2016-04-05 19:21:42 UTC
fpc-srpm-macros-1.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-d94fe63c90

Comment 6 Fedora Update System 2016-04-09 15:26:06 UTC
fpc-srpm-macros-1.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 7 Pavel Raiskup 2016-11-24 12:30:52 UTC
I can't resist :) because that's funny enough, ignore me:

This looked like 'Fedora Packaging Committee' macros to me, I was really
wondering whether this is yet another alternative to `fedora-rpm-macros`.


Note You need to log in before you can comment on or make changes to this bug.