Created attachment 1136544 [details] the patch It's worth to make QCOW2 compatibility version configurable. It would allow to early adopt compat=1.1 in el7 environments. https://www.mail-archive.com/users@ovirt.org/msg31469.html Please find attached the patch.
Thanks Pavel! I applied to patch to master and uploaded it to gerrit for you, can you check that the patch in gerrit? https://gerrit.ovirt.org/54759
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.
Tal, can we add this to 3.6.5?
I don't see any reason why not if as a VDSM maintainer you don't see a risk in doing that, setting target accordingly
Note that once you have an image in compat level of 1.1 it may never be used with and old EL6 host. Are we SURE we want to allow that?
I don't have problems with allowing config as long as the default remains as the current one.
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions
Nir, this bug is in MODIFIED for 3.6.7, but has patches on the master branch only. If you are planning to backport them, please set the status to POST. If you aren't, please set the target milestone to ovirt-4.0.0 and fix the flags accordingly.
(In reply to Allon Mureinik from comment #8) > Nir, this bug is in MODIFIED for 3.6.7, but has patches on the master branch > only. > > If you are planning to backport them, please set the status to POST. > If you aren't, please set the target milestone to ovirt-4.0.0 and fix the > flags accordingly. I'll backport the patches, keeping the target.
How to test: 1. By default there is no change in system behavior, and we still create qcow2 disks using compat 0.10. We can do general sanity tests for thin provisioning disks. To check qcow version you can run qemu-img info /path/to/volume Example configuration: [irs] qcow2_compat = 0.10 2. When setting irs:qcow2_compat to 1.1, all new volumes will use qcow2 compat 1.1 (e.g. new disk, snapshot). We can do general sanity tests for thin provisioned disks with this setting. Example configuration: [irs] qcow2_compat = 1.1 3. When setting irs:qcow2_compat to unsupported value (e.g 1.2), creating new volumes (e.g. new disk, snapshot) will fail with InvalidConfiguration exception in vdsm log. Example configuration: [irs] qcow2_compat = 1.2
(In reply to Allon Mureinik from comment #5) > Note that once you have an image in compat level of 1.1 it may never be used > with and old EL6 host. > Are we SURE we want to allow that? if we keep this for 4.0 (the current state) - how do we expect to move away from it? Don't we want to switch to 1.1 in 4.0? We maintain compatibility with 3.6 only which is RHEL 7.2 only so it should be ok, right?
(In reply to Michal Skrivanek from comment #11) > (In reply to Allon Mureinik from comment #5) > > Note that once you have an image in compat level of 1.1 it may never be used > > with and old EL6 host. > > Are we SURE we want to allow that? > > if we keep this for 4.0 (the current state) - how do we expect to move away > from it? Don't we want to switch to 1.1 in 4.0? We maintain compatibility > with 3.6 only which is RHEL 7.2 only so it should be ok, right? I don't think we will change anything in 4.0, as we did not start to work on this yet. When we move to qcow2 compat 1.1, we will have a new storage domain version: - version 3: qcow2 compat=0.10 - version 4: qcow2 compat=1.1 3.6 system would not be able to use new storage domain format.
Added a new patch adding missing validation in the merged patch, moving back to post.
Verified on ovirt-engine-4.0.0.4-0.1.el7ev.noarch using the steps in comment #10