+++ This bug was initially created as a clone of Bug #1315595 +++ Description of problem: After we add readinessProbe for mongodb template, the mongodb pod cannot startup after we update the admin password using oc env command. Version-Release number of selected component (if applicable): openshift v3.1.1.911 kubernetes v1.2.0-alpha.7-703-gbc4550d etcd 2.2.5 How reproducible: Steps to Reproduce: 1.Create a project 2.oc new-app mongodb-ephemeral --param=MONGODB_ADMIN_PASSWORD=admin 3.oc env dc/mongodb -e MONGODB_ADMIN_PASSWORD=newadmin Actual results: the pod cannot be ready and the livenessProbe are still using old password "admin" to check whether is ready. Expected results: the pod should be ready Additional info: [vagrant@ose ~]$ oc get dc -o json { "kind": "List", "apiVersion": "v1", "metadata": {}, "items": [ { "kind": "DeploymentConfig", "apiVersion": "v1", "metadata": { "name": "mongodb", "namespace": "haowang", "selfLink": "/oapi/v1/namespaces/haowang/deploymentconfigs/mongodb", "uid": "11dbb56b-e501-11e5-a697-fa163ed32d7c", "resourceVersion": "29214", "creationTimestamp": "2016-03-08T07:40:46Z", "labels": { "template": "mongodb-ephemeral-template" }, "annotations": { "openshift.io/generated-by": "OpenShiftNewApp" } }, "spec": { "strategy": { "type": "Recreate", "recreateParams": { "timeoutSeconds": 600 }, "resources": {} }, "triggers": [ { "type": "ImageChange", "imageChangeParams": { "containerNames": [ "mongodb" ], "from": { "kind": "ImageStreamTag", "namespace": "openshift", "name": "mongodb:latest" }, "lastTriggeredImage": "brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/rhscl/mongodb-26-rhel7:latest" } }, { "type": "ConfigChange" } ], "replicas": 1, "test": false, "selector": { "name": "mongodb" }, "template": { "metadata": { "creationTimestamp": null, "labels": { "name": "mongodb" }, "annotations": { "openshift.io/generated-by": "OpenShiftNewApp" } }, "spec": { "volumes": [ { "name": "mongodb-data", "emptyDir": {} } ], "containers": [ { "name": "mongodb", "image": "brew-pulp-docker01.web.prod.ext.phx2.redhat.com:8888/rhscl/mongodb-26-rhel7:latest", "ports": [ { "containerPort": 27017, "protocol": "TCP" } ], "env": [ { "name": "MONGODB_USER", "value": "userVFK" }, { "name": "MONGODB_PASSWORD", "value": "auVDR0M7gUKjHIoP" }, { "name": "MONGODB_DATABASE", "value": "sampledb" }, { "name": "MONGODB_ADMIN_PASSWORD", "value": "newadmin" } ], "resources": { "limits": { "memory": "512Mi" } }, "volumeMounts": [ { "name": "mongodb-data", "mountPath": "/var/lib/mongodb/data" } ], "livenessProbe": { "tcpSocket": { "port": 27017 }, "initialDelaySeconds": 30, "timeoutSeconds": 1, "periodSeconds": 10, "successThreshold": 1, "failureThreshold": 3 }, "readinessProbe": { "exec": { "command": [ "/bin/sh", "-i", "-c", "mongostat --host 127.0.0.1 -u admin -p admin -n 1 --noheaders" ] }, "initialDelaySeconds": 3, "timeoutSeconds": 1, "periodSeconds": 10, "successThreshold": 1, "failureThreshold": 3 }, "terminationMessagePath": "/dev/termination-log", "imagePullPolicy": "IfNotPresent", "securityContext": { "capabilities": {}, "privileged": false } } ], "restartPolicy": "Always", "terminationGracePeriodSeconds": 30, "dnsPolicy": "ClusterFirst", "securityContext": {} } } }, "status": { "latestVersion": 2, "details": { "causes": [ { "type": "ConfigChange" } ] } } } ] } --- Additional comment from Wang Haoran on 2016-03-08 03:03:09 EST --- I think , we should write a script to do the liveness check, using the env inside the container, not the env defined in the dc. --- Additional comment from openshift-github-bot on 2016-03-08 22:28:09 EST --- Commit pushed to master at https://github.com/openshift/origin https://github.com/openshift/origin/commit/b3980c05ef4e74cea6973dd5a7ec00beb721a54b Bug 1315595: Use in-container env vars for liveness/readiness probes --- Additional comment from Wang Haoran on 2016-03-09 23:40:58 EST --- Verified ,the templates works well ,but need brenton sync the templates to openshift-ansible. --- Additional comment from Wang Haoran on 2016-03-14 02:59:08 EDT --- Hi, scott, please help update the templates, thanks. --- Additional comment from Scott Dodson on 2016-03-14 09:46:32 EDT --- Updated content for the installer. I've updated both v1.1 and v1.2 content, I assume these changes are backwards compatible. If they're not can someone please speak up. https://github.com/openshift/openshift-ansible/pull/1451 --- Additional comment from Scott Dodson on 2016-03-14 13:32:26 EDT --- Installer updates have been merged. --- Additional comment from Wang Haoran on 2016-03-14 21:11:00 EDT --- Hi,Michal, I am not sure whether the templates is backwards compatible, could you please have a look ? --- Additional comment from Wang Haoran on 2016-03-17 05:07:12 EDT --- verified with : [root@openshift-106 ~]# openshift version openshift v3.2.0.4 kubernetes v1.2.0-origin-41-g91d3e75 etcd 2.2.5
We should sync these templates to https://github.com/openshift/online
Per https://github.com/openshift/online/issues/27 and however https://github.com/openshift/online/blob/master/scripts/maintenance/templates/create.sh gets incorporated into the online environment, the mongodb template referenced here created in online should be coming from https://github.com/openshift/origin. We don't have a separate copy stored in https://github.com/openshift/online. Hence the liveness check should be present. There is some activity going on outside of this bug wrt how the online env is getting set up. When I hear something conclusive from that, I'll update this bug accordingly.
*** This bug has been marked as a duplicate of bug 1318513 ***