Bug 1318809 - Please update f2fs-tools to version 1.6.0
Summary: Please update f2fs-tools to version 1.6.0
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: f2fs-tools
Version: 24
Hardware: All
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Eduardo Echeverria
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1318808 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-03-17 21:36 UTC by Gene Snider
Modified: 2016-11-19 21:00 UTC (History)
2 users (show)

Fixed In Version: f2fs-tools-1.7.0-1.fc24 f2fs-tools-1.7.0-1.fc25
Clone Of:
Environment:
Last Closed: 2016-11-10 03:22:23 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description Gene Snider 2016-03-17 21:36:50 UTC
Description of problem: The current stable release of f2fs-tools is version 1.6.0, according to http://git.kernel.org/cgit/linux/kernel/git/jaegeuk/f2fs-tools.git.  Fedora 24 is shipping version 1.4.1.  Version 1.6.0 has many improvements, and a defrag tool that is not in version 1.4.1.  Also, kernel 4.5 appears to appears to support features of version 1.6.0.  Please consider updating f2fs-tools to version 1.6.0.  P.S.  It's no longer on sourceforge, see the above URL.


Version-Release number of selected component (if applicable): Version 1.4.1


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Gene Snider 2016-03-18 15:24:21 UTC
*** Bug 1318808 has been marked as a duplicate of this bug. ***

Comment 2 Eduardo Echeverria 2016-08-07 05:28:49 UTC
Thanks I will update the package the next week, thanks

Comment 3 Gene Snider 2016-08-08 21:51:59 UTC
Thanks!  The current release is 1.7 now.  :)

Gene

Comment 4 Eduardo Echeverria 2016-10-09 00:02:53 UTC
Built in rawhide, F25 and F24, closing this thread.

Comment 5 Fedora Update System 2016-10-09 12:29:12 UTC
f2fs-tools-1.7.0-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-15d3c2305e

Comment 6 Fedora Update System 2016-10-09 13:50:31 UTC
f2fs-tools-1.7.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-8d878e3848

Comment 7 Gene Snider 2016-10-10 22:14:03 UTC
Thanks!  However, %patch0 -p1 -b .bigendian is no longer needed in the spec file.  The contents of f2fs-tools-1.4.0-bigendian.patch added a line as follows to f2fs-tools*//include/f2fs_fs.h:

+#include <byteswap.h>

f2fs_fs.h already had a confitional include for the file, but the flag was never set by configure. However, upstream noticed and corrected that quite some time ago.  Here's the commit that fixed it:

author	Yann E. MORIN <yann.morin.1998>	2014-12-25 17:39:19 (GMT)
committer	Jaegeuk Kim <jaegeuk>	2014-12-29 18:09:46 (GMT)
commit	936945a25d1b96535f1c3fbb81176f2ce3f848e1 (patch)
tree	0965715d882743644aca92abaac87e80b82a2e7a
parent	4757ef07d9d114f1abf8d900e94d00c8cc6bd05c (diff)
configure: also check for byteswap.h
include/f2fs_fs.h checks the HAVE_BYTESWAP_H conditional, but it is
never checked for in configure.

Add that header to the list of headers checked for.

Signed-off-by: "Yann E. MORIN" <yann.morin.1998>
Cc: Gustavo Zacarias <gustavo.ar>
Signed-off-by: Jaegeuk Kim <jaegeuk>
Diffstat
-rw-r--r--	configure.ac	2	
		
1 files changed, 1 insertions, 1 deletions
diff --git a/configure.ac b/configure.ac
index d66cb73..7cfd9b4 100644
--- a/configure.ac
+++ b/configure.ac
@@ -57,7 +57,7 @@ PKG_CHECK_MODULES([libuuid], [uuid])
 
 # Checks for header files.
 AC_CHECK_HEADERS([linux/fs.h fcntl.h mntent.h stdlib.h string.h \
-		sys/ioctl.h sys/mount.h unistd.h linux/falloc.h])
+		sys/ioctl.h sys/mount.h unistd.h linux/falloc.h byteswap.h])
 
 # Checks for typedefs, structures, and compiler characteristics.
 AC_C_INLINE

So now the patch just adds a redundant include to f2fs-tools*//include/f2fs_fs.h. I've been building it without that patch since 1.6 with no problems.  Also, the opensuse spec file f2fs-tools-1.6.0-30.3.src.rpm does NOT have any patches to upstream.  There are some useful comments in their spec file, you might check it out.

Thanks,
Gene

Comment 8 Fedora Update System 2016-11-10 03:22:23 UTC
f2fs-tools-1.7.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2016-11-19 21:00:59 UTC
f2fs-tools-1.7.0-1.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.