Spec URL: https://rbarlow.fedorapeople.org/rocket-depot.spec SRPM URL: https://rbarlow.fedorapeople.org/rocket-depot-1.0.0-1.fc25.src.rpm Description: Rocket Depot is a simple graphical front-end for rdesktop and FreeRDP with support for connection profiles. It runs on Linux desktops using GTK and takes advantage of modern desktop environment features such as Unity Quicklists. Fedora Account System Username: rbarlow
REVIEW: Legend: + = PASSED, - = FAILED, 0 = Not Applicable + rpmlint is silent (all warnings listed below are just false positives): Auriga ~/rpmbuild/SPECS: rpmlint ../RPMS/noarch/rocket-depot-1.0.0-1.fc24.noarch.rpm ../SRPMS/rocket-depot-1.0.0-1.fc24.src.rpm rocket-depot.noarch: W: spelling-error Summary(en_US) xfreerdp -> freezer rocket-depot.noarch: W: no-manual-page-for-binary rocket-depot rocket-depot.src: W: spelling-error Summary(en_US) rdesktop -> desktop, r desktop, leopardess rocket-depot.src: W: spelling-error Summary(en_US) xfreerdp -> freezer rocket-depot.src: W: spelling-error %description -l en_US rdesktop -> desktop, r desktop, leopardess 2 packages and 0 specfiles checked; 0 errors, 5 warnings. Auriga ~/rpmbuild/SPECS: + The package is named according to the Package Naming Guidelines. + The spec file name matches the base package %{name}, in the format %{name}.spec. + The package meets the Packaging Guidelines. + The package is licensed with a Fedora approved license and meets the Licensing Guidelines. + The License field in the package spec file matches the actual license (GPLv3 exactly). + The file, containing the text of the license(s) for the package, is included in %doc. + The spec file is written in American English. + The spec file for the package is legible. + The sources used to build the package, match the upstream source, as provided in the spec URL. Auriga ~/rpmbuild/SOURCES: sha256sum 1.0.0.tar.gz* 96899d2a2b8ecc7abd7bc2287aca9a16dedb32404dce2306018ca482d8a9736e 1.0.0.tar.gz 96899d2a2b8ecc7abd7bc2287aca9a16dedb32404dce2306018ca482d8a9736e 1.0.0.tar.gz.1 Auriga ~/rpmbuild/SOURCES: + The package successfully compiles and builds into binary rpms on at least one primary architecture (my own x86_64 PC). + All build dependencies are listed in BuildRequires. 0 No need to handle locales. 0 No shared library files in some of the dynamic linker's default paths. + The package does NOT bundle copies of system libraries. 0 The package is not designed to be relocatable. + The package owns all directories that it creates. + The package does not list a file more than once in the spec file's %files listings. + Permissions on files are set properly. + The package consistently uses macros. + The package contains code, or permissible content. 0 No extremely large documentation files. + Anything, the package includes as %doc, does not affect the runtime of the application. 0 No C/C++ header files. 0 No static libraries. 0 No pkgconfig(.pc) files. 0 The package doesn't contain library files without a suffix (e.g. libfoo.so) in some of the dynamic linker's default paths. 0 No devel sub-package. + The package does NOT contain any .la libtool archives. +/- The package includes a %{name}.desktop file, and this file must be validated with desktop-file-validate as stated here- https://fedoraproject.org/wiki/Packaging:Guidelines?rd=Packaging/Guidelines#desktop-file-install_usage + The package does not own files or directories already owned by other packages. + All filenames in rpm packages are valid UTF-8. So please validate *.desktop file. Since it's a minor issue I think we may consider this package as REVIEWED.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rocket-depot
rocket-depot-1.0.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-da9caa3d37
I filed https://bugzilla.redhat.com/show_bug.cgi?id=1332303 to track validating the desktop file. Thanks for the review!
rocket-depot-1.0.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-3c873f6f63
rocket-depot-1.0.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-da9caa3d37
rocket-depot-1.0.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.
rocket-depot-1.0.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-3c873f6f63
rocket-depot-1.0.0-2.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-9039104b1f
rocket-depot-1.0.0-2.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-9039104b1f
rocket-depot-1.0.0-2.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.