Bug 1320101 - Client log gets flooded by default with fop stats under DEBUG level
Summary: Client log gets flooded by default with fop stats under DEBUG level
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: io-stats
Version: mainline
Hardware: All
OS: All
medium
medium
Target Milestone: ---
Assignee: Anoop C S
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 1332387
TreeView+ depends on / blocked
 
Reported: 2016-03-22 10:18 UTC by Anoop C S
Modified: 2016-06-16 14:01 UTC (History)
6 users (show)

Fixed In Version: glusterfs-3.8rc2
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1332387 (view as bug list)
Environment:
Last Closed: 2016-06-16 14:01:05 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Anoop C S 2016-03-22 10:18:32 UTC
Description of problem:
By default raising the client log level to DEBUG will dump JSON fop statistics every 5 seconds to client logs. It's annoying to see all those stats even if someone is not interested. In addition to that it will eats up the disk space very fast.

Version-Release number of selected component (if applicable):
master

How reproducible:
Always

Steps to Reproduce:
1. Create a simple 1-brick distribute volume.
2. Start the volume and do the following volume set operation
# gluster volume set <VOLNAME> diagnostics.client-log-level DEBUG
3. Check client logs.

Actual results:
Huge dump of json fop statistics are dumped very fast.

Expected results:
No fop statistics dump are seen in client logs.

Additional info:
Even though we do have a volume set option(diagnostics.stats-dump-interval) to disable this dumping of fop stats to client logs, it is not taken into effect unless a re-mount of the volume is done.

Comment 1 Vijay Bellur 2016-03-22 10:29:16 UTC
REVIEW: http://review.gluster.org/13808 (debug/io-stats: Disable fop stats dump by default) posted (#1) for review on master by Anoop C S (anoopcs)

Comment 2 Vijay Bellur 2016-03-24 15:05:24 UTC
COMMIT: http://review.gluster.org/13808 committed in master by Jeff Darcy (jdarcy) 
------
commit 91004b046805243e730176a5354ce3092326dde4
Author: Anoop C S <anoopcs>
Date:   Tue Mar 22 15:51:37 2016 +0530

    debug/io-stats: Disable fop stats dump by default
    
    Even though someone is not interested in seeing the fops statistics in
    client logs under DEBUG level we forcefully dump the same. This is due
    to default dump-interval configured to as 5 seconds. Since can use
    diagnostics.stats-dump-interval volume set option to change the default
    dump-interval its better to disable this huge dumping by default.
    
    Change-Id: Id14a38bcd92e47d75003279567a0f80acac1d86e
    BUG: 1320101
    Signed-off-by: Anoop C S <anoopcs>
    Reviewed-on: http://review.gluster.org/13808
    Smoke: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    CentOS-regression: Gluster Build System <jenkins.com>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 3 Mike McCune 2016-03-28 22:23:05 UTC
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

Comment 4 Niels de Vos 2016-06-16 14:01:05 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.