Bug 1320489 - glfs-mgmt: fix connecting to multiple volfile transports
Summary: glfs-mgmt: fix connecting to multiple volfile transports
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: libgfapi
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Prasanna Kumar Kalever
QA Contact: Sudhir D
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-03-23 10:45 UTC by Prasanna Kumar Kalever
Modified: 2016-06-16 14:01 UTC (History)
1 user (show)

Fixed In Version: glusterfs-3.8rc2
Clone Of:
Environment:
Last Closed: 2016-06-16 14:01:30 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Prasanna Kumar Kalever 2016-03-23 10:45:42 UTC
Description of problem:
problem:
    [
            {"host":"1.2.3.4", "port":"24007", "transport":"tcp"},
            {"host":"/var/run/glusterd.socket", "transport":"unix"}
    ]
    
consider the above case where we have two volfile servers, each
has different transport type, we first try to connect to server1
which has transport type "tcp" let's say we found that host address
is invalid, now we pick the next available server2, in our case
it is of type "unix" and try to connect to it.
    
but we fail to connect to it even we have right unix path, because
multiple volfile servers with different transport type is not taken
care currently.

Version-Release number of selected component (if applicable):
mainline

How reproducible:
always

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Vijay Bellur 2016-03-23 10:52:18 UTC
REVIEW: http://review.gluster.org/13819 (glfs-mgmt: fix connecting to multiple volfile transports) posted (#1) for review on master by Prasanna Kumar Kalever (pkalever)

Comment 2 Vijay Bellur 2016-03-24 15:08:16 UTC
COMMIT: http://review.gluster.org/13819 committed in master by Jeff Darcy (jdarcy) 
------
commit 1b1fae4b8b351ee768f8fa61c3e5e5debfa2eb15
Author: Prasanna Kumar Kalever <prasanna.kalever>
Date:   Wed Mar 23 15:45:08 2016 +0530

    glfs-mgmt: fix connecting to multiple volfile transports
    
    Problem:
    [
            {"host":"1.2.3.4", "port":"24007", "transport":"tcp"},
            {"host":"/var/run/glusterd.socket", "transport":"unix"}
    ]
    
    Consider the above case where we have two volfile servers, each
    has different transport type, we first try to connect to server1
    which has transport type "tcp" let's say we found that host address
    is invalid, now we pick the next available server2, in our case
    it is of type "unix" and try to connect to it.
    
    but we fail to connect to it even we have right unix path, because
    multiple volfile servers with different transport type is not taken
    care currently.
    
    Solution:
    Every time we receive a  RPC_CLNT_DISCONNECT event in mgmt_rpc_notify,
    we need to check the transport type of the volfile server in the list
    and set the keys "transport.socket.connect-path" or "remote-host"
    accordingly.
    
    Change-Id: I36bec46ef2e92e4642a7d7d64b423d0bc3ab269b
    BUG: 1320489
    Signed-off-by: Prasanna Kumar Kalever <prasanna.kalever>
    Reviewed-on: http://review.gluster.org/13819
    Smoke: Gluster Build System <jenkins.com>
    CentOS-regression: Gluster Build System <jenkins.com>
    Tested-by: Prasanna Kumar Kalever <pkalever>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 3 Niels de Vos 2016-06-16 14:01:30 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.