Bug 1320515 - Remove deprecated api/vms/<id>/move
Summary: Remove deprecated api/vms/<id>/move
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: RestAPI
Version: 4.0.0
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ovirt-4.0.0-alpha
: 4.0.0
Assignee: Allon Mureinik
QA Contact: Raz Tamir
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-03-23 12:01 UTC by Allon Mureinik
Modified: 2016-07-05 07:51 UTC (History)
5 users (show)

Fixed In Version: ovirt 4.0.0 alpha1
Doc Type: Deprecated Functionality
Doc Text:
The "/vms/<vmid>/move" API has been removed after being deprecated in Red Hat Enterprise Virtualization 3.1.
Clone Of:
Environment:
Last Closed: 2016-07-05 07:51:24 UTC
oVirt Team: Storage
Embargoed:
rule-engine: ovirt-4.0.0+
ylavi: planning_ack+
amureini: devel_ack+
acanan: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 55086 0 master MERGED core: Remove MoveVmCommand 2016-03-30 17:22:38 UTC

Description Allon Mureinik 2016-03-23 12:01:29 UTC
Description of problem:

oVirt 3.0 had a notion of a VM being placed on a storage domain, and as such had a /move API.

oVirt 3.1 changed the concept and made a disk an entity. In 3.1, and onwards, a disk is placed on a storage domain, and may (or may not) be attached to a VM. Disks can also be moved between domains.

Since 3.1, the /move API for VMs has clearly been marked as deprecated (as it no longer makes any sense), has not been maintained or tested, and is quite probably broken.

oVrit 4.0 is a good opportunity to remove this API completely. 


Version-Release number of selected component (if applicable):
4.0.

How reproducible:
100%

Comment 1 Juan Hernández 2016-03-23 12:20:49 UTC
The operation can be removed from versio 4 of the API, that isn't a problem. But in theory we shouldn't remove it from version 3 of the API, as it is a backwards compatibility breaking change. To make it clear, if this bug is acked it means that we agree to remove the operation from version 3 of the API.

Comment 2 Yaniv Lavi 2016-03-23 14:37:53 UTC
(In reply to Juan Hernández from comment #1)
> The operation can be removed from versio 4 of the API, that isn't a problem.
> But in theory we shouldn't remove it from version 3 of the API, as it is a
> backwards compatibility breaking change. To make it clear, if this bug is
> acked it means that we agree to remove the operation from version 3 of the
> API.

I would hide it in 4.0 and remove it in 4.1.

Comment 3 Juan Hernández 2016-03-23 15:39:21 UTC
Yaniv, if/when the decision to keep it till 4.1 is firm, remember to nack the bug, or move it to ovirt-4.1.0, to make it clear.

Comment 4 Yaniv Lavi 2016-03-23 15:51:30 UTC
(In reply to Juan Hernández from comment #3)
> Yaniv, if/when the decision to keep it till 4.1 is firm, remember to nack
> the bug, or move it to ovirt-4.1.0, to make it clear.

I missed this item:
"""
Since 3.1, the /move API for VMs has clearly been marked as deprecated (as it no longer makes any sense), has not been maintained or tested, and is quite probably broken.
"""

Since we announced this is deprecated from 3.1, I'm ok with removing it in the 3.x API in 4.0 as well.

Comment 5 Mike McCune 2016-03-28 22:15:42 UTC
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

Comment 6 Raz Tamir 2016-04-10 11:06:32 UTC
Verified:

response body of /api/vms/{vm: id}

actions>
<link href="/ovirt-engine/api/vms/3dbac066-0347-4a3e-a6e8-1f524ebe78fb/ticket" rel="ticket"/>
<link href="/ovirt-engine/api/vms/3dbac066-0347-4a3e-a6e8-1f524ebe78fb/freezefilesystems" rel="freezefilesystems"/>
<link href="/ovirt-engine/api/vms/3dbac066-0347-4a3e-a6e8-1f524ebe78fb/logon" rel="logon"/>
<link href="/ovirt-engine/api/vms/3dbac066-0347-4a3e-a6e8-1f524ebe78fb/cancelmigration" rel="cancelmigration"/>
<link href="/ovirt-engine/api/vms/3dbac066-0347-4a3e-a6e8-1f524ebe78fb/commitsnapshot" rel="commitsnapshot"/>
<link href="/ovirt-engine/api/vms/3dbac066-0347-4a3e-a6e8-1f524ebe78fb/clone" rel="clone"/>
<link href="/ovirt-engine/api/vms/3dbac066-0347-4a3e-a6e8-1f524ebe78fb/maintenance" rel="maintenance"/>
<link href="/ovirt-engine/api/vms/3dbac066-0347-4a3e-a6e8-1f524ebe78fb/reboot" rel="reboot"/>
<link href="/ovirt-engine/api/vms/3dbac066-0347-4a3e-a6e8-1f524ebe78fb/reordermacaddresses" rel="reordermacaddresses"/>
<link href="/ovirt-engine/api/vms/3dbac066-0347-4a3e-a6e8-1f524ebe78fb/thawfilesystems" rel="thawfilesystems"/>
<link href="/ovirt-engine/api/vms/3dbac066-0347-4a3e-a6e8-1f524ebe78fb/undosnapshot" rel="undosnapshot"/>
<link href="/ovirt-engine/api/vms/3dbac066-0347-4a3e-a6e8-1f524ebe78fb/detach" rel="detach"/>
<link href="/ovirt-engine/api/vms/3dbac066-0347-4a3e-a6e8-1f524ebe78fb/previewsnapshot" rel="previewsnapshot"/>
<link href="/ovirt-engine/api/vms/3dbac066-0347-4a3e-a6e8-1f524ebe78fb/migrate" rel="migrate"/>
<link href="/ovirt-engine/api/vms/3dbac066-0347-4a3e-a6e8-1f524ebe78fb/export" rel="export"/>
<link href="/ovirt-engine/api/vms/3dbac066-0347-4a3e-a6e8-1f524ebe78fb/shutdown" rel="shutdown"/>
<link href="/ovirt-engine/api/vms/3dbac066-0347-4a3e-a6e8-1f524ebe78fb/start" rel="start"/>
<link href="/ovirt-engine/api/vms/3dbac066-0347-4a3e-a6e8-1f524ebe78fb/stop" rel="stop"/>
<link href="/ovirt-engine/api/vms/3dbac066-0347-4a3e-a6e8-1f524ebe78fb/suspend" rel="suspend"/>
</actions>

No move action

Comment 7 Sandro Bonazzola 2016-07-05 07:51:24 UTC
oVirt 4.0.0 has been released, closing current release.


Note You need to log in before you can comment on or make changes to this bug.