Bugzilla will be upgraded to version 5.0. The upgrade date is tentatively scheduled for 2 December 2018, pending final testing and feedback.
Bug 1320689 - Post install callback doesn't always work
Post install callback doesn't always work
Status: CLOSED ERRATA
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Provisioning (Show other bugs)
5.5.0
Unspecified Unspecified
high Severity high
: GA
: 5.6.0
Assigned To: Brandon Dunne
Shveta
: ZStream
Depends On:
Blocks: 1321597 1322831
  Show dependency treegraph
 
Reported: 2016-03-23 14:04 EDT by Brandon Dunne
Modified: 2016-07-12 14:45 EDT (History)
10 users (show)

See Also:
Fixed In Version: 5.6.0.1
Doc Type: Bug Fix
Doc Text:
Previously, using the post install callback URL to shutdown a virtual machine doing a PXE / ISO install on RHEV & VMware did not work. This fix updates the post_install_callback logic based on new state and the issue is now resolved. The post_install_callback logic now shuts down the virtual machine and state machine moves on to next state.
Story Points: ---
Clone Of:
: 1321597 1322831 (view as bug list)
Environment:
Last Closed: 2016-06-29 11:44:28 EDT
Type: Bug
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)
hotfix_bz_1318436_1320689.tgz (3.05 KB, application/x-gzip)
2016-03-24 11:31 EDT, Brandon Dunne
no flags Details


External Trackers
Tracker ID Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1348 normal SHIPPED_LIVE CFME 5.6.0 bug fixes and enhancement update 2016-06-29 14:50:04 EDT

  None (edit)
Description Brandon Dunne 2016-03-23 14:04:34 EDT
Description of problem:
Using the post install callback url to shutdown a VM doing a PXE / ISO install on RHEV & Vmware doesn't work.

How reproducible:
Always

Steps to Reproduce:
Provision a VM via PXE or ISO on RHEV or VMware.  Ensure that the installer hits the post_install_callback_url and does not shut down when finished.

Actual results:
post_install_callback is ignored, state machine stays in poll_destination_powered_off_in_provider loop

Expected results:
VM should shut down and state machine should move on to next state.
Comment 3 Brandon Dunne 2016-03-24 11:31 EDT
Created attachment 1140010 [details]
hotfix_bz_1318436_1320689.tgz

Apply from within the vmdb directory.  It includes fixes from this bug as well as 1318436.
Comment 4 Brandon Dunne 2016-03-24 11:33:53 EDT
Felix, hotfix is attached.
Comment 5 CFME Bot 2016-03-24 16:01:01 EDT
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/a7632d35ec870a4d064a9896f5a73063952f434f

commit a7632d35ec870a4d064a9896f5a73063952f434f
Author:     Brandon Dunne <bdunne@redhat.com>
AuthorDate: Tue Mar 22 16:44:56 2016 -0400
Commit:     Brandon Dunne <bdunne@redhat.com>
CommitDate: Wed Mar 23 14:06:05 2016 -0400

    Update post_install_callback logic based on new state
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1320689

 app/models/miq_provision/post_install_callback.rb | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Comment 6 CFME Bot 2016-03-24 16:01:04 EDT
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/2f724accec9ef1768c97ca9094c3df86ace721be

commit 2f724accec9ef1768c97ca9094c3df86ace721be
Author:     Brandon Dunne <bdunne@redhat.com>
AuthorDate: Wed Mar 23 13:33:18 2016 -0400
Commit:     Brandon Dunne <bdunne@redhat.com>
CommitDate: Wed Mar 23 14:06:06 2016 -0400

    Add tests for MiqProvision::PostInstallCallback#post_install_callback
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1320689

 .../miq_provision/post_install_callback_spec.rb    | 72 ++++++++++++++++++++++
 1 file changed, 72 insertions(+)
 create mode 100644 spec/models/miq_provision/post_install_callback_spec.rb
Comment 7 Felix Dewaleyne 2016-03-24 20:58:40 EDT
does the hotfix include the changes of bz#1318436?
Comment 8 Brandon Dunne 2016-03-28 09:44:05 EDT
Yes, it does Felix
Comment 9 Felix Dewaleyne 2016-03-30 12:39:35 EDT
the customer's test environment seems to show the fix resolves all the issues raised. he will do a final test tomorrow
Comment 12 CFME Bot 2016-04-15 10:28:07 EDT
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=93d2bb2865c4bc99fc0fe732372bda8cc006fafc

commit 93d2bb2865c4bc99fc0fe732372bda8cc006fafc
Author:     Brandon Dunne <bdunne@redhat.com>
AuthorDate: Tue Mar 22 16:44:56 2016 -0400
Commit:     Brandon Dunne <bdunne@redhat.com>
CommitDate: Thu Mar 24 10:20:40 2016 -0400

    Update post_install_callback logic based on new state
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1320689

 app/models/miq_provision/post_install_callback.rb | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
Comment 13 CFME Bot 2016-04-15 10:28:11 EDT
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=20b4783b4a38f3548d6f8196458b213923ab5f58

commit 20b4783b4a38f3548d6f8196458b213923ab5f58
Author:     Brandon Dunne <bdunne@redhat.com>
AuthorDate: Mon Mar 28 15:58:37 2016 -0400
Commit:     Brandon Dunne <bdunne@redhat.com>
CommitDate: Mon Mar 28 15:58:37 2016 -0400

    Add tests for MiqProvision::PostInstallCallback#post_install_callback
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1320689

 .../miq_provision/post_install_callback_spec.rb    | 79 ++++++++++++++++++++++
 1 file changed, 79 insertions(+)
 create mode 100644 spec/models/miq_provision/post_install_callback_spec.rb
Comment 14 Shveta 2016-04-18 21:46:35 EDT
Fixed.
Verified in 5.6.0.1-beta2.20160413141124_e25ac0e
Comment 16 errata-xmlrpc 2016-06-29 11:44:28 EDT
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348

Note You need to log in before you can comment on or make changes to this bug.