Description of problem: If you navigate to 1B Configure Lifecycle Environment, and create a New Environment Path, while we replace invalid characters in name when we automatically create the label (based on what they name it), we don't appear to do any checking of characters that are added to Label by the user directly. You can freely edit the Label field, and put those special characters back in. This causes issues when you go to save, throwing an error in Satellite: "error saving environmentError: The adapter rejected the commit because it was invalid". If you try to create a New Environment Path again, the name field will be blank, but the label field will be whatever that failed commit contained. We should be preventing invalid characters from being entered there, or at least prevent submission of the dialog while there are invalid characters, so we can avoid this error case. Version-Release number of selected component (if applicable): TP3 How reproducible: 100% Steps to Reproduce: 1. create new deployment 2. proceed to 1b Configure Lifecycle Environment 3. Select After manually publishing them 4. Click New Environment Path 5. Enter something for name, and then edit Label to include a special character, such as !, try to save Actual results: Error message thrown, environment path not created Expected results: For dialog to catch invalid characters and not let the user submit that dialog with bad data in it, so we can avoid this error Additional info:
Created attachment 1139999 [details] Error message when label prevents the creation of a new environment path
Created attachment 1140000 [details] After the error, the bad Label persists when you reopen the New Environment Path dialog
Already fixed, label field has been disabled.
The logic for lifecycle environment names and labels on 1B. Update Availability is inconsistent with the logic used under the Satellite's Content > Lifecycle Environments tab. 1.) If I create a new environment under Content > Lifecycle Environments > New Environment Path, I can use spaces and punctuation marks. The label replaces them with underscores. For example: Name: Fusor<space>environment<space>1,<space>for<space>fun! Label: Fusor_environment_1__for_fun_ If I try to create the same name under 1B. Update Availability > After manually publishing them > New Environment Path, I get the warning message after typing the first 'e': Name: Fusor<space>e -> This field must contain only 'A-Z', 'a-z', '0-9', '_' or '-' characters. 2.) If I create an environment under Content > Lifecycle Environments, any leading or trailing spaces I enter in the name are trimmed from the name and label. They get trimmed from the name, but not from the label, when creating the environment in 1B. Update Availability. For example, entering a name of "<space>test<space>" generates a label of "test" in Content > Lifecycle Environments, and a label of "_test_" in 1B. Update Availability. 3.) 1B. Update Availability generates a label with all letters lowercased, but Content > Lifecycle Environments. E.g., an environment name of "Test" gets a label of "test" in the former, but "Test" in the latter.
Fixed https://github.com/fusor/fusor/pull/1036
QCI-1.2-RHEL-7-20160718.t.0
None of the issues in https://bugzilla.redhat.com/show_bug.cgi?id=1321048#c4 have been fixed in QCI-1.2-RHEL-7-20160718.t.0.
Tasos, try again please. Maybe you were on a system where the commit was not merged. I just tried again and it seems fixed on my system.
The fixes are in QCI-1.2-RHEL-7-20160720.t.0. Marking as verified.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2016:1862