Bug 1321631 - Catalog Item : Catalog tab fields goes missing when "Display in Catalog" is checked
Summary: Catalog Item : Catalog tab fields goes missing when "Display in Catalog" is ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: UI - OPS
Version: 5.5.0
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: GA
: 5.6.0
Assignee: Harpreet Kataria
QA Contact: Shveta
URL:
Whiteboard: service:catalog
Depends On:
Blocks: 1322834
TreeView+ depends on / blocked
 
Reported: 2016-03-28 17:11 UTC by Shveta
Modified: 2016-06-29 15:45 UTC (History)
9 users (show)

Fixed In Version: 5.6.0.1
Doc Type: Bug Fix
Doc Text:
Clone Of:
: 1322834 (view as bug list)
Environment:
Last Closed: 2016-06-29 15:45:13 UTC
Category: ---
Cloudforms Team: ---
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
err (74.51 KB, image/png)
2016-03-28 17:11 UTC, Shveta
no flags Details
checkbox checked (84.65 KB, image/png)
2016-03-30 22:14 UTC, Shveta
no flags Details
with display in catalog unchecked (101.81 KB, image/png)
2016-03-30 22:15 UTC, Shveta
no flags Details
logs (1.86 MB, text/plain)
2016-03-30 22:17 UTC, Shveta
no flags Details


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2016:1348 0 normal SHIPPED_LIVE CFME 5.6.0 bug fixes and enhancement update 2016-06-29 18:50:04 UTC

Description Shveta 2016-03-28 17:11:18 UTC
Created attachment 1140937 [details]
err

Description of problem:


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Create a catalog item of type Vmware.
2. Select "display in catalog" .
3. Under Request Info tab , catalog tab doesn't show host and datastore .

Actual results:Workaround : click on environment tab and then again on catalog tab . Fields are displayed now


Expected results:


Additional info:
5.5.3.2.20160318152106_92d2d67

Comment 2 Shveta 2016-03-30 22:14:55 UTC
Created attachment 1141947 [details]
checkbox checked

Comment 3 Shveta 2016-03-30 22:15:22 UTC
Created attachment 1141948 [details]
with display in catalog unchecked

Comment 4 Shveta 2016-03-30 22:17:02 UTC
Created attachment 1141949 [details]
logs

Comment 5 Dave Johnson 2016-03-31 01:09:13 UTC
Shveta, is this new with 5.5.3, is it the same on 5.5.2?

Comment 6 Shveta 2016-03-31 15:07:12 UTC
Dave , this is new in 5.5.3

Comment 7 Dave Johnson 2016-03-31 15:41:24 UTC
This does impact some test automation, we came up with an ugly workaround but better to fix sooner than later.

Comment 8 Harpreet Kataria 2016-04-04 15:04:45 UTC
https://github.com/ManageIQ/manageiq/pull/7693

Comment 9 CFME Bot 2016-04-05 23:00:45 UTC
New commit detected on ManageIQ/manageiq/master:
https://github.com/ManageIQ/manageiq/commit/85272bd43ff416b63aeffd22ba05dd08df4923f9

commit 85272bd43ff416b63aeffd22ba05dd08df4923f9
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon Apr 4 12:06:29 2016 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Mon Apr 4 12:42:53 2016 -0400

    form_div should only be replaced for certain type of catalog items.
    
    Only replace form_div for generic type catalog items because there are no tabs on the screen, if display in catalog is set need to redraw the screen to draw the tabs and show/hide them. Replacing form_div for the types that already have tabs on screen was causing instance variables to be reset in provisioning dialogs.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1321631
    https://bugzilla.redhat.com/show_bug.cgi?id=1322834

 app/controllers/catalog_controller.rb       |  3 ++-
 spec/controllers/catalog_controller_spec.rb | 29 +++++++++++++++++++++++++++++
 2 files changed, 31 insertions(+), 1 deletion(-)

Comment 13 CFME Bot 2016-04-21 17:46:47 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=e09fad9332da50bab9596582361007957cd6e983

commit e09fad9332da50bab9596582361007957cd6e983
Author:     Harpreet Kataria <hkataria>
AuthorDate: Mon Apr 4 12:06:29 2016 -0400
Commit:     Harpreet Kataria <hkataria>
CommitDate: Fri Apr 15 12:19:04 2016 -0400

    form_div should only be replaced for certain type of catalog items.
    
    - Only replace form_div for generic type catalog items because there are no tabs on the screen, if display in catalog is set need to redraw the screen to draw the tabs and show/hide them. Replacing form_div for the types that already have tabs on screen was causing instance variables to be reset in provisioning dialogs.
    - Adjusted spec test to pass on 5.5.z
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1321631
    https://bugzilla.redhat.com/show_bug.cgi?id=1322834
    (cherry picked from commit 85272bd)

 app/controllers/catalog_controller.rb       |  3 ++-
 spec/controllers/catalog_controller_spec.rb | 29 +++++++++++++++++++++++++++++
 2 files changed, 31 insertions(+), 1 deletion(-)

Comment 14 CFME Bot 2016-04-21 17:46:55 UTC
New commit detected on cfme/5.5.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=a6e7de373d30c2cf32d083d2c60ade0c7a8c2e6d

commit a6e7de373d30c2cf32d083d2c60ade0c7a8c2e6d
Merge: 32af3c0 e09fad9
Author:     Dan Clarizio <dclarizi>
AuthorDate: Thu Apr 21 13:29:56 2016 -0400
Commit:     Dan Clarizio <dclarizi>
CommitDate: Thu Apr 21 13:29:56 2016 -0400

    Merge branch '55z_pr_7693' into '5.5.z'
    
    form_div should only be replaced for certain type of catalog items.
    
    Only replace form_div for generic type catalog items because there are no tabs on the screen, if display in catalog is set need to redraw the screen to draw the tabs and show/hide them. Replacing form_div for the types that already have tabs on screen was causing instance variables to be reset in provisioning dialogs.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1321631
    https://bugzilla.redhat.com/show_bug.cgi?id=1322834
    (cherry picked from commit 85272bd)
    
    @dclarizi please review, clean cherry-pick from https://github.com/ManageIQ/manageiq/pull/7693
    
    See merge request !891

 app/controllers/catalog_controller.rb       |  3 ++-
 spec/controllers/catalog_controller_spec.rb | 29 +++++++++++++++++++++++++++++
 2 files changed, 31 insertions(+), 1 deletion(-)

Comment 15 Shveta 2016-05-04 17:53:49 UTC
Fixed.
Verified in 

5.6.0.5-beta2.4.20160503153816_1fb554f

Comment 17 errata-xmlrpc 2016-06-29 15:45:13 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1348


Note You need to log in before you can comment on or make changes to this bug.