Bug 1321762 - glusterd: response not aligned
Summary: glusterd: response not aligned
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: scripts
Version: mainline
Hardware: x86_64
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Atin Mukherjee
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: 958079 1211845 1322667
TreeView+ depends on / blocked
 
Reported: 2016-03-29 05:54 UTC by Atin Mukherjee
Modified: 2016-06-16 14:01 UTC (History)
7 users (show)

Fixed In Version: glusterfs-3.8rc2
Doc Type: Bug Fix
Doc Text:
Clone Of: 1211845
: 1322667 (view as bug list)
Environment:
Last Closed: 2016-06-16 14:01:30 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Atin Mukherjee 2016-03-29 05:54:25 UTC
+++ This bug was initially created as a clone of Bug #1211845 +++

+++ This bug was initially created as a clone of Bug #958079 +++

Description of problem:

response string for /etc/init.d/glusterd is not aligned
Version-Release number of selected component (if applicable):
glusterfs-3.4.0.1rhs-1.el6rhs.x86_64

How reproducible:
on all my rhs nodes

Steps to Reproduce:
1.
/etc/init.d/glusterd stop
  
Actual results:
[root@rhs-goldman2 ~]# /etc/init.d/glusterd stop
[root@rhs-goldman2 ~]#                                     [  OK  ]


Expected results:
it should be similar to,
[root@rhs-goldman2 ~]# /etc/init.d/glusterd start
Starting glusterd:                                         [  OK  ]


Additional info:

--- Additional comment from RHEL Product and Program Management on 2013-04-30 07:04:11 EDT ---

Since this issue was entered in bugzilla, the release flag has been
set to ? to ensure that it is properly evaluated for this release.

--- Additional comment from Amar Tumballi on 2013-05-03 01:56:33 EDT ---

looks like a minor fix required in glusterd init script. good to target fixing, as its a cosmetic issue for admins.

--- Additional comment from Saurabh on 2013-06-25 05:47:33 EDT ---

still to be seen on

[root@nfs4 bricks]# rpm -qa | grep glusterfs
glusterfs-server-3.4.0.12rhs-1.el6rhs.x86_64
glusterfs-fuse-3.4.0.12rhs-1.el6rhs.x86_64
glusterfs-3.4.0.12rhs-1.el6rhs.x86_64

[root@nfs4 bricks]# /etc/init.d/glusterd stop
[root@nfs4 bricks]#                                        [  OK  ]

Requesting to get it fixed.

--- Additional comment from SATHEESARAN on 2014-05-14 04:55:52 EDT ---

The issue is still seen with RHS 3.0 Nightly builds ( glusterfs-3.6.0-4.0.el6rhs )

[root@rhss1 ~]# service glusterd stop
[root@rhss1 ~]# d:                                         [  OK  ]

--- Additional comment from SATHEESARAN on 2014-12-03 04:42:08 EST ---

This issue is no longer seen in RHS 2.1 U* bits. But the issue is seen with RHS 3.0 Bits. I feel this bug could be closed wrt RHS 2.1

--- Additional comment from Vivek Agarwal on 2015-04-14 06:52:09 EDT ---

Can you confirm if this is fixed in 3.0.x now?

--- Additional comment from SATHEESARAN on 2015-04-14 13:43:35 EDT ---

(In reply to Vivek Agarwal from comment #6)
> Can you confirm if this is fixed in 3.0.x now?

This issue is still there with RH-Gluster Storage server 3.0.4

[root@~]# cat /etc/redhat-storage-release 
Red Hat Storage Server 3.0 Update 4

[root@ ~]# gluster --version
glusterfs 3.6.0.53 built on Mar 18 2015 08:12:40
Repository revision: git://git.gluster.com/glusterfs.git
Copyright (c) 2006-2011 Gluster Inc. <http://www.gluster.com>
GlusterFS comes with ABSOLUTELY NO WARRANTY.
You may redistribute copies of GlusterFS under the terms of the GNU General Public License.


[root@dhcp37-66 ~]# service glusterd stop
[root@dhcp37-66 ~]#                                        [  OK  ]

I am no longer seeing this issue with RHS 2.1.x
This is a problem with RHS 3.0.x
Not seeing this problem upstream

--- Additional comment from Vivek Agarwal on 2015-04-15 01:25:57 EDT ---

Marking this for 3.0.5, request you to put the upstream patch url here.

--- Additional comment from SATHEESARAN on 2015-04-15 01:33:36 EDT ---

(In reply to Vivek Agarwal from comment #8)
> Marking this for 3.0.5, request you to put the upstream patch url here.

I am not sure which patch fixed this, I would seek dev's help and would ask them to update it with relevant information

--- Additional comment from SATHEESARAN on 2015-08-03 09:20:42 EDT ---

There won't be any 3.0.z, and hence marking this bug for RHGS 3.1.z

Comment 1 Vijay Bellur 2016-03-29 05:58:51 UTC
REVIEW: http://review.gluster.org/13839 (extras: allign glusterd stop response in init script) posted (#1) for review on master by Atin Mukherjee (amukherj)

Comment 2 Vijay Bellur 2016-03-29 06:19:52 UTC
REVIEW: http://review.gluster.org/13839 (extras: allign glusterd stop response in init script) posted (#2) for review on master by Atin Mukherjee (amukherj)

Comment 3 Vijay Bellur 2016-03-29 07:26:06 UTC
REVIEW: http://review.gluster.org/13839 (extras: align glusterd stop response in init script) posted (#3) for review on master by Niels de Vos (ndevos)

Comment 4 Vijay Bellur 2016-03-29 09:07:22 UTC
REVIEW: http://review.gluster.org/13839 (extras: allign glusterd stop response in init script) posted (#4) for review on master by Atin Mukherjee (amukherj)

Comment 5 Vijay Bellur 2016-03-29 09:09:56 UTC
REVIEW: http://review.gluster.org/13839 (extras: allign glusterd stop response in init script) posted (#5) for review on master by Atin Mukherjee (amukherj)

Comment 6 Vijay Bellur 2016-03-30 19:42:05 UTC
COMMIT: http://review.gluster.org/13839 committed in master by Jeff Darcy (jdarcy) 
------
commit dd02c5af9acb77cddc3bbe1ce9a51b7428b24446
Author: Atin Mukherjee <amukherj>
Date:   Tue Mar 29 11:26:39 2016 +0530

    extras: allign glusterd stop response in init script
    
    An echo is missing stop() function which results in bad allignment of glusterd
    stop output
    
    Change-Id: I63ac9571457db90574fb1bfbf4f18ba09d3df1af
    BUG: 1321762
    Signed-off-by: Atin Mukherjee <amukherj>
    Reviewed-on: http://review.gluster.org/13839
    Smoke: Gluster Build System <jenkins.com>
    CentOS-regression: Gluster Build System <jenkins.com>
    NetBSD-regression: NetBSD Build System <jenkins.org>
    Reviewed-by: Jeff Darcy <jdarcy>

Comment 7 Niels de Vos 2016-06-16 14:01:30 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.8.0, please open a new bug report.

glusterfs-3.8.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://blog.gluster.org/2016/06/glusterfs-3-8-released/
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user


Note You need to log in before you can comment on or make changes to this bug.