Hide Forgot
Description of problem: https://git.fedorahosted.org/cgit/389/winsync.git/tree/passwordsync/wix/PassSync.wxs#n273 <RegistryKey Id='NotPkgs' Root='HKLM' Key='SYSTEM\ControlSet001\Control\Lsa' ForceCreateOnInstall='yes' > <RegistryValue Name='Notification Packages' Type='multiString' Value='passhook'/> </RegistryKey> Here key "Notification Packages" should be *appended* with the new value 'passhook'. But instead installer *replaces* the old values with the new one. Before the installation of PassSync: ---- C:\Users\Administrator>reg query HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Lsa /v "Notification Packages" HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Lsa Notification Packages REG_MULTI_SZ scecli\0rassfm ---- After the installation of PassSync: ---- C:\Users\Administrator>reg query HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Lsa /v "Notification Packages" HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Lsa Notification Packages REG_MULTI_SZ passhook ---- And during the uninstallation it removes the key completely (which also should not happen): ---- C:\Users\Administrator>reg query HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Lsa /v "Notification Packages" ERROR: The system was unable to find the specified registry key or value. ---- Version-Release number of selected component (if applicable): RedHat-PassSync-1.1.6-x86_64.msi How reproducible: always Steps to Reproduce: 1. Setup Windows 2008R2 with AD 2. Check the value of "Notification Packages" reg query HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Lsa /v "Notification Packages" 3. Install passsync 4. Check the value of "Notification Packages" 5. Uninstall passsync 6. Check the value of "Notification Packages" Actual results: Old value is replaced with "passhook". Expected results: Value "passhook" should be appended
Thank you, Viktor! Is it okay to associate this bug to these errata and respin passsync? https://errata.devel.redhat.com/advisory/22997 https://errata.devel.redhat.com/advisory/22998
Sure, Noriko! I was about to propose it :) I have a patch for this issue, will post it to the upstream ticket in a minute.
(In reply to Viktor Ashirov from comment #2) > Sure, Noriko! I was about to propose it :) > I have a patch for this issue, will post it to the upstream ticket in a > minute. Fantastic!! Thank you so much, Viktor!
Build tested: RedHat-PassSync-1.1.7-x86_64.msi Before the installation: C:\Users\Administrator>reg query HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Lsa /v "Notification Packages" HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Lsa Notification Packages REG_MULTI_SZ rassfm\0scecli After the installation: C:\Users\Administrator>reg query HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Lsa /v "Notification Packages" HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Lsa Notification Packages REG_MULTI_SZ rassfm\0scecli\0passhook After the uninstallation: C:\Users\Administrator>reg query HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Lsa /v "Notification Packages" HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\Lsa Notification Packages REG_MULTI_SZ rassfm\0scecli Marking as VERIFIED.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2016-0645.html