Bug 1322198 - hardlink skips certain "dot" files
Summary: hardlink skips certain "dot" files
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: hardlink
Version: 25
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: Francisco Javier Tsao Santín
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-03-30 01:51 UTC by todd_lewis
Modified: 2017-04-27 20:54 UTC (History)
2 users (show)

Fixed In Version: hardlink-1.3-1.fc26
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2017-04-27 20:54:31 UTC
Type: Bug


Attachments (Terms of Use)
patch to optionally include dotfiles with six character extension (2.75 KB, patch)
2016-04-25 13:43 UTC, todd_lewis
no flags Details | Diff

Description todd_lewis 2016-03-30 01:51:23 UTC
Description of problem:
File names that start with "." and end with a different "." followed by exactly 6 non-periods are skipped

Version-Release number of selected component (if applicable):
hardlink-1.0-22

How reproducible:
Always

Steps to Reproduce:
1. hardlink -v foo
2.
3.

Actual results:
Skipping foo/google-chrome/.com.google.Chrome.y7Yk64
Skipping foo/google-chrome/Default/.com.google.Chrome.PoAF6r
Skipping foo/selinux/targeted/.policy.sha512
...

Expected results:
Files matching pattern should be eligible for hardlinking.

Additional info:
There is explicit code to skip dot files that have more than one dot and a 6-character extension. This should either be removed from the code, or explained in the man page and/or made optional. It's such a bizarre thing that it must have served a purpose at one point, though I can't imagine what that was. At least it does print a message that the file(s) were skipped if the -v flag is given.

 q = strrchr (di->d_name, '.');
 if (q && strlen (q) == 7 && q != di->d_name) {
   nam1.buf[nam1baselen] = 0;
   if (verbose)
     fprintf(stderr, "Skipping %s%s\n", nam1.buf, di->d_name);
   continue;
 }

Comment 1 todd_lewis 2016-04-25 13:43:34 UTC
Created attachment 1150503 [details]
patch to optionally include dotfiles with six character extension

This proposed patch adds a flag to bypass the bizarre default behavior of skipping dotfiles with six character extensions. Chose to do it this way so the the default behavior does not change (in the off chance somebody is doing this on purpose). Applies against current HEAD.

Comment 2 Fedora Admin XMLRPC Client 2016-05-30 14:58:17 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 3 Fedora Admin XMLRPC Client 2016-05-31 22:00:12 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 4 Fedora End Of Life 2016-11-24 16:17:34 UTC
This message is a reminder that Fedora 23 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 23. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '23'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 23 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 5 Fedora Update System 2017-04-23 23:47:42 UTC
hardlink-1.3-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-db1d0d0f9c

Comment 6 Fedora Update System 2017-04-25 21:27:58 UTC
hardlink-1.3-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-db1d0d0f9c

Comment 7 Fedora Update System 2017-04-27 20:54:31 UTC
hardlink-1.3-1.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.