RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1322210 - Fail to hotplug guest agent with libvirt-1.3.2-1.el7
Summary: Fail to hotplug guest agent with libvirt-1.3.2-1.el7
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: libvirt
Version: 7.3
Hardware: x86_64
OS: Unspecified
unspecified
medium
Target Milestone: rc
: ---
Assignee: Martin Kletzander
QA Contact: Virtualization Bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-03-30 03:01 UTC by zhenfeng wang
Modified: 2016-11-03 18:40 UTC (History)
6 users (show)

Fixed In Version: libvirt-2.0.0-1.el7
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-11-03 18:40:55 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2016:2577 0 normal SHIPPED_LIVE Moderate: libvirt security, bug fix, and enhancement update 2016-11-03 12:07:06 UTC

Description zhenfeng wang 2016-03-30 03:01:53 UTC 
Description of problem:
Fail to hotplug guest agent with the latest libvirt packet

Version-Release number of selected component (if applicable):
libvirt-1.3.2-1.el7

How reproducible:
100%

Steps to Reproduce:
1.Prepare a running guest without guest agent configured
# virsh list --all
 Id    Name                           State
----------------------------------------------------
 1     virt-tests-vm3                 running

2.Prepare a guest agent xml
# cat agent.xml 
   <channel type='unix'>
      <source mode='bind'/>
      <target type='virtio' name='org.qemu.guest_agent.0'/>
      <address type='virtio-serial' controller='0' bus='0' port='1'/>
    </channel>

3.Hotplug the guest agent, will report the following error
# virsh attach-device virt-tests-vm3 agent.xml 
error: Failed to attach device from agent.xml
error: internal error: unable to execute QEMU command 'chardev-add': Invalid parameter type for 'path', expected: string

4.Check the loginfo, found following messages
#cat /var/log/libvirt/libvirtd.log
--
2016-03-25 09:02:22.847+0000: 10269: debug : qemuMonitorJSONCheckError:374 : unable to execute QEMU command {"execute":"chardev-add","arguments":{"id":"charchannel0","backend":{"type":"socket","data":{"addr":{"type":"unix","data":{"path":null}},"wait":false,"server":true}}},"id":"libvirt-12"}: {"id":"libvirt-12","error":{"class":"GenericError","desc":"Invalid parameter type for 'path', expected: string"}}

Actual results:
Fail to hotplug guest agent

Expected results:
Should hotplug guest agent successfully

Additional info:
It works well in RHEL7.2.Z with libvirt-1.2.17-13.el7_2.2.x86_64
Comment 2 Martin Kletzander 2016-03-31 07:16:51 UTC 
Patch proposed upstream:

https://www.redhat.com/archives/libvir-list/2016-March/msg01454.html
Comment 4 Martin Kletzander 2016-06-09 11:30:30 UTC 
Fixed upstream with v1.3.5-181-gf670008b58b7..v1.3.5-183-g326e5941cd6a: 

commit f670008b58b7951d0d05c2bd0317cf498bf463c2
Author: Martin Kletzander <mkletzan>
Date:   Wed Mar 30 16:34:17 2016 +0200

    qemu: Move channel path generation out of command creation
     

commit f3717047081455e2b46fbf0d25620fe9ade5b19e
Author: Martin Kletzander <mkletzan>
Date:   Wed Mar 30 09:01:11 2016 +0200

    qemuhotplugtest: Test live data
    
commit 326e5941cd6ac00a9aa4149872f71c2403f25db4
Author: Martin Kletzander <mkletzan>
Date:   Wed Mar 30 16:43:28 2016 +0200

    qemu: Generate channel target paths on hotplug as well
Comment 6 Yanqiu Zhang 2016-07-21 07:12:20 UTC 
Reproduce this bug with libvirt-1.3.2-1.el7.x86_64
Steps and results are as comment 0.

Verify this bug with libvirt-2.0.0-2.el7.x86_64
Steps to verify:

1.Prepare a running guest without guest agent configured
# virsh list
 Id    Name                           State
----------------------------------------------------
 3     testvm                         running
# virsh domtime testvm
error: argument unsupported: QEMU guest agent is not configured

2.Prepare a guest agent xml
# cat agent1.xml 
    <channel type='unix'>
      <source mode='bind'/>
      <target type='virtio' name='org.qemu.guest_agent.0'/>
      <address type='virtio-serial' controller='0' bus='0' port='1'/>
    </channel>

3.Hotplug the guest agent, can be attached successfully, and guest agent works well.
# virsh attach-device testvm agent1.xml
Device attached successfully

# virsh dumpxml testvm|grep agent -A3
      <source mode='bind' path='/var/lib/libvirt/qemu/channel/target/domain-42-testvm/org.qemu.guest_agent.0'/>
      <target type='virtio' name='org.qemu.guest_agent.0' state='connected'/>
      <alias name='channel1'/>
      <address type='virtio-serial' controller='0' bus='0' port='1'/>
    </channel>

# virsh domtime testvm
Time: 1469077961

Since the result is as expected, mark this bug verified.
Comment 8 errata-xmlrpc 2016-11-03 18:40:55 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2016-2577.html
Note You need to log in before you can comment on or make changes to this bug.