Bug 1322933 - VDSM doesn't disconnect multiple iSCSI sessions
Summary: VDSM doesn't disconnect multiple iSCSI sessions
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: vdsm
Classification: oVirt
Component: Core
Version: 4.17.23
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: ---
Assignee: Vojtech Juranek
QA Contact: Avihai
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-03-31 17:15 UTC by Pavel Gashev
Modified: 2020-06-26 16:37 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-04-01 14:46:56 UTC
oVirt Team: Storage
Embargoed:
frolland: needinfo-
rule-engine: ovirt-4.3+
sbonazzo: ovirt-4.5?
rule-engine: exception+
rule-engine: planning_ack+
tnisan: devel_ack+
acanan: testing_ack+

Attachments (Terms of Use)
the fix (1.98 KB, patch)
2016-03-31 17:15 UTC, Pavel Gashev 		no flags Details | Diff
View All


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 55578 0 'None' ABANDONED storage: fix disconnecting multiple iSCSI sessions 2020-03-24 08:48:17 UTC

Description Pavel Gashev 2016-03-31 17:15:22 UTC 
Created attachment 1142313 [details]
the fix

If I increase node.session.nr_sessions in /etc/iscsi/iscsid.conf VDSM can establish multiple iSCSI sessions per iSCSI target over the same iface. Unfortunately VDSM doesn't disconnect all established sessions. Maintenance mode disconnects the first connected session only. Other sessions remain connected.

Please find attached a patch to fix the bug.
Comment 1 Sandro Bonazzola 2016-05-02 10:02:00 UTC 
Moving from 4.0 alpha to 4.0 beta since 4.0 alpha has been already released and bug is not ON_QA.
Comment 2 Yaniv Kaul 2016-05-08 11:00:48 UTC 
Nir - is this going to make it to 4.0?
Comment 3 Nir Soffer 2016-05-08 15:09:30 UTC 
(In reply to Yaniv Kaul from comment #2)
> Nir - is this going to make it to 4.0?

I'm waiting to networking folks to approve this.
Comment 4 Yaniv Lavi 2016-05-23 13:17:37 UTC 
oVirt 4.0 beta has been released, moving to RC milestone.
Comment 5 Yaniv Lavi 2016-05-23 13:21:33 UTC 
oVirt 4.0 beta has been released, moving to RC milestone.
Comment 6 Sandro Bonazzola 2019-01-28 09:36:58 UTC 
This bug has not been marked as blocker for oVirt 4.3.0.
Since we are releasing it tomorrow, January 29th, this bug has been re-targeted to 4.3.1.
Comment 7 Nir Soffer 2019-03-17 16:10:25 UTC 
I think we need to test how node.session.nr_sessions affects performance.

If this give significant improvement, we need to support this configuration
in engine or in vdsm configuration.

If the system is configured to use multiple sessions, vdsm should disconnect
multiple sessions.

We also have to test how this plays with managed volumes. We don't want vdsm
to disconnect sessions created by ManagedVolume.attach_volume().
Comment 8 Nir Soffer 2019-03-17 16:53:37 UTC 
Mordechay, can we test the affect of multiple sessions on performance?
Comment 9 Tal Nisan 2019-03-18 09:38:23 UTC 
Patch is abandoned, moving back to new until we decide on the course of action here
Comment 10 Michal Skrivanek 2020-03-19 15:40:58 UTC 
We didn't get to this bug for more than 2 years, and it's not being considered for the upcoming 4.4. It's unlikely that it will ever be addressed so I'm suggesting to close it.
If you feel this needs to be addressed and want to work on it please remove cond nack and target accordingly.
Comment 11 Michal Skrivanek 2020-04-01 14:46:56 UTC 
Closing old bug. Please reopen if still relevant/you want to work on it.
Note You need to log in before you can comment on or make changes to this bug.