Bug 1324118 - python-django-extra-form-fields: Provide a Python 3 subpackage
Summary: python-django-extra-form-fields: Provide a Python 3 subpackage
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-django-extra-form-fields
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Matthias Runge
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3 1534542
TreeView+ depends on / blocked
 
Reported: 2016-04-05 14:48 UTC by Tomas Orsava
Modified: 2018-01-16 12:25 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2018-01-16 11:55:47 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
Patch adding python 2 and 3 subpackages (4.01 KB, patch)
2016-09-28 04:35 UTC, Athos Ribeiro
no flags Details | Diff

Description Tomas Orsava 2016-04-05 14:48:25 UTC
Upstream, this software supports Python 3. Please provide a Python 3
package for Fedora.


According to the Python packaging guidelines [0], software must be
packaged for Python 3 if upstream supports it.
The guidelines give detailed information on how to do this, and even
provide an example spec file [1].

The current best practice is to provide subpackages for the two Python
versions (called "Common SRPM" in the guidelines). Alternatively, if
nothing depends on your Python2 package, you can just switch to Python 3
entirely.

It's ok to do this in Rawhide only, however, it would be greatly
appreciated if you could push it to Fedora 24 as well.


If anything is unclear, or if you need any kind of assistance with the
porting, you can ask on IRC (#fedora-python on Freenode), or reply here.
We'll be happy to help!


[0] https://fedoraproject.org/wiki/Packaging:Python
[1] https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file

Comment 1 Athos Ribeiro 2016-07-22 18:06:59 UTC
Upstream supports python 3 but there are no tags in their git repositories. We use pypi for sources and the version there is outdated.

I opened a github issue here https://github.com/ASKBOT/django-extra-form-fields/issues/2 asking if they could generate a new pypi release with python 3 support so we won't need to package from a specific commit nor apply patches before building, does it sound reasonable?

Comment 2 Jan Kurik 2016-07-26 04:48:14 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 25 development cycle.
Changing version to '25'.

Comment 3 Tomas Orsava 2016-07-26 12:57:58 UTC
Hi Athos!
Thank you for taking the initiative. Yes, that absolutely does sound reasonable.
However, if they won't respond, I think it would be better to package it from a commit.

Comment 4 Athos Ribeiro 2016-09-28 04:35:41 UTC
Created attachment 1205400 [details]
Patch adding python 2 and 3 subpackages

Since upstream did not respond to our request mentioned in my previous comment, I prepared a patch from their commit in github which adds support to python3.

Comment 5 Athos Ribeiro 2016-09-28 04:38:59 UTC
Here is a COPR build: https://copr.fedorainfracloud.org/coprs/ribeiro/fedora/build/458527/

Comment 6 Matthias Runge 2016-09-28 07:19:08 UTC
Thank you for looking into this Athos. I'd try to avoid cherry-picking patches from upstream and would like to see a release.

Askbot does not work on recent Fedoras anyways ("Branch master supports Django 1.8")

Django-1.8 was in Fedora 23, we have Django-1.10 in rawhide.

Comment 7 Athos Ribeiro 2016-09-28 16:20:22 UTC
(In reply to Matthias Runge from comment #6)
> Thank you for looking into this Athos. I'd try to avoid cherry-picking
> patches from upstream and would like to see a release.

Ok, I agree with that.

> Askbot does not work on recent Fedoras anyways ("Branch master supports
> Django 1.8")
> 
> Django-1.8 was in Fedora 23, we have Django-1.10 in rawhide.

What should our approach be whenever 23 meets EOL and askbot is not supporting django 1.8?

Comment 8 Matthias Runge 2016-09-29 06:16:26 UTC
In my understanding, we're keeping askbot, because we have ask.fedoraproject.org running.

If it fails on current releases, I'd retire askbot. We could keep it alive in el6/7 branches.

Comment 9 Fedora End Of Life 2017-11-16 19:08:35 UTC
This message is a reminder that Fedora 25 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 25. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '25'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version'
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not
able to fix it before Fedora 25 is end of life. If you would still like
to see this bug fixed and are able to reproduce it against a later version
of Fedora, you are encouraged  change the 'version' to a later Fedora
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's
lifetime, sometimes those efforts are overtaken by events. Often a
more recent Fedora release includes newer upstream software that fixes
bugs or makes them obsolete.

Comment 10 Fedora End Of Life 2017-12-12 10:52:02 UTC
Fedora 25 changed to end-of-life (EOL) status on 2017-12-12. Fedora 25 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.

Comment 11 Miro Hrončok 2017-12-12 12:05:06 UTC
This is still relevant. Note that Django 2 drops Python 2 support. Either kill this, or update it to Python 3 please.

Comment 12 Matthias Runge 2017-12-12 14:16:26 UTC
My vote would be to kill it, unless someone wants to maintain it.
I can retire the package in 2 weeks.

Comment 13 Miro Hrončok 2018-01-16 11:42:26 UTC
Matthias, please retire.

Comment 14 Matthias Runge 2018-01-16 11:55:47 UTC
thanks for the heads-up. done.

Comment 15 Miro Hrončok 2018-01-16 12:25:12 UTC
Thanks. Don't forget to obsolete it from python3-django, same as https://src.fedoraproject.org/rpms/python-django/c/c5e96280d692c5ac35e4f87a2168002abb0cbec2


Note You need to log in before you can comment on or make changes to this bug.