Bug 1324125 - macpool addresses are not forced to lowercase
Summary: macpool addresses are not forced to lowercase
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: unspecified
Hardware: x86_64
OS: Linux
low
low
Target Milestone: ovirt-4.0.2
: 4.0.2
Assignee: Martin Mucha
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-05 15:02 UTC by Martin Tessun
Modified: 2019-10-10 11:50 UTC (History)
11 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-08-23 20:34:32 UTC
oVirt Team: Network
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2016:1743 0 normal SHIPPED_LIVE Red Hat Virtualization Manager 4.0 GA Enhancement (ovirt-engine) 2016-09-02 21:54:01 UTC
oVirt gerrit 57264 0 master MERGED core: when persisting or updating mac pool into db, store macs in lowercase 2016-05-30 13:42:57 UTC
oVirt gerrit 58286 0 ovirt-engine-4.0 MERGED core: when persisting or updating mac pool into db, store macs in lowercase 2016-07-19 08:42:27 UTC
oVirt gerrit 58312 0 master MERGED core: Fix broken DAO tests 2016-05-31 08:58:18 UTC
oVirt gerrit 58359 0 ovirt-engine-4.0 ABANDONED core: mac-pool ranges should be in lower-case 2016-07-07 10:05:50 UTC
oVirt gerrit 60276 0 ovirt-engine-4.0 ABANDONED core: mac-pool ranges shoult be in lower-case 2016-07-06 15:12:57 UTC

Description Martin Tessun 2016-04-05 15:02:47 UTC
Description of problem:
If you add a macpool via API the case of the macaddress is preserved.
It is exected that the mac address is streamlined in the output

Version-Release number of selected component (if applicable):
RHEV 3.6

How reproducible:
always

Steps to Reproduce:
1. Add a macpool with small and capital letters in the macaddress as follows:
[root@ovirt xml]# cat macpool_new.xml 
<mac_pool>
    <name>Testpool</name>
    <description>My Testpool</description>
    <allow_duplicates>false</allow_duplicates>
    <ranges>
        <range>
            <to>00:1a:4B:01:00:00</to>
            <from>00:1a:4c:FF:FF:FF</from>
        </range>
    </ranges>
</mac_pool>

[root@ovirt xml]# curl -s -k -u 'admin@internal:password' -X POST 'Accept: application/xml' -H 'Content-type: application/xml' -d @/root/xml/macpool_new.xml https://ovirt.satellite.local/ovirt-engine/api/macpools
<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<mac_pool href="/ovirt-engine/api/macpools/2a6b90af-7c1b-43ff-a740-1264fa17f94d" id="2a6b90af-7c1b-43ff-a740-1264fa17f94d">
    <name>Testpool</name>
    <description>My Testpool</description>
    <allow_duplicates>false</allow_duplicates>
    <default_pool>false</default_pool>
    <ranges>
        <range>
            <from>00:1a:4c:FF:FF:FF</from>
            <to>00:1a:4B:01:00:00</to>
        </range>
    </ranges>
</mac_pool>
[root@ovirt xml]# 
2. Check the content in the macpool (again with curl):
[root@ovirt xml]# curl -s -k -u 'admin@internal:password' https://ovirt.satellite.local/ovirt-engine/api/macpools/<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<mac_pools>
    <mac_pool href="/ovirt-engine/api/macpools/0000000d-000d-000d-000d-000000000259" id="0000000d-000d-000d-000d-000000000259">
        <name>Default</name>
        <description>Default MAC pool</description>
        <allow_duplicates>false</allow_duplicates>
        <default_pool>true</default_pool>
        <ranges>
            <range>
                <from>00:1A:4A:16:01:51</from>
                <to>00:1A:4A:16:01:e6</to>
            </range>
        </ranges>
    </mac_pool>
    <mac_pool href="/ovirt-engine/api/macpools/2a6b90af-7c1b-43ff-a740-1264fa17f94d" id="2a6b90af-7c1b-43ff-a740-1264fa17f94d">
        <name>Testpool</name>
        <description>My Testpool</description>
        <allow_duplicates>false</allow_duplicates>
        <default_pool>false</default_pool>
        <ranges>
            <range>
                <from>00:1a:4c:FF:FF:FF</from>
                <to>00:1a:4B:01:00:00</to>
            </range>
        </ranges>
    </mac_pool>
</mac_pools>
[root@ovirt xml]# 

Actual results:
The Macaddress is case preserved as: 00:1a:4c:FF:FF:FF

Expected results:
The Macaddresses should be always the same case (preferrably lower case), e.g. 00:1a:4c:ff:ff:ff

Additional info:

Comment 1 Dan Kenigsberg 2016-04-14 07:42:16 UTC
is there any impact on the customer, or is it only a matter of elegance (I hate UPPERCASE myself)? Please correct me if the severity is not low.

Comment 2 Martin Tessun 2016-04-14 07:45:14 UTC
Hi Dan,

I agree, it is only a matter of elegance and a matter of easier comparison within scripts.
With mixed case, scripts need to take the action to "unify" the case.

Cheers,
Martin

Comment 3 Yaniv Lavi 2016-05-09 10:56:37 UTC
oVirt 4.0 Alpha has been released, moving to oVirt 4.0 Beta target.

Comment 7 Meni Yakove 2016-07-24 08:21:04 UTC
rhevm-4.0.2-0.1.rc.el7ev.noarch

Comment 9 errata-xmlrpc 2016-08-23 20:34:32 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2016-1743.html


Note You need to log in before you can comment on or make changes to this bug.