Spec URL: https://fedorapeople.org/cgit/vondruch/public_git/rubygem-cucumber-wire.git/tree/rubygem-cucumber-wire.spec?id=5b37e754717ceeaa505ff1a27d5be1ebb2a03c8c SRPM URL: http://people.redhat.com/vondruch/rubygem-cucumber-wire-0.0.1-1.fc25.src.rpm Description: Wire protocol for Cucumber Fedora Account System Username: vondruch Please note that this has circular dependency with cucumber, so you'll need its updated version together with its dependencies for testing. You might find these scratch builds useful for testing: http://koji.fedoraproject.org/koji/taskinfo?taskID=13564836 http://koji.fedoraproject.org/koji/taskinfo?taskID=13574243
I should probably provide the link to plain text .spec file, so here it is: https://fedorapeople.org/cgit/vondruch/public_git/rubygem-cucumber-wire.git/plain/rubygem-cucumber-wire.spec?id=5b37e754717ceeaa505ff1a27d5be1ebb2a03c8c
Please note that the rubygem-cucumber-core was already imported into Fedora.
I am taking this review.
Package Review ============== The package is fine, apart from missing LICENSE file, therefore I APPROVE this package. Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated Notes: ====== - The packager should ask upstream to include LICENSE file. But this is not a blocker. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. [-]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [-]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Ruby: [-]: Platform dependent files must all go under %{gem_extdir_mri}, platform independent under %{gem_dir}. [x]: Gem package must not define a non-gem subpackage [x]: Macro %{gem_extdir} is deprecated. [x]: Gem package is named rubygem-%{gem_name} [x]: Package contains BuildRequires: rubygems-devel. [x]: Gem package must define %{gem_name} macro. [x]: Pure Ruby package must be built as noarch [x]: Package does not contain Requires: ruby(abi). ===== SHOULD items ===== Generic: [-]: Avoid bundling fonts in non-fonts packages. [!]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [-]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. Note: one test has invalid output and is therefore disabled. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Ruby: [x]: Gem package should exclude cached Gem. [x]: Gem should use %gem_install macro. [x]: Specfile should use macros from rubygem-devel package. [x]: Test suite of the library should be run. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: rubygem-cucumber-wire-0.0.1-1.fc25.noarch.rpm rubygem-cucumber-wire-doc-0.0.1-1.fc25.noarch.rpm rubygem-cucumber-wire-0.0.1-1.fc25.src.rpm rubygem-cucumber-wire.noarch: W: no-documentation 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- sh: /usr/bin/python: No such file or directory rubygem-cucumber-wire.noarch: W: no-documentation 2 packages and 0 specfiles checked; 0 errors, 1 warnings. Requires -------- rubygem-cucumber-wire-doc (rpmlib, GLIBC filtered): rubygem-cucumber-wire rubygem-cucumber-wire (rpmlib, GLIBC filtered): ruby(rubygems) Provides -------- rubygem-cucumber-wire-doc: rubygem-cucumber-wire-doc rubygem-cucumber-wire: rubygem(cucumber-wire) rubygem-cucumber-wire Source checksums ---------------- https://rubygems.org/gems/cucumber-wire-0.0.1.gem : CHECKSUM(SHA256) this package : 4ea8ca3f772d80876eb50533ab10521b383d866419bd6e838b822f0d16ded527 CHECKSUM(SHA256) upstream package : 4ea8ca3f772d80876eb50533ab10521b383d866419bd6e838b822f0d16ded527 Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -r -n rubygem-cucumber-wire-0.0.1-1.fc25.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Ruby, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, DISTTAG, EPEL5, BATCH, EPEL6
Thx for the review. I requested the license file here: https://github.com/cucumber/cucumber-ruby-wire/issues/4
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/rubygem-cucumber-wire