Hide Forgot
Spec URL: http://www.cora.nwra.com/~orion/fedora/python-locket.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/python-locket-0.2.0-1.fc25.src.rpm Description: Locket implements a lock that can be used by multiple processes provided they use the same path. Locks largely behave as (non-reentrant) Lock instances from the threading module in the standard library. Specifically, their behaviour is: * Locks are uniquely identified by the file being locked, both in the same process and across different processes. * Locks are either in a locked or unlocked state. * When the lock is unlocked, calling acquire() returns immediately and changes the lock state to locked. * When the lock is locked, calling acquire() will block until the lock state changes to unlocked, or until the timeout expires. * If a process holds a lock, any thread in that process can call release() to change the state to unlocked. * Behaviour of locks after fork is undefined. Fedora Account System Username: orion
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Result ====== Looks good, one small note: In python2 sub-package, could you use python2-setuptools/python2-nose instead of python-(...), they are provided in F24+, you may use condition for EPEL support ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [?]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python2-locket-0.2.0-1.fc25.noarch.rpm python3-locket-0.2.0-1.fc25.noarch.rpm python-locket-0.2.0-1.fc25.src.rpm python2-locket.noarch: W: spelling-error %description -l en_US reentrant -> re entrant, re-entrant, entrant python2-locket.noarch: W: spelling-error %description -l en_US behaviour -> behavior 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Requires -------- python3-locket (rpmlib, GLIBC filtered): python(abi) python2-locket (rpmlib, GLIBC filtered): python(abi) Provides -------- python3-locket: python3-locket python3.5dist(locket) python2-locket: python-locket python2-locket python2.7dist(locket) Source checksums ---------------- https://github.com/mwilliamson/locket.py/archive/0.2.0.tar.gz#/locket-0.2.0.tar.gz : CHECKSUM(SHA256) this package : 85ae716ac9e929e03dc8ed5e2725159d2d7570735fb2d0981ad453910b574ed1 CHECKSUM(SHA256) upstream package : 85ae716ac9e929e03dc8ed5e2725159d2d7570735fb2d0981ad453910b574ed1
Thanks for the review. Updated: Spec URL: http://www.cora.nwra.com/~orion/fedora/python-locket.spec SRPM URL: http://www.cora.nwra.com/~orion/fedora/python-locket-0.2.0-2.fc25.src.rpm %changelog * Mon Jul 11 2016 Orion Poplawski <orion.com> - 0.3.2-2 - Use python2 names where possible
Thanks, package approved.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/python-locket
Checked in and built.
*** Bug 1484213 has been marked as a duplicate of this bug. ***