Bug 1325478 - Please re-import translations for 3.6.7
Summary: Please re-import translations for 3.6.7
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Frontend.WebAdmin
Version: 3.6.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-3.6.7
: 3.6.7
Assignee: Scott Dickerson
QA Contact: Yuko Katabami
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2016-04-09 04:38 UTC by Yuko Katabami
Modified: 2016-07-04 12:30 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-07-04 12:30:27 UTC
oVirt Team: UX
Embargoed:
rule-engine: ovirt-3.6.z+
mgoldboi: planning_ack+
oourfali: devel_ack+
pstehlik: testing_ack+

Attachments (Terms of Use)
ja-JP fixed (59.76 KB, image/png)
2016-06-20 11:26 UTC, Yuko Katabami 		no flags Details
ko-KR fixed (43.49 KB, image/png)
2016-06-20 11:26 UTC, Yuko Katabami 		no flags Details
View All


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 56720 0 master MERGED webadmin, userportal: translations update from zanata ovirt-3.6 2016-05-03 14:08:07 UTC
oVirt gerrit 56993 0 ovirt-engine-3.6 MERGED webadmin, userportal: translations update from zanata ovirt-3.6 2016-05-09 13:24:32 UTC
oVirt gerrit 56994 0 ovirt-engine-3.6.6 ABANDONED webadmin, userportal: translations update from zanata ovirt-3.6 2016-05-05 03:30:27 UTC

Description Yuko Katabami 2016-04-09 04:38:25 UTC 
Description of problem:

Our translators had to make some changes to translations after the GA.
It would be great if you could pull updated translations from zanata ovirt-3.6 version and re-import to the product.
Oved advised me that it can be done for 3.6.6.

Version-Release number of selected component (if applicable): 3.6
Comment 1 Red Hat Bugzilla Rules Engine 2016-04-09 04:41:04 UTC 
Bug tickets must have version flags set prior to targeting them to a release. Please ask maintainer to set the correct version flags and only then set the target milestone.
Comment 2 Yaniv Kaul 2016-05-04 18:28:48 UTC 
Pushing to 3.6.7, as it seems like it missed 3.6.6
Comment 3 Oved Ourfali 2016-05-04 18:57:33 UTC 
Why? The final build is next week, isn't it?
Comment 4 Yaniv Kaul 2016-05-04 18:58:14 UTC 
(In reply to Oved Ourfali from comment #3)
> Why? The final build is next week, isn't it?

Right, the blockers only build. This isn't one.
Comment 8 Scott Dickerson 2016-05-09 15:01:38 UTC 
Translations from zanata ovirt-3.6 has been re-imported as of May 5, 2016.

There were issues with translations in messages in the following documents + keys:

  * org.ovirt.engine.ui.webadmin.ApplicationMessages 
    [frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/]
    - cpuInfoLabel

  * org.ovirt.engine.ui.userportal.ApplicationConstants 
    [frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/]
    - cpuInfoLabel

  * org.ovirt.engine.ui.uicompat.UIMessages
    [frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/]
    - cpuInfoLabel
    - cpuInfoMessage

Specifically, the issue is the translated messages have 3 replacement arguments while the corresponding GWT i18n message method has 4 arguments.  Both ovirt unit tests and GWT compilation tests will detect the error and fail the build.  Those 4 keys have been removed from the language files merged to source with patch https://gerrit.ovirt.org/#/c/56993/ while retaining all of the rest of the changes.

The following languages had no changes:
  * German (de)
  * Spanish (es)
  * French (fr)
  * Portuguese, Brazil (pt-BR)
  * Chinese, Simplified China (zh-Hans-CH)

The following languages have changes:
  * Italian (it)
  * Japanese (ja)
  * Korean (ko)
Comment 9 Yuko Katabami 2016-06-20 11:26:09 UTC 
Created attachment 1169847 [details]
ja-JP fixed
Comment 10 Yuko Katabami 2016-06-20 11:26:43 UTC 
Created attachment 1169848 [details]
ko-KR fixed
Comment 11 Yuko Katabami 2016-06-20 11:27:18 UTC 
Verified the fix.
Moving the status to VERIFIED.
Note You need to log in before you can comment on or make changes to this bug.