Spec URL: https://raw.githubusercontent.com/siwinski/rpms/794698933e2332fa475ff98523fe3ec72aafee79/php-aws-php-sns-message-validator/php-aws-php-sns-message-validator.spec SRPM URL: https://siwinski.fedorapeople.org/SRPMS/php-aws-php-sns-message-validator-1.1.0-1.fc23.src.rpm Description: The Amazon SNS Message Validator for PHP library allows you to validate that incoming HTTP(S) POST messages are valid Amazon SNS notifications. This library is standalone and does not depend on the AWS SDK for PHP or Guzzle. Fedora Account System Username: siwinski
Koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=13643479
Created attachment 1146741 [details] phpci.log Note: phpCompatInfo version 5.0.0 DB version 1.7.0 built Apr 12 2016 08:25:26 CEST static analyze results in
Created attachment 1146742 [details] review.txt Generated by fedora-review 0.6.0 (3c5c9d7) last change: 2015-05-20 Command line :/usr/bin/fedora-review -b 1326170 Buildroot used: fedora-rawhide-x86_64
[!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/share/php/Aws/Sns(php- aws-sdk), /usr/share/php/Aws(php-aws-sdk), /usr/share/php/Aws/Sns/Exception(php-aws-sdk) Despite both provide the same dir, there is no conflicts in provided files As this library is a new dep of aws sdk v3, perhaps better to move in the same tree (/usr/share/php/Aws3) I fine to approve the package like this, just wait for your idea about the possible file conflicts if content of php-aws-sdk or this library change in a future version. Changing dir will imply using $fedoraPsr4ClassLoader (shared with php-aws-sdk), but as "Aws\Sns" is a sub namespace of "Aws" perhaps not wanted...
(In reply to Remi Collet from comment #4) > [!]: Package does not own files or directories owned by other packages. > Note: Dirs in package are owned also by: /usr/share/php/Aws/Sns(php- > aws-sdk), /usr/share/php/Aws(php-aws-sdk), > /usr/share/php/Aws/Sns/Exception(php-aws-sdk) > > Despite both provide the same dir, there is no conflicts in provided files > As this library is a new dep of aws sdk v3, perhaps better to move in the > same tree (/usr/share/php/Aws3) > > I fine to approve the package like this, just wait for your idea about the > possible file conflicts if content of php-aws-sdk or this library change in > a future version. > > Changing dir will imply using $fedoraPsr4ClassLoader (shared with > php-aws-sdk), but as "Aws\Sns" is a sub namespace of "Aws" perhaps not > wanted... I much prefer "/usr/share/php/Aws" for this library. There are no current naming conflicts, but I opened https://github.com/aws/aws-php-sns-message-validator/issues/12 asking upstream to guarantee no naming clashes.
Fine for me. === APPROVED ===
THANKS for the review! Package request submitted to pkgdb.
Package request has been approved: https://admin.fedoraproject.org/pkgdb/package/rpms/php-aws-php-sns-message-validator
php-aws-php-sns-message-validator-1.1.0-1.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2016-922e255b00
php-aws-php-sns-message-validator-1.1.0-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2016-25a5f3c38d
php-aws-php-sns-message-validator-1.1.0-1.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-922e255b00
php-aws-php-sns-message-validator-1.1.0-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2016-25a5f3c38d
php-aws-php-sns-message-validator-1.1.0-1.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.
php-aws-php-sns-message-validator-1.1.0-1.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.