Bug 1326279

Bulk update to reflect scope of Red Hat OpenStack Platform 9 and Red Hat OpenStack Platform does not include this issue (No pm_ack+).

This is a legitimate bug, not a feature, and thus should not be blocked by upstream feature freeze.

https://review.openstack.org/325666 merged upstream in master and will be available for OSP10.

This change is verified as being included in the current build of the Manila UI. Adding needinfos on scohen and dschoenb for pm_ack and qa_ack.

Need QA_ACK here.

Created attachment 1217490 [details]
screen shot of share-type is-public button enabled

Created attachment 1217491 [details]
screen shot of share-type is-public button hidden

Created attachment 1217492 [details]
screen shot of private 'test' share-type

Created attachment 1217494 [details]
screen shot of create-share panel with is-public button

@dschoenb:

I went to verify this fix on an overcloud deployment using 2016-10-31.3 puddle.

(I) Downstream code definitely fixes the launchpad bug [1] cited in the case [2] behind this BZ. With default Horizon configuration, share-type 'is_public' checkbox appears as illustrated here [3].  But now if one modifies /etc/openstack-dashboard/local_settings on controllers running horizon to include

OPENSTACK_MANILA_FEATURES = { 'enable_public_share_type_creation': False, }

and runs 'systemctl restart httpd' the button disappears as illustrated here [4]
and the resulting share_type is *not* public, as illustrated for share_type
'test' in [5].

(II) However, the case and this BZ are really asking for two things, not only a fix for [1] but also a way to suppress the choice of 'is_public' when creating *shares* themselves.  This check-button is illustrated here [6].

[1] https://bugs.launchpad.net/bugs/1593057
[2] https://access.redhat.com/support/cases/01614010
[3] https://bugzilla.redhat.com/attachment.cgi?id=1217490
[4] https://bugzilla.redhat.com/attachment.cgi?id=1217491
[5] https://bugzilla.redhat.com/attachment.cgi?id=1217492
[6] https://bugzilla.redhat.com/attachment.cgi?id=1217494

Dustin, my suggestion is that rather than putting this BZ back ON_DEV and having the BZ fix two distinct issues, you should clone the BZ, rename this one to 'Please add ability to disable manila public share type' and mark it Verified on the basis of my screenshots, and target the new BZ (for 'Please add the ability to disable manila public shares') for OSP-11.  I think the fix for it will be straightforward and we can likely bring it back into OSP-10 zstream
but we have file a launchpad bug and get it merged upstream first.

Please let me know if that seems the reasonable thing from your standpoint.

Based on the contents of Tom's screenshots we can safely say that we can disable the creation of Public Share Types in Manila through the Manila UI. Thanks for helping out with this, Tom!

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2016-2948.html